sound-equalizer #105613

Merged

Richard Antalik merged 18 commits from :sound-equalizer into main

2023-08-30 22:36:44 +02:00

Marcos Perez commented

2023-03-09 18:04:25 +01:00

Contributor

Description

UI / UX

The user can create modifiers to audio strips, the same way as video strips. The list of modifiers has been splited in 2 groups, one for video and one for audio (now only one modifier).

The EQ modifier lets you define the sound modification. The power is limited to -30 db - 30 db.

Create ONE graphical band definition
with Python API, user can delete all the graphical band definitions, and create one by one, with their desired ranges

Implementation

The sound equalizer has been made using the Audaspace FFT Convolver.

The blender part creates an array of descriptions of power per "band", and orders the creation of Equalizer (ISound) in the Audaspace part. The equalization is made with an Impulse Response which convolutes with the sound itself. In this case, it uses FFTConvolver.

Improvements / limitations

Audaspace requires a FFTW library for "floats", but the library that comes with blender, to compile, only supports double. As a temporary solution, a conversion step has been created in FFTPlan
little optimization has been applied in the source code
This patch is created with PR #105611 in mind

# Description ## UI / UX The user can create modifiers to audio strips, the same way as video strips. The list of modifiers has been splited in 2 groups, one for video and one for audio (now only one modifier). The EQ modifier lets you define the sound modification. The power is limited to -30 db - 30 db. * Create ONE graphical band definition * with Python API, user can delete all the graphical band definitions, and create one by one, with their desired ranges ## Implementation The sound equalizer has been made using the Audaspace FFT Convolver. The blender part creates an array of descriptions of power per "band", and orders the creation of Equalizer (ISound) in the Audaspace part. The equalization is made with an Impulse Response which convolutes with the sound itself. In this case, it uses FFTConvolver. ## Improvements / limitations * Audaspace requires a FFTW library for "floats", but the library that comes with blender, to compile, only supports double. As a temporary solution, a conversion step has been created in FFTPlan * little optimization has been applied in the source code * This patch is created with PR https://projects.blender.org/blender/blender/pulls/105611 in mind

blender_Ym61YBl8Ys.png

272 KiB

Marcos Perez added 2 commits 2023-03-09 18:04:37 +01:00

65f6e4d438 New reset curve option: constant-median

135e27e7ef Initial patch

Sergey Sharybin added this to the Video Sequencer project 2023-03-10 10:43:46 +01:00

Sergey Sharybin added the

Video Sequencer

labels 2023-03-10 10:44:03 +01:00

Sergey Sharybin requested review from Francesco Siddi 2023-03-10 10:44:14 +01:00

Sergey Sharybin requested review from Sergey Sharybin 2023-03-10 10:44:14 +01:00

Sergey Sharybin requested review from Richard Antalik 2023-03-10 10:44:15 +01:00

Francesco Siddi commented

2023-03-10 10:56:38 +01:00

Member

While this patch introduces a useful feature, it does not deal with design implications such as:

how to provide visual feedback (metering/monitoring)
how to replicate the eq settings across multiple tracks (besides copy-pasting)

Besides that, I have no further feedback.

While this patch introduces a useful feature, it does not deal with design implications such as: - how to provide visual feedback (metering/monitoring) - how to replicate the eq settings across multiple tracks (besides copy-pasting) Besides that, I have no further feedback.

Richard Antalik commented

2023-03-14 02:27:53 +01:00

Member

I have accepted this patch already, so will do so here as well

I have accepted this patch already, so will do so here as well

Richard Antalik approved these changes 2023-03-14 02:28:39 +01:00

Marcos Perez commented

2023-03-16 16:35:51 +01:00

Author

Contributor

@fsiddi I would need more information / help to address your concerns:

visual feedback is a very broad subject. And it would be a whole project by itself. Do you have something definite in mind?
about replicate EQ. Blender has copy / replace modifier and it works. What new way of use have you in mind?

@fsiddi I would need more information / help to address your concerns: * visual feedback is a very broad subject. And it would be a **whole** project by itself. Do you have something definite in mind? * about replicate EQ. Blender has copy / replace modifier and it works. What new way of use have you in mind?

Marcos Perez added 2 commits 2023-03-16 16:38:46 +01:00

daa09bf3f4 Merge branch 'main' into constant-median-curve

55cc12baf7 Merge branch 'constant-median-curve' into sound-equalizer

Francesco Siddi commented

2023-04-17 16:42:41 +02:00

Member

I apologize for not following up on this.

Visual feedback: This is indeed a design challenge, which I'm not able to contribute to at this time.
Copy pasting modifiers is an accepted workflow in Blender, so that's fine.

Feel free to go ahead and merge this patch, and thank you for your contribution! In the future, I hope you'll be interested in further participating in activities that are aligned to the module planning.

I apologize for not following up on this. * Visual feedback: This is indeed a design challenge, which I'm not able to contribute to at this time. * Copy pasting modifiers is an accepted workflow in Blender, so that's fine. Feel free to go ahead and merge this patch, and thank you for your contribution! In the future, I hope you'll be interested in further participating in activities that are aligned to the module planning.

Francesco Siddi approved these changes 2023-04-17 16:47:34 +02:00

Sergey Sharybin reviewed 2023-04-20 10:04:44 +02:00

Sergey Sharybin left a comment

Owner

On a Blender side the code seems acceptable.

The Audaspace is not really clear to me. Was the code submitted to its upstream?

On a Blender side the code seems acceptable. The Audaspace is not really clear to me. Was the code submitted to its upstream?

Sergey Sharybin requested review from Joerg Mueller 2023-04-20 10:04:54 +02:00

Sergey Sharybin approved these changes 2023-04-20 10:06:42 +02:00

Sergey Sharybin left a comment

Owner

From my side I do not really have feedback. Is more about how to move forward and synchronize with the code which comes from an external library. Hence added Joerg.

@iss Can you help taking care of applying the patch in a way that the extern/audaspace is aligned with its upstream?

From my side I do not really have feedback. Is more about how to move forward and synchronize with the code which comes from an external library. Hence added Joerg. @iss Can you help taking care of applying the patch in a way that the extern/audaspace is aligned with its upstream?

Richard Antalik commented

2023-04-20 16:41:14 +02:00

Member

From my side I do not really have feedback. Is more about how to move forward and synchronize with the code which comes from an external library. Hence added Joerg.

@iss Can you help taking care of applying the patch in a way that the extern/audaspace is aligned with its upstream?

I can check how things merge and ensure it's clean.

Since we are in bcon2 now do you think it is OK to merge now or shall I wait for next bcon1?

> From my side I do not really have feedback. Is more about how to move forward and synchronize with the code which comes from an external library. Hence added Joerg. > > @iss Can you help taking care of applying the patch in a way that the extern/audaspace is aligned with its upstream? I can check how things merge and ensure it's clean. Since we are in bcon2 now do you think it is OK to merge now or shall I wait for next bcon1?

Sergey Sharybin commented

2023-04-20 18:25:38 +02:00

Owner

The audaspace changes appears to be merged to the upstream, and to our bundled version already.

The majority of the remaining changes are related to the curve mapping. They seem straightforward and safe.
The rest of the changes seems to be quite isolated in the sequencer area. Doesn't seem to be high risk. But extra check for crashes etc before push never hurts!

The audaspace changes appears to be merged to the upstream, and to our bundled version already. The majority of the remaining changes are related to the curve mapping. They seem straightforward and safe. The rest of the changes seems to be quite isolated in the sequencer area. Doesn't seem to be high risk. But extra check for crashes etc before push never hurts!

Joerg Mueller requested changes 2023-04-20 18:55:55 +02:00

Joerg Mueller left a comment

Member

As I've written on developers.blender.org before accepting this patch I would like any changes to audaspace reverted. Everything necessary is in there already (in upstream audaspace and also ported to blender) and we need fftw3f (the float version not the double version) as a new dependency, since using fftw3d (the double version) is unnecessary here. Afaik, it is possible to have both versions of the library in one project. I've stated a couple of times already on developers.blender.org that the package maintainers have to be contacted to get fftw3f in.

As I've written on developers.blender.org before accepting this patch I would like any changes to audaspace reverted. Everything necessary is in there already (in upstream audaspace and also ported to blender) and we need fftw3f (the float version not the double version) as a new dependency, since using fftw3d (the double version) is unnecessary here. Afaik, it is possible to have both versions of the library in one project. I've stated a couple of times already on developers.blender.org that the package maintainers have to be contacted to get fftw3f in.

Ray molenkamp commented

2023-04-20 19:03:13 +02:00

Member

if the VFX module says they need fftw3f and this patch is getting close to landing, the platform team has no issues doing the lib work. Given the amount of uncertainty in this diff and how long this has been dragging on, I can't justify working on this until @Sergey gives the green light though.

if the VFX module says they need fftw3f and this patch is getting close to landing, the platform team has no issues doing the lib work. Given the amount of uncertainty in this diff and how long this has been dragging on, I can't justify working on this until @Sergey gives the green light though.

Joerg Mueller commented

2023-04-20 20:02:55 +02:00

Member

He already did 10 hours ago :)

He already did 10 hours ago :)

Ray molenkamp commented

2023-04-20 20:41:09 +02:00

Member

Talked to sergey, added the work for the 3.6 lib update in #104895

Talked to sergey, added the work for the 3.6 lib update in #104895

Richard Antalik added 2 commits 2023-05-20 04:49:21 +02:00

b319d20b72 Merge branch 'sound-equalizer' of https://projects.blender.org/pistolario/blender into pistolario-sound-equalizer

6ac585410d Revert changes in Audaspace

Richard Antalik commented

2023-05-20 04:51:04 +02:00

Member

I have reverted changes in Audaspace, I am trying to resolve some build issues on Windows at least still.

I have reverted changes in Audaspace, I am trying to resolve some build issues on Windows at least still.

Joerg Mueller commented

2023-05-20 15:14:47 +02:00

Member

I have reverted changes in Audaspace, I am trying to resolve some build issues on Windows at least still.

Great! I assume once the build issues are resolved, the changes to audaspace's CMakeLists.txt will be reverted as well? At the moment it won't build properly when fftw is disabled since there is still the Equalizer source defined outside the corresponding if that checks if fftw is enabled. Any changes that are necessary regarding the cmake options/variables of audaspace should be made in the blender_config.cmake file.

> I have reverted changes in Audaspace, I am trying to resolve some build issues on Windows at least still. Great! I assume once the build issues are resolved, the changes to audaspace's `CMakeLists.txt` will be reverted as well? At the moment it won't build properly when fftw is disabled since there is still the `Equalizer` source defined outside the corresponding if that checks if fftw is enabled. Any changes that are necessary regarding the cmake options/variables of audaspace should be made in the `blender_config.cmake` file.

tintwotin commented

2023-05-25 13:08:48 +02:00

First-time contributor

Suggested UI improvements:

Make the Start/End of the range edible, so users can limit it to the range they're working in. The default values are far too big for ex. trying to remove a noise close to the range of a voice.
Fix the ranges of the Start/End values, currently they're set to (-100,100), which doesn't make sense.
Add Hz and dB as units and add them to the widgets.

The UI code can be found here: https://gist.github.com/tin2tin/4cb6248b8746b7c132382a438f54be38

Suggested UI improvements: ![image](/attachments/3d3b4c37-6e02-4590-bf1b-a328dc6b59a1) - Make the Start/End of the range edible, so users can limit it to the range they're working in. The default values are far too big for ex. trying to remove a noise close to the range of a voice. - Fix the ranges of the Start/End values, currently they're set to (-100,100), which doesn't make sense. - Add Hz and dB as units and add them to the widgets. The UI code can be found here: https://gist.github.com/tin2tin/4cb6248b8746b7c132382a438f54be38

44 KiB

42 KiB

Richard Antalik added 3 commits 2023-08-13 11:57:11 +02:00

f33a78503d Merge branch 'main' into sound-equalizer

bbdca79df0 Fix cmake setup and compilation issues

buildbot/vexp-code-patch-coordinator Build done. Details

143bd67f5f Fix MSVC build warnings

Richard Antalik commented

2023-08-13 11:58:16 +02:00

Member

@blender-bot build

@blender-bot build

Richard Antalik added 1 commit 2023-08-14 03:31:54 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

b440d0f6fe Fix typo

Richard Antalik commented

2023-08-14 03:32:03 +02:00

Member

@blender-bot build

@blender-bot build

Richard Antalik added 1 commit 2023-08-17 14:11:17 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

bd35eb86b9 Update cmake variables, so it should build on Linux/Mac

Richard Antalik commented

2023-08-17 14:11:29 +02:00

Member

@blender-bot build

@blender-bot build

Richard Antalik added 1 commit 2023-08-17 14:58:59 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

9db996ea5e "fix" FFTW3_FOUND not being defined despite `FindFftw3.cmake` file docs

Richard Antalik commented

2023-08-17 15:02:08 +02:00

Member

@blender-bot build

@blender-bot build

tintwotin commented

2023-08-23 09:36:38 +02:00

First-time contributor

@iss I saw in the weekly notes, that there are some build problems on some of the platforms. UI considerations were mentioned earlier, but it was never mentioned what they were. Does the UI suggestion above address some of them?

@iss I saw in the weekly notes, that there are some build problems on some of the platforms. UI considerations were mentioned earlier, but it was never mentioned what they were. Does the UI suggestion above address some of them?

Richard Antalik commented

2023-08-23 15:47:40 +02:00

Member

@iss I saw in the weekly notes, that there are some build problems on some of the platforms. UI considerations were mentioned earlier, but it was never mentioned what they were. Does the UI suggestion above address some of them?

It's fftw float library integration issue with Linux/Mac. You can see the problem by checking buildbot output. The snippet above does not fix it.

> @iss I saw in the weekly notes, that there are some build problems on some of the platforms. UI considerations were mentioned earlier, but it was never mentioned what they were. Does the UI suggestion above address some of them? It's fftw float library integration issue with Linux/Mac. You can see the problem by checking buildbot output. The snippet above does not fix it.

tintwotin commented

2023-08-23 15:53:10 +02:00

First-time contributor

Please re-read what I wrote. My snippet was addressing UI issues.

Please re-read what I wrote. My snippet was addressing UI issues.

Richard Antalik commented

2023-08-23 16:03:22 +02:00

Member

Are you refering to this comment?

While this patch introduces a useful feature, it does not deal with design implications such as:

how to provide visual feedback (metering/monitoring)

how to replicate the eq settings across multiple tracks (besides copy-pasting)

Besides that, I have no further feedback.

In any case, I am happy to implement your suggestion, but at this moment I need to get this patch to build at all

Are you refering to this comment? > While this patch introduces a useful feature, it does not deal with design implications such as: > > - how to provide visual feedback (metering/monitoring) > - how to replicate the eq settings across multiple tracks (besides copy-pasting) > > Besides that, I have no further feedback. In any case, I am happy to implement your suggestion, but at this moment I need to get this patch to build at all

Richard Antalik added 1 commit 2023-08-28 17:49:49 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

bdf5b111b8 Fix build issue on Linux/Mac

Richard Antalik commented

2023-08-28 17:50:01 +02:00

Member

@blender-bot build

@blender-bot build

Richard Antalik added 2 commits 2023-08-28 18:50:29 +02:00

084ca58761 Merge branch 'main' into sound-equalizer

buildbot/vexp-code-patch-coordinator Build done. Details

31f75f7f7e Fix incorrect changes

Richard Antalik commented

2023-08-28 18:54:21 +02:00

Member

@blender-bot build

@blender-bot build

Joerg Mueller approved these changes 2023-08-28 21:03:44 +02:00

Joerg Mueller left a comment

Member

Thanks @iss for taking care of fftwf! :)

Thanks @iss for taking care of fftwf! :)

Richard Antalik added 1 commit 2023-08-29 15:45:17 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

0177cad13b Merge branch 'main' into sound-equalizer

Richard Antalik added 2 commits 2023-08-30 20:16:17 +02:00

a3dd2129c7 Fix issues after merging

buildbot/vexp-code-patch-coordinator Build done. Details

814fd45e2c Merge branch 'main' into sound-equalizer

Richard Antalik commented

2023-08-30 22:23:34 +02:00

Member

Thanks @iss for taking care of fftwf! :)

Thank you for explanation of how to do this correctly.

> Thanks @iss for taking care of fftwf! :) Thank you for explanation of how to do this correctly.

Richard Antalik merged commit 1015bed2fd into main

2023-08-30 22:36:44 +02:00

Richard Antalik referenced this issue from a commit

2023-08-30 22:36:45 +02:00

VSE: Sound equalizer modifier

Stefan Werner referenced this issue from a commit

2023-09-07 15:02:37 +02:00

VSE: Sound equalizer modifier

Sergey Sharybin removed this from the Video Sequencer project 2023-11-22 11:56:34 +01:00

~~Iliya Katushenock referenced this pull request 2023-11-23 16:56:48 +01:00~~

Bug report. Exporting Audio from Video Editor #115305

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

7 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105613

No description provided.