WIP: Readfile: replace blend_read_lib/blend_read_expand by foreach_id #105666

Closed
Bastien Montagne wants to merge 1 commits from mont29:tmp-readfile-liblink into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

This is a WIP proof of concept for #105134. It is submitted to get early feedback on the idea.

This patch implements the main idea for Action ID type, and do a few more related changes.

Note that the callbacks may still be needed to address some more complex processing performed by a few ID types (like node trees or WM), at least as a first step. Some unrelated processing can be moved to blend_read_data though (as done in this patch with the clearing the NLA tracks flag NLATRACK_OVERRIDELIBRARY_LOCAL for linked data).

This is a WIP proof of concept for #105134. It is submitted to get early feedback on the idea. This patch implements the main idea for Action ID type, and do a few more related changes. Note that the callbacks may still be needed to address some more complex processing performed by a few ID types (like node trees or WM), at least as a first step. Some unrelated processing can be moved to `blend_read_data` though (as done in this patch with the clearing the NLA tracks flag `NLATRACK_OVERRIDELIBRARY_LOCAL` for linked data).
Bastien Montagne added this to the Core project 2023-03-11 18:25:44 +01:00
Author
Owner

@brecht @JacquesLucke this may interest you?

@brecht @JacquesLucke this may interest you?
Member

Looks like a nice improvement. It's a bit sad that we need 3 new flags for this, but I also can't think of a better approach right now.

Looks like a nice improvement. It's a bit sad that we need 3 new flags for this, but I also can't think of a better approach right now.

Makes sense to me.

Makes sense to me.
Hans Goudey changed title from WIP: Readfile: replace blend_read_lib/blend_read_expand by foreach_id. to WIP: Readfile: replace blend_read_lib/blend_read_expand by foreach_id 2023-03-13 19:42:55 +01:00
Bastien Montagne force-pushed tmp-readfile-liblink from 44449e1555 to a8a4535196 2023-08-11 23:50:38 +02:00 Compare
Bastien Montagne force-pushed tmp-readfile-liblink from a8a4535196 to 5b8dd688e7 2023-08-16 22:09:48 +02:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne force-pushed tmp-readfile-liblink from 5b8dd688e7 to 145f98a009 2023-08-20 14:38:53 +02:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne force-pushed tmp-readfile-liblink from 145f98a009 to f12eb32496 2023-08-21 17:47:02 +02:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne force-pushed tmp-readfile-liblink from f12eb32496 to 7cdfd99f26 2023-08-23 11:24:19 +02:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne force-pushed tmp-readfile-liblink from 7cdfd99f26 to 0f1a65143b 2023-08-24 15:27:27 +02:00 Compare
Author
Owner

@blender-bot build

@blender-bot build
Bastien Montagne closed this pull request 2023-08-24 16:40:54 +02:00
Bastien Montagne deleted branch tmp-readfile-liblink 2023-08-24 16:41:02 +02:00
All checks were successful
buildbot/vexp-code-patch-coordinator Build done.

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105666
No description provided.