Cycles: implement faster #make_orthonormals() #106053

Closed
Weizhen Huang wants to merge 1 commits from weizhen/blender:make_orthonormal into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

From paper https://graphics.pixar.com/library/OrthonormalB/paper.pdf . According to my very superficial test this seems 25% faster.
This changes quite a lot test files, for most of them there are just noises, but for displacement map tests the results are quite different, the reason is the function differential_from_compact() when computing ray differentials.

From paper https://graphics.pixar.com/library/OrthonormalB/paper.pdf . According to my very superficial test this seems 25% faster. This changes quite a lot test files, for most of them there are just noises, but for displacement map tests the results are quite different, the reason is the function `differential_from_compact()` when computing ray differentials.
Weizhen Huang added the
Module
Render & Cycles
label 2023-03-23 17:43:54 +01:00
Weizhen Huang added 1 commit 2023-03-23 17:44:10 +01:00
Weizhen Huang requested review from Brecht Van Lommel 2023-03-23 17:44:47 +01:00
Weizhen Huang requested review from Sergey Sharybin 2023-03-23 17:45:06 +01:00
Brecht Van Lommel approved these changes 2023-04-28 16:43:23 +02:00
Brecht Van Lommel left a comment
Owner

The implementation looks fine, but let's wait for 4.0 to merge since this is a slightly breaking change.

The implementation looks fine, but let's wait for 4.0 to merge since this is a slightly breaking change.
Brecht Van Lommel added this to the 4.0 milestone 2023-04-28 16:43:45 +02:00
Author
Member

Merged as 51923c09e2

Merged as 51923c09e2
Weizhen Huang closed this pull request 2023-05-19 16:44:01 +02:00

Pull request closed

Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106053
No description provided.