Animation: Clean up "Key" menu in Graph Editor #106113

Merged
Christoph Lendenfeld merged 10 commits from ChrisLend/blender:ui_clean_up_key_menu into main 2023-05-04 14:10:36 +02:00
  • remove "Keyframe" label from the Key menu
  • "Jump To Keyframe" -> "Jump to Selected"
  • added a new menu "Density" with Decimate, Sample and Clean operators
  • removed the "Clean Channels" entry. It does the same as the "Clean" operator but also removes channels IF the remaining keys are at the default value. The feature is still available in the redo panel
  • Split the slider operators out by functionality
  • Move Euler filter to Channel menu
  • Remove "Add F-Curve modifier" from Key menu (it already is in the Channel menu)
  • Move Bake/Unbake Curve functions to Channel menu
  • Move "Bake Sound to FCurves" to Channel menu
Before After
image image

Issues

  • Because the sliders menu is gone, the "D" hotkey to open that is no longer obvious.
  • It's still a bit long, I am tempted to move "Density" "Blend" and "Smooth" into its own menu next to "Key"
* remove "Keyframe" label from the Key menu * "Jump To Keyframe" -> "Jump to Selected" * added a new menu "Density" with Decimate, Sample and Clean operators * removed the "Clean Channels" entry. It does the same as the "Clean" operator but also removes channels IF the remaining keys are at the default value. The feature is still available in the redo panel * Split the slider operators out by functionality * Move Euler filter to Channel menu * Remove "Add F-Curve modifier" from Key menu (it already is in the Channel menu) * Move Bake/Unbake Curve functions to Channel menu * Move "Bake Sound to FCurves" to Channel menu | Before | After | | - | - | | ![image](/attachments/353955c5-e39c-4d00-833d-c8b8055bb43c) | ![image](/attachments/658e9ffd-fc11-423a-9fc7-63d15be38a8b) | ### Issues * Because the sliders menu is gone, the "D" hotkey to open that is no longer obvious. * It's still a bit long, I am tempted to move "Density" "Blend" and "Smooth" into its own menu next to "Key"
Christoph Lendenfeld added 1 commit 2023-03-24 15:59:14 +01:00
Christoph Lendenfeld added the
Module
Animation & Rigging
Interest
User Interface
labels 2023-03-24 15:59:32 +01:00
Christoph Lendenfeld added 1 commit 2023-03-24 16:12:27 +01:00
Christoph Lendenfeld added 3 commits 2023-03-24 16:57:34 +01:00
Christoph Lendenfeld requested review from Pablo Vazquez 2023-03-24 16:57:35 +01:00
Christoph Lendenfeld changed title from WIP: Animation: Clean up "Key" menu in Graph Editor to Animation: Clean up "Key" menu in Graph Editor 2023-03-24 16:57:44 +01:00
Christoph Lendenfeld requested review from Harley Acheson 2023-03-24 16:58:10 +01:00
Christoph Lendenfeld added this to the Animation & Rigging project 2023-03-24 16:58:19 +01:00
Member

Looking at this reminds me of how much I dislike that our menus can change direction, with this nice ordering being reversed when it pops up rather than down. "Paste Flipped", then "Paste", then "Copy". "Unbake" then "Back". @pablovazquez - is this something we could consider changing for 4.0 and just have every pulldown menu always order top to bottom?

The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" might be considered a better fit?

Looking at this reminds me of how much I dislike that our menus can change direction, with this nice ordering being reversed when it pops up rather than down. "Paste Flipped", then "Paste", then "Copy". "Unbake" then "Back". @pablovazquez - is this something we could consider changing for 4.0 and just have every pulldown menu always order top to bottom? The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" *might* be considered a better fit?
Sybren A. Stüvel reviewed 2023-03-27 16:09:30 +02:00
Sybren A. Stüvel left a comment
Member

LGTM! But I'm not a reviewer so who cares ;-)

LGTM! But I'm not a reviewer so who cares ;-)

The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" might be considered a better fit?

IMO "Density" is better. Smoothing operators also reduce the 'complexity' of the motion, by taking out the high frequencies and 'simplifying' down to only the lower frequencies.

> The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" *might* be considered a better fit? IMO "Density" is better. Smoothing operators also reduce the 'complexity' of the motion, by taking out the high frequencies and 'simplifying' down to only the lower frequencies.
Harley Acheson approved these changes 2023-03-27 16:12:44 +02:00
Christoph Lendenfeld added 3 commits 2023-03-31 15:41:25 +02:00
Christoph Lendenfeld requested review from Harley Acheson 2023-03-31 15:47:25 +02:00
Author
Member

I've updated the PR based on the discussion in the A&R meeting yesterday https://devtalk.blender.org/t/2023-03-30-animation-rigging-module-meeting-upcoming/28530

I've updated the PR based on the discussion in the A&R meeting yesterday https://devtalk.blender.org/t/2023-03-30-animation-rigging-module-meeting-upcoming/28530

In this PR I noticed some code again that I'm not happy with, not specific to this patch but in Blender in general (this patch just copied the existing approach, which in itself is of course fine). So, I wrote a bit of Python (d85520f297) and now instead of this:

default_op_context = layout.context
layout.context = 'OTHER_VALUE'
layout.do_stuff()
layout.context = default_op_context

you can now write this:

from bl_ui_utils.layout import operator_context

with operator_context(layout, 'OTHER_VALUE'):
    layout.do_stuff()

As for the menu changes themselves, I'm happy with the menu as it is now, and I do share your concern that now the 'D' key is in the 'you have to know it exists' realm. Would there be a way to still show that hotkey in the separate slider operator menu items? Maybe @pablovazquez or @Harley know?

In this PR I noticed some code again that I'm not happy with, not specific to this patch but in Blender in general (this patch just copied the existing approach, which in itself is of course fine). So, I wrote a bit of Python (d85520f297e2e79a760f47ad6d66a8d701783768) and now instead of this: ```py default_op_context = layout.context layout.context = 'OTHER_VALUE' layout.do_stuff() layout.context = default_op_context ``` you can now write this: ```py from bl_ui_utils.layout import operator_context with operator_context(layout, 'OTHER_VALUE'): layout.do_stuff() ``` As for the menu changes themselves, I'm happy with the menu as it is now, and I do share your concern that now the 'D' key is in the 'you have to know it exists' realm. Would there be a way to still show that hotkey in the separate slider operator menu items? Maybe @pablovazquez or @Harley know?
Christoph Lendenfeld added 2 commits 2023-04-28 12:09:48 +02:00
Member

Would there be a way to still show that hotkey in the separate slider operator menu items?

No, not seeing a way to do that. It is quite nice in this PR that the different slider operators are categorized so nicely here. Now pressing "D" gives you something useful, but it is akin to a context menu in that it isn't related to the main menu items. Pablo might have thoughts, but I'm not seeing any nice solution.

> Would there be a way to still show that hotkey in the separate slider operator menu items? No, not seeing a way to do that. It is quite nice in this PR that the different slider operators are categorized so nicely here. Now pressing "D" gives you something useful, but it is akin to a context menu in that it isn't related to the main menu items. Pablo might have thoughts, but I'm not seeing any nice solution.
Harley Acheson approved these changes 2023-04-28 18:11:26 +02:00
Member

Having used the D key and then not having it, I missed it right away when trying to quickly get to the filters.. so from animator/motion edit wanting to do things to curves quickly, it is great.

Having used the D key and then not having it, I missed it right away when trying to quickly get to the filters.. so from animator/motion edit wanting to do things to curves quickly, it is great.
Christoph Lendenfeld merged commit 5e1470d1b3 into main 2023-05-04 14:10:36 +02:00
Christoph Lendenfeld deleted branch ui_clean_up_key_menu 2023-05-04 14:10:37 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:42 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106113
No description provided.