Animation: Clean up "Key" menu in Graph Editor #106113

remove "Keyframe" label from the Key menu
"Jump To Keyframe" -> "Jump to Selected"
added a new menu "Density" with Decimate, Sample and Clean operators
removed the "Clean Channels" entry. It does the same as the "Clean" operator but also removes channels IF the remaining keys are at the default value. The feature is still available in the redo panel
Split the slider operators out by functionality
Move Euler filter to Channel menu
Remove "Add F-Curve modifier" from Key menu (it already is in the Channel menu)
Move Bake/Unbake Curve functions to Channel menu
Move "Bake Sound to FCurves" to Channel menu

Before	After

Issues

Because the sliders menu is gone, the "D" hotkey to open that is no longer obvious.
It's still a bit long, I am tempted to move "Density" "Blend" and "Smooth" into its own menu next to "Key"

* remove "Keyframe" label from the Key menu * "Jump To Keyframe" -> "Jump to Selected" * added a new menu "Density" with Decimate, Sample and Clean operators * removed the "Clean Channels" entry. It does the same as the "Clean" operator but also removes channels IF the remaining keys are at the default value. The feature is still available in the redo panel * Split the slider operators out by functionality * Move Euler filter to Channel menu * Remove "Add F-Curve modifier" from Key menu (it already is in the Channel menu) * Move Bake/Unbake Curve functions to Channel menu * Move "Bake Sound to FCurves" to Channel menu | Before | After | | - | - | | ![image](/attachments/353955c5-e39c-4d00-833d-c8b8055bb43c) | ![image](/attachments/658e9ffd-fc11-423a-9fc7-63d15be38a8b) | ### Issues * Because the sliders menu is gone, the "D" hotkey to open that is no longer obvious. * It's still a bit long, I am tempted to move "Density" "Blend" and "Smooth" into its own menu next to "Key"

image.png

31 KiB

image.png

16 KiB

Looking at this reminds me of how much I dislike that our menus can change direction, with this nice ordering being reversed when it pops up rather than down. "Paste Flipped", then "Paste", then "Copy". "Unbake" then "Back". @pablovazquez - is this something we could consider changing for 4.0 and just have every pulldown menu always order top to bottom?

The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" might be considered a better fit?

Looking at this reminds me of how much I dislike that our menus can change direction, with this nice ordering being reversed when it pops up rather than down. "Paste Flipped", then "Paste", then "Copy". "Unbake" then "Back". @pablovazquez - is this something we could consider changing for 4.0 and just have every pulldown menu always order top to bottom? The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" *might* be considered a better fit?

LGTM! But I'm not a reviewer so who cares ;-)

The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" might be considered a better fit?

IMO "Density" is better. Smoothing operators also reduce the 'complexity' of the motion, by taking out the high frequencies and 'simplifying' down to only the lower frequencies.

> The only thing that sticks out specifically here (a little bit) is "Density" being a noun among mostly verbs as a container for actions. I'm guessing that the obvious "Simplify" was spoiled by "Sample Keyframes" increasing density. I can't think of a better single verb, though. If we are stuck with a noun then "Complexity" *might* be considered a better fit? IMO "Density" is better. Smoothing operators also reduce the 'complexity' of the motion, by taking out the high frequencies and 'simplifying' down to only the lower frequencies.

I've updated the PR based on the discussion in the A&R meeting yesterday https://devtalk.blender.org/t/2023-03-30-animation-rigging-module-meeting-upcoming/28530

In this PR I noticed some code again that I'm not happy with, not specific to this patch but in Blender in general (this patch just copied the existing approach, which in itself is of course fine). So, I wrote a bit of Python (d85520f297) and now instead of this:

default_op_context = layout.context
layout.context = 'OTHER_VALUE'
layout.do_stuff()
layout.context = default_op_context

you can now write this:

from bl_ui_utils.layout import operator_context

with operator_context(layout, 'OTHER_VALUE'):
    layout.do_stuff()

As for the menu changes themselves, I'm happy with the menu as it is now, and I do share your concern that now the 'D' key is in the 'you have to know it exists' realm. Would there be a way to still show that hotkey in the separate slider operator menu items? Maybe @pablovazquez or @Harley know?

In this PR I noticed some code again that I'm not happy with, not specific to this patch but in Blender in general (this patch just copied the existing approach, which in itself is of course fine). So, I wrote a bit of Python (d85520f297e2e79a760f47ad6d66a8d701783768) and now instead of this: ```py default_op_context = layout.context layout.context = 'OTHER_VALUE' layout.do_stuff() layout.context = default_op_context ``` you can now write this: ```py from bl_ui_utils.layout import operator_context with operator_context(layout, 'OTHER_VALUE'): layout.do_stuff() ``` As for the menu changes themselves, I'm happy with the menu as it is now, and I do share your concern that now the 'D' key is in the 'you have to know it exists' realm. Would there be a way to still show that hotkey in the separate slider operator menu items? Maybe @pablovazquez or @Harley know?

Would there be a way to still show that hotkey in the separate slider operator menu items?

No, not seeing a way to do that. It is quite nice in this PR that the different slider operators are categorized so nicely here. Now pressing "D" gives you something useful, but it is akin to a context menu in that it isn't related to the main menu items. Pablo might have thoughts, but I'm not seeing any nice solution.

> Would there be a way to still show that hotkey in the separate slider operator menu items? No, not seeing a way to do that. It is quite nice in this PR that the different slider operators are categorized so nicely here. Now pressing "D" gives you something useful, but it is akin to a context menu in that it isn't related to the main menu items. Pablo might have thoughts, but I'm not seeing any nice solution.

Having used the D key and then not having it, I missed it right away when trying to quickly get to the filters.. so from animator/motion edit wanting to do things to curves quickly, it is great.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Animation: Clean up "Key" menu in Graph Editor #106113

Issues

Reviewers