Fix #91256, #112646: IDProperty UI data lost when changing type #106161

Merged
Hans Goudey merged 1 commits from HooglyBoogly/blender:fix-idprop-set-ui-data-reset into blender-v4.1-release 2024-03-12 15:49:33 +01:00
Member

With some data-type conversions we can do a best-effort conversion of
UI data like default values and min and max to the new data type.
This can help to make Python scripts simpler and to avoid bugs like
#105965.

With some data-type conversions we can do a best-effort conversion of UI data like default values and min and max to the new data type. This can help to make Python scripts simpler and to avoid bugs like #105965.
Hans Goudey changed title from Fix #91256: Convert UI data when changing IDProperty data type to WIP: Fix #91256: Convert UI data when changing IDProperty data type 2023-03-27 03:57:04 +02:00
Hans Goudey added this to the Core project 2023-03-27 03:57:46 +02:00
Hans Goudey changed title from WIP: Fix #91256: Convert UI data when changing IDProperty data type to Fix #91256: Convert UI data when changing IDProperty data type 2023-03-27 19:05:46 +02:00
Hans Goudey changed title from Fix #91256: Convert UI data when changing IDProperty data type to Fix #91256, #112646: IDProperty UI data lost when changing type 2024-03-11 18:42:14 +01:00
Hans Goudey requested review from Jacques Lucke 2024-03-11 19:23:51 +01:00
Member

This does not fix #112646. That's because IDP_TryConvertUIData is currently only called when the old and new type actually match.

This does not fix #112646. That's because `IDP_TryConvertUIData` is currently only called when the old and new type actually match.
Author
Member

Thanks, I resolved a merge error incorrectly there. Fixed that and a couple other things and tried to clarify some other parts of the change. Testing on the geometry nodes inputs it works well now.

Thanks, I resolved a merge error incorrectly there. Fixed that and a couple other things and tried to clarify some other parts of the change. Testing on the geometry nodes inputs it works well now.
Jacques Lucke approved these changes 2024-03-12 10:23:18 +01:00
Hans Goudey force-pushed fix-idprop-set-ui-data-reset from 7c736a6eff to 659b0e6db6 2024-03-12 15:22:50 +01:00 Compare
Hans Goudey changed target branch from main to blender-v4.1-release 2024-03-12 15:25:36 +01:00
Hans Goudey force-pushed fix-idprop-set-ui-data-reset from 659b0e6db6 to b36e940179 2024-03-12 15:25:38 +01:00 Compare
Author
Member

@blender-bot build

@blender-bot build
Hans Goudey merged commit 91466f71f1 into blender-v4.1-release 2024-03-12 15:49:31 +01:00
Hans Goudey deleted branch fix-idprop-set-ui-data-reset 2024-03-12 15:49:43 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106161
No description provided.