blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 746 Projects 19 Wiki Activity

I18n: fix add-on extraction when UI code appears in __init__.py #106435

Merged
Bastien Montagne merged 1 commits from pioverfour/blender:dp_fix_addon_message_extraction into main 2023-04-04 10:07:18 +02:00
Conversation 0 Commits 1 Files Changed 1 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
scripts/modules/bl_i18n_utils/bl_extract_messages.py
View File

@ -753,7 +753,8 @@ def dump_py_messages(msgs, reports, addons, settings, addons_only=False):
return []
if os.path.isdir(path):
return [os.path.join(dpath, fn) for dpath, _, fnames in os.walk(path) for fn in fnames
if not fn.startswith("_") and fn.endswith(".py")]
if fn.endswith(".py") and (fn == "__init__.py"
pioverfour marked this conversation as resolved Outdated
Bastien Montagne commented 2023-04-03 15:30:39 +02:00
Outdated
Review
Copy Link

removing the check is not the way to go, it is intended to not parse 'private' files conventionally named like _my_private_module.py. Think it should rather make an explicit exception for __init__.py.

removing the check is not the way to go, it is intended to not parse 'private' files conventionally named like `_my_private_module.py`. Think it should rather make an explicit exception for `__init__.py`.
Damien Picard commented 2023-04-03 16:08:14 +02:00
Review
Copy Link

I see, I didn’t know of this convention for files. The only files making use of it in the Blender repos appear to be presets, so it shouldn’t be a problem!

I see, I didn’t know of this convention for files. The only files making use of it in the Blender repos appear to be presets, so it shouldn’t be a problem!
or not fn.startswith("_"))]
return [path]
files = []