DNA: Move irradiance grid light cache data to Object level #106808

Clément Foucault · 2023-04-11T15:24:19+02:00

Clément Foucault commented

2023-04-11 15:24:19 +02:00

This is the first step for refactoring the lightcache system.
Each probe instance (as in Object) will now store its own baked data.
The data is currently stored in uncompressed readable format.

This introduces two new operators for baking to avoid confusion with
the previous light baking pipeline. These do nothing other than
creating empty caches that will be populated by EEVEE later on.

The DNA storage is made to be able to include multiple caches
in case of baked simulation over time but it isn't yet supported.

I prefer to keep the implementation simple for now as the long term
goals for this feature are uncertain.
There is still a type flag (LightProbeObjectCache.cache_type) that
will be used for versioning.

The naming convention of structs is a bit weird but that's all I
found in order to avoid interfering with the old scene light cache
that is still used by (old) EEVEE.

Related task #106449.

This is the first step for refactoring the lightcache system. Each probe instance (as in `Object`) will now store its own baked data. The data is currently stored in uncompressed readable format. This introduces two new operators for baking to avoid confusion with the previous light baking pipeline. These do nothing other than creating empty caches that will be populated by EEVEE later on. The DNA storage is made to be able to include multiple caches in case of baked simulation over time but it isn't yet supported. I prefer to keep the implementation simple for now as the long term goals for this feature are uncertain. There is still a type flag (`LightProbeObjectCache.cache_type`) that will be used for versioning. The naming convention of structs is a bit weird but that's all I found in order to avoid interfering with the old scene light cache that is still used by (old) EEVEE. Related task #106449.

Clément Foucault added 2 commits 2023-04-11 15:24:33 +02:00

65e087ef49 LightProbe: Add new object level irradiance cache

1946279b93 Merge branch 'main' into lightprobe-data

Clément Foucault added 2 commits 2023-04-12 17:59:19 +02:00

dc9dded5d7 Operator: Add subset option back

Add subset to limit baking to certain object sets.

291e36ea72 Rename and encapsulate for clarity and avoid cluttering `Object` type

Clément Foucault added this to the EEVEE & Viewport project 2023-04-12 17:59:44 +02:00

Clément Foucault requested review from Sergey Sharybin 2023-04-12 17:59:58 +02:00

Clément Foucault changed title from ~~WIP: DNA: Move irradiance grid light cache data to Object level~~ to DNA: Move irradiance grid light cache data to Object level

2023-04-12 18:00:04 +02:00

Clément Foucault added 1 commit 2023-04-12 19:21:37 +02:00

144abfd069 Fix reading and doubly written struct data

Sergey Sharybin requested review from Brecht Van Lommel 2023-04-13 09:55:17 +02:00

Clément Foucault commented

2023-04-13 10:58:02 +02:00

I would like to know how much of an issue it would be to commit this in main even during the 3.6 release cycle where this wouldn't be used (because no EEVEE-Next yet).

The new lightcache baking needs it. But I can just rebase this on top of the new lightcache implementation branch and waiting for it to be finished.

I would like to know how much of an issue it would be to commit this in `main` even during the 3.6 release cycle where this wouldn't be used (because no EEVEE-Next yet). The new lightcache baking needs it. But I can just rebase this on top of the new lightcache implementation branch and waiting for it to be finished.

Brecht Van Lommel approved these changes 2023-04-13 18:41:48 +02:00

Brecht Van Lommel left a comment

Implementation looks fine overall.

I don't see an issue having this code in 3.6 if it doesn't show up in the UI.

Implementation looks fine overall. I don't see an issue having this code in 3.6 if it doesn't show up in the UI.

source/blender/makesdna/DNA_lightprobe_types.h Outdated

						
				@ -204,0 +218,4 @@

				} LightProbeBakingData;

				/**

				 * Irradiance stored as RGB triple using scene referred color space.

Brecht Van Lommel commented

2023-04-13 15:21:37 +02:00

scene referred -> scene linear (scene referred is a category of color spaces, scene linear is the specific one)

fclem marked this conversation as resolved

Clément Foucault added 3 commits 2023-04-15 22:01:50 +02:00

1f47deb86c Add debug surfel array to LightProbeGridCacheFrame

ee5256c004 Fix comment about color-space

f58fae995f Change type of visibility storage

This is the uncompressed format and the data still need to be signed.

Clément Foucault added 1 commit 2023-04-15 22:02:38 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

35a3592d4b Merge branch 'main' into lightprobe-data

Clément Foucault commented

2023-04-15 22:03:01 +02:00

@blender-bot build

Sergey Sharybin approved these changes 2023-04-17 09:49:21 +02:00

Sergey Sharybin left a comment

The BLO_write_<foo>_array checks for the null pointer, so some explicit checks around it can be removed it seems.
I also think checks around BLO_read_<foo>_array can also be removed.

This is how other code uses those functions.

But this is not strictkly required for this PR.

The `BLO_write_<foo>_array` checks for the null pointer, so some explicit checks around it can be removed it seems. I also think checks around `BLO_read_<foo>_array` can also be removed. This is how other code uses those functions. But this is not strictkly required for this PR.

Clément Foucault added 2 commits 2023-04-17 13:39:27 +02:00

12f25885ac Avoid uneeded nullptr checks

e3e5f6efb4 Avoid issue when loading a blendfile with incompatible data layout

Clément Foucault added 1 commit 2023-04-17 14:00:47 +02:00

50df9ed534 Merge branch 'main' into lightprobe-data

Clément Foucault added 1 commit 2023-04-17 16:59:47 +02:00

f5072c573e Merge branch 'main' into lightprobe-data

Clément Foucault merged commit a8feb20e1c into main

2023-04-17 17:12:31 +02:00

Clément Foucault referenced this issue from a commit

2023-04-17 17:12:31 +02:00

DNA: Move irradiance grid light cache data to Object level