Fix #106853: Tooltip fix of Clear Constraints OT #106918

Manually merged
Sybren A. Stüvel merged 3 commits from Adi.Sage/blender:fix-106853 into main 2023-05-02 10:53:18 +02:00
Contributor

The existing tooltip of Clear Constraints modifier in object mode
(object.constraints_clear()) does not match it's functionality,
as it says it works only on the active object,
but in practice it affects all selected objects in viewport.

Hence, the tooltip has been changed from
'Clear all the constraints for the active object only' to
'Clear all the constraints for the selected objects'

Also, based on feedback by @zanqdo,
tooltip for Clear Pose Constraints in Pose Mode
was updated for better readability.

The existing tooltip of Clear Constraints modifier in object mode (object.constraints_clear()) does not match it's functionality, as it says it works only on the **active object**, but in practice it affects **all selected objects** in viewport. Hence, the tooltip has been changed from 'Clear all the constraints for the active object only' to 'Clear all the constraints for the selected objects' Also, based on feedback by @zanqdo, tooltip for Clear Pose Constraints in Pose Mode was updated for better readability.
Adi.Sage added 1 commit 2023-04-13 20:54:29 +02:00
0869cd4e07 Fix #106853: Tooltip fix of OT_constraints_clear
The existing tooltip of Clear Constraints modifier in object mode
(object.constraints_clear()) has been changed from
'Clear all the constraints for the active object only' to
'Clear all the constraints for the selected objects'
Adi.Sage changed title from WIP: Fix #106853: Tooltip fix of OT_constraints_clear to Fix #106853: Tooltip fix of OT_constraints_clear 2023-04-14 08:24:27 +02:00
Adi.Sage changed title from Fix #106853: Tooltip fix of OT_constraints_clear to WIP: Fix #106853: Tooltip fix of OT_constraints_clear 2023-04-14 08:24:55 +02:00
Iliya Katushenock added this to the Animation & Rigging project 2023-04-14 14:23:05 +02:00
Iliya Katushenock added the
Interest
User Interface
label 2023-04-14 14:23:13 +02:00
Adi.Sage changed title from WIP: Fix #106853: Tooltip fix of OT_constraints_clear to Fix #106853: Tooltip fix of OT_constraints_clear 2023-04-17 18:07:52 +02:00
Member

Small nitpick:

I think it works better (easier to read and understand) without all the extra all and the and also switching for to from:

"Clear all constraints from the selected objects"

Small nitpick: I think it works better (easier to read and understand) without all the extra _all_ and _the_ and also switching _for_ to _from_: "Clear all constraints from the selected objects"
Daniel Salazar requested review from Daniel Salazar 2023-04-22 03:54:25 +02:00
Author
Contributor

@zanqdo
Agreed! I like your version much better :)

But for consistency, I copied the wording from the Clear Pose Constraints tooltip.

image

@zanqdo Agreed! I like your version much better :) But for consistency, I copied the wording from the Clear Pose Constraints tooltip. ![image](/attachments/905bcc7f-130f-497a-aae3-1932cd984f49)
Author
Contributor

@zanqdo
Also, thanks for pointing out. The wording in the description and in the code is different (an extra 'all' in the end).
My bad!
I'll update and resubmit with whatever wording is approved.

@zanqdo Also, thanks for pointing out. The wording in the description and in the code is different (an extra 'all' in the end). My bad! I'll update and resubmit with whatever wording is approved.
Adi.Sage requested review from Sybren A. Stüvel 2023-04-22 12:51:08 +02:00
Member

@zanqdo
Agreed! I like your version much better :)

But for consistency, I copied the wording from the Clear Pose Constraints tooltip.

image

Yeah that's wrong too. I would prefer changing both!

> @zanqdo > Agreed! I like your version much better :) > > But for consistency, I copied the wording from the Clear Pose Constraints tooltip. > > ![image](/attachments/905bcc7f-130f-497a-aae3-1932cd984f49) Yeah that's wrong too. I would prefer changing both!
Adi.Sage added 2 commits 2023-04-23 07:37:36 +02:00
e630290d8b The existing tooltip of Clear Constraints operator
for objects and bones is updated in this patch
for better readability.
Author
Contributor

@zanqdo
Both tooltips updated as discussed.

@zanqdo Both tooltips updated as discussed.
Daniel Salazar approved these changes 2023-04-23 21:59:58 +02:00
Daniel Salazar left a comment
Member

LGTM

LGTM
Daniel Salazar added
Module
Animation & Rigging
and removed
Interest
User Interface
labels 2023-04-24 07:47:18 +02:00

Both tooltips updated as discussed.

Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.

> Both tooltips updated as discussed. Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.
Adi.Sage changed title from Fix #106853: Tooltip fix of OT_constraints_clear to Fix #106853: Tooltip fix of Clear Constraints OT 2023-05-01 20:07:38 +02:00
Author
Contributor

Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.

@dr.sybren
PR description updated 👍

> Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses. @dr.sybren PR description updated 👍
Sybren A. Stüvel approved these changes 2023-05-02 10:41:23 +02:00
Sybren A. Stüvel left a comment
Member

Thanks!

Thanks!
Sybren A. Stüvel manually merged commit cc84d83929 into main 2023-05-02 10:53:18 +02:00
Sybren A. Stüvel removed this from the Animation & Rigging project 2023-05-02 10:53:49 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:43 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106918
No description provided.