blender/blender

Fix #106853: Tooltip fix of Clear Constraints OT #106918

Manually merged

Sybren A. Stüvel merged 3 commits from Adi.Sage/blender:fix-106853 into main

2023-05-02 10:53:18 +02:00

Adi.Sage commented

2023-04-13 20:54:16 +02:00

Contributor

The existing tooltip of Clear Constraints modifier in object mode
(object.constraints_clear()) does not match it's functionality,
as it says it works only on the active object,
but in practice it affects all selected objects in viewport.

Hence, the tooltip has been changed from
'Clear all the constraints for the active object only' to
'Clear all the constraints for the selected objects'

Also, based on feedback by @zanqdo,
tooltip for Clear Pose Constraints in Pose Mode
was updated for better readability.

The existing tooltip of Clear Constraints modifier in object mode (object.constraints_clear()) does not match it's functionality, as it says it works only on the **active object**, but in practice it affects **all selected objects** in viewport. Hence, the tooltip has been changed from 'Clear all the constraints for the active object only' to 'Clear all the constraints for the selected objects' Also, based on feedback by @zanqdo, tooltip for Clear Pose Constraints in Pose Mode was updated for better readability.

Adi.Sage added 1 commit 2023-04-13 20:54:29 +02:00

Fix #106853 : Tooltip fix of OT_constraints_clear 0869cd4e07

The existing tooltip of Clear Constraints modifier in object mode
(object.constraints_clear()) has been changed from
'Clear all the constraints for the active object only' to
'Clear all the constraints for the selected objects'

Adi.Sage changed title from ~~WIP: Fix #106853: Tooltip fix of OT_constraints_clear~~ to Fix #106853: Tooltip fix of OT_constraints_clear

2023-04-14 08:24:27 +02:00

Adi.Sage changed title from ~~Fix #106853: Tooltip fix of OT_constraints_clear~~ to WIP: Fix #106853: Tooltip fix of OT_constraints_clear

2023-04-14 08:24:55 +02:00

Iliya Katushenock added this to the Animation & Rigging project 2023-04-14 14:23:05 +02:00

Iliya Katushenock added the

label 2023-04-14 14:23:13 +02:00

Adi.Sage changed title from ~~WIP: Fix #106853: Tooltip fix of OT_constraints_clear~~ to Fix #106853: Tooltip fix of OT_constraints_clear

2023-04-17 18:07:52 +02:00

Daniel Salazar commented

2023-04-22 01:19:54 +02:00

Member

Small nitpick:

I think it works better (easier to read and understand) without all the extra all and the and also switching for to from:

"Clear all constraints from the selected objects"

Small nitpick: I think it works better (easier to read and understand) without all the extra _all_ and _the_ and also switching _for_ to _from_: "Clear all constraints from the selected objects"

Daniel Salazar requested review from Daniel Salazar 2023-04-22 03:54:25 +02:00

Adi.Sage commented

2023-04-22 07:46:32 +02:00

Author

Contributor

@zanqdo
Agreed! I like your version much better :)

But for consistency, I copied the wording from the Clear Pose Constraints tooltip.

@zanqdo Agreed! I like your version much better :) But for consistency, I copied the wording from the Clear Pose Constraints tooltip. ![image](/attachments/905bcc7f-130f-497a-aae3-1932cd984f49)

40 KiB

Adi.Sage commented

2023-04-22 07:55:45 +02:00

Author

Contributor

@zanqdo
Also, thanks for pointing out. The wording in the description and in the code is different (an extra 'all' in the end).
My bad!
I'll update and resubmit with whatever wording is approved.

@zanqdo Also, thanks for pointing out. The wording in the description and in the code is different (an extra 'all' in the end). My bad! I'll update and resubmit with whatever wording is approved.

Adi.Sage requested review from Sybren A. Stüvel 2023-04-22 12:51:08 +02:00

Daniel Salazar commented

2023-04-23 00:40:08 +02:00

Member

@zanqdo
Agreed! I like your version much better :)

But for consistency, I copied the wording from the Clear Pose Constraints tooltip.

Yeah that's wrong too. I would prefer changing both!

> @zanqdo > Agreed! I like your version much better :) > > But for consistency, I copied the wording from the Clear Pose Constraints tooltip. > > ![image](/attachments/905bcc7f-130f-497a-aae3-1932cd984f49) Yeah that's wrong too. I would prefer changing both!

Adi.Sage added 2 commits 2023-04-23 07:37:36 +02:00

Merge branch 'main' into fix-106853 aa038d56ce

The existing tooltip of Clear Constraints operator e630290d8b

for objects and bones is updated in this patch
for better readability.

Adi.Sage commented

2023-04-23 07:44:33 +02:00

Author

Contributor

@zanqdo
Both tooltips updated as discussed.

@zanqdo Both tooltips updated as discussed.

Daniel Salazar approved these changes 2023-04-23 21:59:58 +02:00

Daniel Salazar left a comment

Member

LGTM

LGTM

Daniel Salazar added

Animation & Rigging

and removed

labels 2023-04-24 07:47:18 +02:00

Sybren A. Stüvel commented

2023-05-01 16:15:40 +02:00

Member

Both tooltips updated as discussed.

Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.

> Both tooltips updated as discussed. Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.

Adi.Sage changed title from ~~Fix #106853: Tooltip fix of OT_constraints_clear~~ to Fix #106853: Tooltip fix of Clear Constraints OT

2023-05-01 20:07:38 +02:00

Adi.Sage commented

2023-05-01 20:11:23 +02:00

Author

Contributor

Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses.

@dr.sybren
PR description updated 👍

> Please make sure that the PR description is kept in sync with the code changes. It only mentions one operator, and nothing about bones/poses. @dr.sybren PR description updated 👍

Sybren A. Stüvel approved these changes 2023-05-02 10:41:23 +02:00

Sybren A. Stüvel left a comment

Member

Thanks!

Thanks!

Sybren A. Stüvel referenced this issue from a commit

2023-05-02 10:53:10 +02:00

Fix #106853: Tooltip fix of OT_constraints_clear

Sybren A. Stüvel manually merged commit cc84d83929 into main

2023-05-02 10:53:18 +02:00

Sybren A. Stüvel removed this from the Animation & Rigging project 2023-05-02 10:53:49 +02:00

Howard Trickey referenced this issue from a commit

2023-05-29 02:51:43 +02:00

Merge in orign/main:

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Code Documentation

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106918

No description provided.