WIP: Subtype for input function nodes #107010

Weikang-Qiu · 2023-04-16T17:55:37+02:00

Weikang-Qiu commented

2023-04-16 17:55:37 +02:00

Problem

This patch is related to the issue #106505.

Solution

This is a rough patch where I only implement the subtype list for the function input vector node. Currently the subtype list includes all subtypes listed on https://docs.blender.org/api/current/bpy_types_enum_items/property_subtype_number_array_items.html#rna-enum-property-subtype-number-array-items. This is achieved by adding a subtype value in the node storage structure, and duplicating multiple properties associated with the same vector value.

demo-input-vector-subtype.mp4

Limitations

These properties will be all visible to python.
The subtypes have the same display name, for example, both COLOR and COLOR_GAMMA will display "Color". Also, some subtypes like AXISANGLE are 4d vector, but originally the node only supports 3d vector.

# Problem This patch is related to the issue [#106505](https://projects.blender.org/blender/blender/issues/106505). # Solution This is a rough patch where I only implement the subtype list for the function input vector node. Currently the subtype list includes all subtypes listed on https://docs.blender.org/api/current/bpy_types_enum_items/property_subtype_number_array_items.html#rna-enum-property-subtype-number-array-items. This is achieved by adding a `subtype` value in the node storage structure, and duplicating multiple properties associated with the same `vector` value. [demo-input-vector-subtype.mp4](/attachments/0f1f16ea-44ed-4eec-8c2c-7b7ad1af9204) # Limitations These properties will be all visible to python. The subtypes have the same display name, for example, both `COLOR` and `COLOR_GAMMA` will display "Color". Also, some subtypes like `AXISANGLE` are 4d vector, but originally the node only supports 3d vector.

demo-input-vector-subtype.mp4

319 KiB

🎉 4

Weikang-Qiu referenced this pull request

2023-04-16 18:07:12 +02:00

Subtype for input value nodes #106505

Iliya Katushenock added this to the Nodes & Physics project 2023-04-16 18:38:33 +02:00

Weikang-Qiu force-pushed node-subtype from 28c1aa3446 to 393269266d

2023-04-16 21:24:40 +02:00

Compare

Weikang-Qiu added 1 commit 2023-04-19 01:02:29 +02:00

8db7699703 Merge branch 'main' into node-subtype

Weikang-Qiu commented

2023-04-19 01:08:01 +02:00

Solution changed

Instead of duplicating multiple properties associated with the same data:
Add a callback function to ntype.updatefunc. Add some utilities functions in RNA_access.h (not sure if these functions should be there or somewhere else, but since it is just a demo, I just put them there for now).

# Solution changed Instead of duplicating multiple properties associated with the same data: Add a callback function to `ntype.updatefunc`. Add some utilities functions in `RNA_access.h` (not sure if these functions should be there or somewhere else, but since it is just a demo, I just put them there for now).

Weikang-Qiu force-pushed node-subtype from 4e0e0e0662 to 384d734534

2023-04-19 01:20:35 +02:00

Compare

Iliya Katushenock referenced this pull request

2023-04-19 20:01:28 +02:00

Geometry node Set Curve Tilt shows degrees but wants radians #107140

Iliya Katushenock reviewed 2023-04-19 20:17:04 +02:00

source/blender/makesrna/intern/rna_access.cc Outdated

						
				@ -5251,0 +5255,4 @@

				{

				  PointerRNA ptr;

				  RNA_pointer_create(id, &RNA_Node, data, &ptr);

Iliya Katushenock commented

2023-04-19 20:17:04 +02:00

This is not very practical, because in fact, it cannot be applied to the properties of an object, for example? Is it possible to make property references without statically specifying the structure type? It seems one of the node_layout arguments might be useful. That is, it seems that the update function should do this itself and pass in RNA_property_subtype_set prop as argument?

This is not very practical, because in fact, it cannot be applied to the properties of an object, for example? Is it possible to make property references without statically specifying the structure type? It seems one of the `node_layout` arguments might be useful. That is, it seems that the update function should do this itself and pass in `RNA_property_subtype_set` `prop` as argument?

👍 1

Weikang-Qiu added 1 commit 2023-04-22 00:52:00 +02:00

843668eef0 Refractor of function RNA_property_subtype_set

Weikang-Qiu commented

2023-04-22 00:54:50 +02:00

Update Summary

move the RNA_pointer_create(id, &RNA_Node, data, &ptr); out of the RNA_property_subtype_set to make it more general.
Add a rna_Node_update_individual function to only change the node (prevent from propagating).

# Update Summary 1. move the `RNA_pointer_create(id, &RNA_Node, data, &ptr);` out of the `RNA_property_subtype_set` to make it more general. 2. Add a `rna_Node_update_individual` function to only change the node (prevent from propagating).

This pull request has changes conflicting with the target branch.

source/blender/makesrna/RNA_access.h
source/blender/makesrna/intern/rna_nodetree.c
source/blender/nodes/function/CMakeLists.txt
source/blender/nodes/function/nodes/node_fn_input_vector.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u node-subtype:Weikang-Qiu-node-subtype

git checkout Weikang-Qiu-node-subtype

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Subtype for input function nodes #107010

Problem

Solution

Limitations

Solution changed

Update Summary

Checkout