Fix #106943: driver on inactive view layer doesn't work #107031

Sybren A. Stüvel · 2023-04-17T11:36:26+02:00

Sybren A. Stüvel commented

2023-04-17 11:36:26 +02:00

Animation data (including drivers) on inactive view layers now work.
The removal of such view layers was too optimistic; they are now kept
around. The bases are still removed, mostly for safety sake and to keep
the changes to a minimum.

scene_remove_unused_view_layers() has been renamed to
scene_minimize_unused_view_layers() to reflect its new functionality.

For compatibility with assumptions in other areas of the code, the function
still ensures the input view layer is at index 0.

Animation data (including drivers) on inactive view layers now work. The removal of such view layers was too optimistic; they are now kept around. The bases are still removed, mostly for safety sake and to keep the changes to a minimum. `scene_remove_unused_view_layers()` has been renamed to `scene_minimize_unused_view_layers()` to reflect its new functionality. For compatibility with assumptions in other areas of the code, the function still ensures the input view layer is at index 0.

Sybren A. Stüvel added the

Module

Animation & Rigging

label 2023-04-17 11:36:26 +02:00

Sybren A. Stüvel added 1 commit 2023-04-17 11:36:45 +02:00

94dde6866c Fix #106943 : driver on inactive view layer doesn't work

Animation data (including drivers) on inactive view layers now work.
The removal of such view layers was too optimistic; they are now kept
around. The bases are still removed, mostly for safety sake and to keep
the changes to a minimum.

`scene_remove_unused_view_layers()` has been renamed to
`scene_minimize_unused_view_layers()` to reflect its new functionality.

For compatibility with assumptions in other areas of the code, the function
still ensures the input view layer is at index 0.

Sybren A. Stüvel requested review from Sergey Sharybin 2023-04-17 11:37:16 +02:00

Sybren A. Stüvel added this to the Animation & Rigging project 2023-04-17 11:37:20 +02:00

Sergey Sharybin commented

2023-04-17 11:46:57 +02:00

I am confused by the implementation of the view_layer_unassign_bases. It seems it is only taking care of un-assigning the active base, but it leaves the actual base list intact.

I'd imagine for the proper removal of data which might point to the original data we need to run the first block of the BKE_view_layer_free_ex which includes baseact, object_bases, object_bases_hash, layer_collections.

I am confused by the implementation of the `view_layer_unassign_bases`. It seems it is only taking care of un-assigning the active base, but it leaves the actual base list intact. I'd imagine for the proper removal of data which might point to the original data we need to run the first block of the `BKE_view_layer_free_ex` which includes `baseact`, `object_bases`, `object_bases_hash`, `layer_collections`.

Sybren A. Stüvel commented

2023-04-17 12:17:18 +02:00

I am confused by the implementation of the view_layer_unassign_bases. It seems it is only taking care of un-assigning the active base, but it leaves the actual base list intact.

I'm also not too sure about that; I just moved the existing code that did that when rendering to a function of its own. Figured that if that were doing the right thing, I'd better do the same thing.

I'd imagine for the proper removal of data which might point to the original data we need to run the first block of the BKE_view_layer_free_ex which includes baseact, object_bases, object_bases_hash, layer_collections.

👍

> I am confused by the implementation of the `view_layer_unassign_bases`. It seems it is only taking care of un-assigning the active base, but it leaves the actual base list intact. I'm also not too sure about that; I just moved the existing code that did that when rendering to a function of its own. Figured that if that were doing the right thing, I'd better do the same thing. > I'd imagine for the proper removal of data which might point to the original data we need to run the first block of the `BKE_view_layer_free_ex` which includes `baseact`, `object_bases`, `object_bases_hash`, `layer_collections`. :+1:

Sergey Sharybin commented

2023-04-17 12:27:16 +02:00

I'm also not too sure about that; I just moved the existing code that did that when rendering to a function of its own. Figured that if that were doing the right thing, I'd better do the same thing.

That code was only done for the is_render_pipeline_depsgraph. It is kind of controlled environment, so just a pare minumum was done.

For the actual evaluated depsgraph the entire view unused layers were removed, to avoid code like external render engine accessing data which is not part of the dependency graph (via scene.view_layers['random_unused_layer'].objects ...).

I don't feel like using the short-cut of basact-only for the non-pipeline depsgraph is safe. And safe code hopefully is as easy as just splitting BKE_view_layer_free_object_content from the BKE_view_layer_free_ex and call it from the view_layer_unassign_bases().

> I'm also not too sure about that; I just moved the existing code that did that when rendering to a function of its own. Figured that if that were doing the right thing, I'd better do the same thing. That code was only done for the `is_render_pipeline_depsgraph`. It is kind of controlled environment, so just a pare minumum was done. For the actual evaluated depsgraph the entire view unused layers were removed, to avoid code like external render engine accessing data which is not part of the dependency graph (via `scene.view_layers['random_unused_layer'].objects ...`). I don't feel like using the short-cut of `basact`-only for the non-pipeline depsgraph is safe. And safe code hopefully is as easy as just splitting `BKE_view_layer_free_object_content` from the `BKE_view_layer_free_ex` and call it from the `view_layer_unassign_bases()`.

Sybren A. Stüvel added 2 commits 2023-04-17 12:51:21 +02:00

e5a5259371 Feedback from Sergey

7a30360289 Merge remote-tracking branch 'origin/main' into anim/106943-bg-view-layer-driver

Sybren A. Stüvel commented

2023-04-17 12:58:44 +02:00

Landing (f588a0596b) after an over-the-shoulder review + approval done by Sergey :)

Landing (f588a0596bd317972d5b15a0750d8e0dbf63bb06) after an over-the-shoulder review + approval done by Sergey :)

Sybren A. Stüvel manually merged commit f588a0596b into main

2023-04-17 13:02:55 +02:00

Sybren A. Stüvel deleted branch anim/106943-bg-view-layer-driver

2023-04-17 13:03:03 +02:00

Sybren A. Stüvel removed this from the Animation & Rigging project 2023-05-15 11:35:03 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #106943: driver on inactive view layer doesn't work #107031