BKE: Rework ID swap code to properly handle embedded ID pointers. #107044

Bastien Montagne · 2023-04-17T17:28:02+02:00

Bastien Montagne commented

2023-04-17 17:28:02 +02:00

While embedded IDs are usually considered as private local data of their
owner ID, some areas of code, like the depsgraph, can consider them as
regular IDs in some aspects.

So when swapping IDs, also properly 'counter-swap' their potential
embedded IDs, such that the pointers to the embedded IDs remain as before
swapping, even though the data of the embedded IDs is swapped.

The main target of this change is memfile undo code. There, newly read
IDs are swapped with their older version, so that the old address
contains the new data. This allows to avoid rebuilding some of the
depsgraph. Doing the same thing for embedded IDs should reduce even
further the needs for depsgrah rebuilds on undo steps.

This commit also gives more control over the remapping of 'self' ID
pointers inside themselves.

While embedded IDs are usually considered as private local data of their owner ID, some areas of code, like the depsgraph, can consider them as regular IDs in some aspects. So when swapping IDs, also properly 'counter-swap' their potential embedded IDs, such that the pointers to the embedded IDs remain as before swapping, even though the data of the embedded IDs is swapped. The main target of this change is memfile undo code. There, newly read IDs are swapped with their older version, so that the old address contains the new data. This allows to avoid rebuilding some of the depsgraph. Doing the same thing for embedded IDs should reduce even further the needs for depsgrah rebuilds on undo steps. This commit also gives more control over the remapping of 'self' ID pointers inside themselves.

Bastien Montagne added this to the Core project 2023-04-17 17:29:46 +02:00

Bastien Montagne requested review from Brecht Van Lommel 2023-04-17 17:29:54 +02:00

Brecht Van Lommel approved these changes 2023-04-17 19:01:56 +02:00

Bastien Montagne force-pushed F-swap-embedded-id from 74e63f7861 to 2a042b4133

2023-04-18 11:05:49 +02:00

Compare

Bastien Montagne force-pushed F-swap-embedded-id from 2a042b4133 to e615947d6a

2023-04-18 11:09:25 +02:00

Compare

Bastien Montagne merged commit 6e75581e65 into main

2023-04-18 11:09:46 +02:00

Bastien Montagne referenced this issue from a commit

2023-04-18 11:09:47 +02:00

BKE: Rework ID swap code to properly handle embedded ID pointers.

Bastien Montagne deleted branch F-swap-embedded-id

2023-04-18 11:09:47 +02:00

Bastien Montagne removed this from the Core project 2023-07-03 12:46:46 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

BKE: Rework ID swap code to properly handle embedded ID pointers. #107044