Overlay-Next: Initial implementation #107045

Clément Foucault · 2023-04-17T17:38:35+02:00

Clément Foucault commented

2023-04-17 17:38:35 +02:00

This contains the basis of the new overlay engine.
Only a few overlays are ported for proof of concept of the new design.

This new design unify the selection drawing with the overlay-next engine.
It now becomes responsible of selection in object mode.

For this we create a dedicated shader module that patches the shaders
for selection. The overlay engine codeflow should be fairly the same
as for both selection and regular drawing.

Note that the gizmo selection still uses the occlusion queries and edit-mode
the current selection engine (select_engine.c). These are out of the scope
of this refactor.

Another major difference in design with the current (old) overlay engine is
the entity type structure (Object, Empties, MetaBall etc...) instead of
drawing type centric (Extras, ). This is to increase code readablility and
locality. Each

The GPUBatches for each overlay are put inside a per instance batch
cache. This is redundant but avoid concurent usage and relying on a
global state. This is a few KB of data at most and will not produce
any significant slowdown on startup.

Related task #102179
Related task #102177

This contains the basis of the new overlay engine. Only a few overlays are ported for proof of concept of the new design. This new design unify the selection drawing with the overlay-next engine. It now becomes responsible of selection in object mode. For this we create a dedicated shader module that patches the shaders for selection. The overlay engine codeflow should be fairly the same as for both selection and regular drawing. Note that the gizmo selection still uses the occlusion queries and edit-mode the current selection engine (`select_engine.c`). These are out of the scope of this refactor. Another major difference in design with the current (old) overlay engine is the entity type structure (Object, Empties, MetaBall etc...) instead of drawing type centric (Extras, ). This is to increase code readablility and locality. Each The `GPUBatch`es for each overlay are put inside a per instance batch cache. This is redundant but avoid concurent usage and relying on a global state. This is a few KB of data at most and will not produce any significant slowdown on startup. Related task #102179 Related task #102177

Clément Foucault added 28 commits 2023-04-17 17:38:47 +02:00

2538c3b1a2 Cleanup: DRW: Improve state_stencil documentation

279774ad0b Overlay-Next: First commit

82e298227f Cleanup: EEVEE-Next: Add precision to comment

482fee9bbe DRW: View: Expose matrices through interface

cd93f790c7 Overlay: Add experimental option to enable overlay-next

f0514484f5 DRW: Wrappers: Add TextureRef to wrap around GPUTexture pointers

This adds the possibility to use the C++ API for other GPUTexture.

64d9660fc4 Overlay-Next: Make Grid parameters work

e116c67c3a DRW: Fix gl error related to incorrect uniform size

c3157ddc44 Merge branch 'master' into overlay-next

c4ecfce6bb Overlay-Next: Port Background overlay

2abc4d0538 Overlay-Next: Port Metaball overlay

968f5748c6 Merge branch 'main' into overlay-next

# Conflicts:
#	release/scripts/startup/bl_ui/space_userpref.py
#	source/blender/makesdna/DNA_userdef_types.h
#	source/blender/makesrna/intern/rna_userdef.c

aff61bf5b4 Merge branch 'main' into overlay-next

cdb9b6a041 Overlay-Next: Add support for empties

Also added a shape cache and move the color selection to `Resources`.

ef0126f3a7 Merge branch 'main' into overlay-next

# Conflicts:
#	source/blender/makesdna/DNA_userdef_types.h

84ff44769f Overlay-Next: Add high level separation of selection code

This makes it possible to reuse the overlay engine code for selection
purpose, but without any overhead for the viewport drawing.

The separation is made clear by having a dummy selection implementation for
viewport drawing and an object implementation for object selection.
Other impementation might come later (like for depth picking).

68a0f9e01c Overlay-Next: Port Metaball code to use latest design and support selectid

78ae27bab3 Overlay-Next: Add depth Prepass basics

The depth prepass is supposed to replace the Basic engine:
- Draw object depth when the engine doesn't give correct depth buffer
- Used for object selection

16cc2446f5 Overlay-Next: Add shader module

This allows cleaner declarations of shaders as well as allowing easier
swapping of the whole shader module for selection & clipping.

This also allow to easier toggle between the old overlay engine and
overlay-next as they don't share the same shaders anymore.

ea66898bbe Select-Next: Introduce shader level patching to output selection ids

This leverage imageLoad/Store operations to remove the use of cumbersome
visibility queries.

Patching shaders should only require 4 lines of code (2 for includes, 2 for
the id passthrough).

953cef7b7a Merge branch 'main' into overlay-next

34afb6c05f Select-Next: Fix IDs for meshes and metaballs handles

a9397b5458 Select-Next: Reorganize and rename stuffs

3ac54f67bf Select-Next: Add result buffer injection

This allow compatibility with the old system.

7676b627c2 Merge branch 'main' into overlay-next

# Conflicts:
#	source/blender/draw/engines/select/select_engine.c
#	source/blender/draw/engines/select/shaders/infos/select_id_info.hh

f25b2156df Fix crash when using old overlay engine before enabling overlay-next

d9fd739732 Fix assert in gpu debug mode

ba29927190 Fix buggy selection

Clément Foucault requested review from Jeroen Bakker 2023-04-17 17:53:55 +02:00

Clément Foucault requested review from Miguel Pozo 2023-04-17 17:53:55 +02:00

Clément Foucault added the

Module

EEVEE & Viewport

label 2023-04-17 17:54:04 +02:00

Clément Foucault added this to the 4.0 milestone 2023-04-17 17:54:08 +02:00

Clément Foucault added this to the EEVEE & Viewport project 2023-04-17 17:54:14 +02:00

Jeroen Bakker commented

2023-04-18 15:56:17 +02:00

I did a quick scan. Seems like it uses templates to switch out resources/shaders so the different overlays don't need to many changes. Think it is a good idea. Still need to look at the selection shaders how that is setup.

Miguel Pozo referenced this pull request

2023-05-08 12:47:41 +02:00

Overlay Next: Refactor #107734

Brecht Van Lommel commented

2023-06-14 13:05:45 +02:00

I guess this was replaced by #107734, and can be closed now?

Brecht Van Lommel closed this pull request

2023-06-14 13:08:12 +02:00