RNA: ignore some large arrays in override code #107196

Jacques Lucke · 2023-04-20T22:05:52+02:00

Jacques Lucke commented

2023-04-20 22:05:52 +02:00

This speeds up saving 070_0100.anim.blend from the Heist project from ~3s to ~300ms by adding PROPOVERRIDE_IGNORE in a few places. It's not completely obvious to me when PROPOVERRIDE_IGNORE should be used and when it shouldn't. Given that the same is done for meshes already, it seems correct.

I found this while investigating the performance difference between saving a MemFile on disk vs. storing the full file. Did this for #106903.

This speeds up saving `070_0100.anim.blend` from the Heist project from ~3s to ~300ms by adding `PROPOVERRIDE_IGNORE` in a few places. It's not completely obvious to me when `PROPOVERRIDE_IGNORE` should be used and when it shouldn't. Given that the same is done for meshes already, it seems correct. I found this while investigating the performance difference between saving a `MemFile` on disk vs. storing the full file. Did this for #106903.

Jacques Lucke added 1 commit 2023-04-20 22:06:01 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

bec4a1fed6 add PROPOVERRIDE_IGNORE for a couple of arrays

Jacques Lucke requested review from Bastien Montagne 2023-04-20 22:06:38 +02:00

Jacques Lucke requested review from Hans Goudey 2023-04-20 22:06:38 +02:00

Jacques Lucke commented

2023-04-20 22:06:50 +02:00

@blender-bot build

Hans Goudey approved these changes 2023-04-20 22:11:09 +02:00

Hans Goudey left a comment

Maybe worth adding this to rna_def_edge_creases, rna_def_vertex_creases, rna_def_skin_vertices, rna_def_mproperties, rna_def_MPropCol, rna_def_mloopcol, rna_def_mloopuv, rna_def_mvert?

Maybe worth adding this to `rna_def_edge_creases`, `rna_def_vertex_creases`, `rna_def_skin_vertices`, `rna_def_mproperties`, `rna_def_MPropCol`, `rna_def_mloopcol`, `rna_def_mloopuv`, `rna_def_mvert`?

Hans Goudey added this to the Core project 2023-04-20 22:11:26 +02:00

Jacques Lucke added 1 commit 2023-04-20 22:21:16 +02:00

5d09d8c33d add flag in a few more places for meshes

Jacques Lucke added 2 commits 2023-04-20 22:30:02 +02:00

5d40ac859b Merge branch 'main' into override-ignore-large-arrays

buildbot/vexp-code-patch-coordinator Build done. Details

10a60bcab2 Merge branch 'main' into override-ignore-large-arrays

Jacques Lucke commented

2023-04-20 22:30:16 +02:00

@blender-bot build

~~Jacques Lucke referenced this pull request 2023-04-21 00:07:01 +02:00~~

Undo: support implicit-sharing in memfile undo step #106903

Bastien Montagne approved these changes 2023-04-21 09:55:22 +02:00

Bastien Montagne commented

2023-04-21 09:56:51 +02:00

I think all geometry attributes can be ignored yes, for meshes we do not even save geometry at all in liboverrides anyway (to save disk space). We may want to do it for other geometries too if/when they get heavy (PointCloud e.g. could be a good candidate, maybe curves when used as hair?).

Jacques Lucke referenced this issue from a commit

2023-04-21 10:16:08 +02:00

RNA: ignore some large arrays in override code

Bastien Montagne closed this pull request

2023-04-21 10:42:49 +02:00

Colin Basnett referenced this issue from a commit

2023-05-02 02:35:26 +02:00

RNA: ignore some large arrays in override code

Bastien Montagne removed this from the Core project 2023-07-03 12:46:37 +02:00

buildbot/vexp-code-patch-coordinator Build done.

Details