VSE: Smooth transition for retiming tool #107197

Richard Antalik · 2023-04-20T22:05:52+02:00

Richard Antalik commented

2023-04-20 22:05:52 +02:00

This feature implements smooth transition between 2 retimed segments.

A transition can be added by dragging retiming handle while holding
shift key. When any handle defining transition is removed, the
transition segment is removed and 2 linear segments are restored to
state before transition was created.

These transitions work with video and sound and changes are reflected
in waveforms with correct seeking, therefore it replaces usage of
speed_factor or earlier sound pitch property.

Smooth transition is achieved by evaluating Y value of circular arc,
that is tangent to lines of linear retimed segments. Because of this,
when transition length is changed both handles are moved symetrically.
This way it is possible to make transition without affecting content in
linear segments.
When linear segment after transition is further retimed, this shifts
content inside of a transition segment.

To support sound, SEQ_retiming_sound_animation_data_set and related
data structures has been updated to build speed table for each segment.
Layering of retiming data via meta strips is still fully supported.

This feature implements smooth transition between 2 retimed segments. A transition can be added by dragging retiming handle while holding shift key. When any handle defining transition is removed, the transition segment is removed and 2 linear segments are restored to state before transition was created. These transitions work with video and sound and changes are reflected in waveforms with correct seeking, therefore it replaces usage of `speed_factor` or earlier sound `pitch` property. Smooth transition is achieved by evaluating Y value of circular arc, that is tangent to lines of linear retimed segments. Because of this, when transition length is changed both handles are moved symetrically. This way it is possible to make transition without affecting content in linear segments. When linear segment after transition is further retimed, this shifts content inside of a transition segment. To support sound, `SEQ_retiming_sound_animation_data_set` and related data structures has been updated to build speed table for each segment. Layering of retiming data via meta strips is still fully supported.

Richard Antalik added 1 commit 2023-04-20 22:06:03 +02:00

7ff87edc3d WIP: VSE: Gradual retiming

This feature allows to smooth transition between 2 retimed segments.

Smooth transition is achieved by evaluating Y value of arc that is
tangent to lines of linear retimed segments. Because of this, when
transition length is changed both handles are moved symetrically. This
way it is possible to make transition without affecting content in
linear segments.

TODO:
 - Modal move operation results in precision issues. Not sure why, but I assume, that this is result of new `SEQ_retiming_remove_handle()` and workflow "delete gradient, and create new one".
 - It's probably best to make `SEQ_retiming_remove_handle()` work with gradients based on geometry. Workflow mentioned above also invalidates all pointers which makes code ugly.
 - Make visual feedback, that gradient will be added on shift key.
 - Fix label to show gradient.
 - Bunch of limits are probably missing everywhere.
 - Merge with sound support.

Richard Antalik added 1 commit 2023-04-24 02:07:51 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

b95f70702f Mostly some polishing and preventing undefined behavior.

Richard Antalik commented

2023-04-24 02:24:34 +02:00

@blender-bot package

Blender Bot commented

2023-04-24 02:24:36 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107197) when ready.

Richard Antalik added 1 commit 2023-04-24 16:32:49 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

00d18f6f0f Fix incorrect type

Richard Antalik commented

2023-04-24 16:32:57 +02:00

@blender-bot package

Blender Bot commented

2023-04-24 16:32:59 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR107197) when ready.

Richard Antalik added 1 commit 2023-04-24 17:09:52 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

b08e99fb35 fix build error

Richard Antalik added 2 commits 2023-05-02 14:21:49 +02:00

739aae3470 Merge branch 'main' into retiming-gradual

ee11e688bd Implement sound retiming transition.

Unfortunately, as I thought, my arc style transition and simple linear interpolation between 2 speeds results in sound playback being very out of sync.
Will try to calculate speed based on values provided by `seq_retiming_evaluate`. This is horribly unelegant, but will try to make this feature complete before trying to optimize.
Also have to test synchronization to audio, but ut works with retiming already somehow without touching it, so I think that is OK.

Richard Antalik added 3 commits 2023-05-15 20:59:26 +02:00

ff060313cc Make sound speed evaluation slightly better. Now I think it should work in theory, but in practice it still doesn't.

df2dfe32b2 Fix technicalityy

80f7ca7181 Fix AV sync issue caused by using incorrect function.

Richard Antalik added 1 commit 2023-05-16 12:53:42 +02:00

5aef799ef8 Bunch of fixes

Richard Antalik added 4 commits 2023-05-16 14:59:22 +02:00

734a4928a0 Assign name to flag

421b23396f Fix naming - gradient -> transition

bce05127f4 Fix labels, handle illegal actions(can't add handle to transition segment)

64d5479924 Another set of fixes and improvements

Richard Antalik added 1 commit 2023-05-16 15:00:27 +02:00