blender
/
blender
130
398
Fork 573
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Fix #107186: Curve assets don't generate preview images #107214

Merged
Philipp Oeser merged 3 commits from lichtwerk/blender:107186 into main 2023-04-25 11:25:27 +02:00
Conversation 4 Commits 3 Files Changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/makesdna/DNA_object_types.h
View File

@ -532,7 +532,8 @@ typedef enum ObjectType {
#define OB_TYPE_SUPPORT_MATERIAL(_type) \
(((_type) >= OB_MESH && (_type) <= OB_MBALL) || \
((_type) >= OB_GPENCIL_LEGACY && (_type) <= OB_VOLUME))
/** Does the object have some render-able geometry (unlike empties, cameras, etc.). */
/** Does the object have some render-able geometry (unlike empties, cameras, etc.). True for
* #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */
Julian Eisel commented 2023-04-24 15:13:00 +02:00
Outdated
Review
Copy Link

Ouups, "evaluates [...] evaluate [...]" not nice English :)

Ouups, "evaluates [...] evaluate [...]" not nice English :)
#define OB_TYPE_IS_GEOMETRY(_type) \
(ELEM(_type, \
OB_MESH, \
@ -540,6 +541,7 @@ typedef enum ObjectType {
OB_FONT, \
OB_MBALL, \
OB_GPENCIL_LEGACY, \
Julian Eisel commented 2023-04-24 13:07:23 +02:00
Outdated
Review
Copy Link

I think this needs a comment explaining why this is considered to be "geometry", since it wouldn't appear so.

I'd just update the macro description like this:

/** Does the object have some render-able geometry (unlike empties, cameras, etc.). Evaluates to true for #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */
I think this needs a comment explaining why this is considered to be "geometry", since it wouldn't appear so. I'd just update the macro description like this: ``` /** Does the object have some render-able geometry (unlike empties, cameras, etc.). Evaluates to true for #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */ ```
Philipp Oeser commented 2023-04-24 13:18:52 +02:00
Outdated
Review
Copy Link

done

done
OB_CURVES_LEGACY, \
OB_CURVES, \
OB_POINTCLOUD, \
OB_VOLUME))