Fix #107186: Curve assets don't generate preview images #107214

Merged
Philipp Oeser merged 3 commits from lichtwerk/blender:107186 into main 2023-04-25 11:25:27 +02:00
Member

e7bea3fb6e disabled this.

I do believe excluding OB_CURVES_LEGACY is wrong though. While it
might not have real geometry, it certainly can have real geometry,
so now legacy curves are enabled again in OB_TYPE_IS_GEOMETRY.

A more elaborate check for real geo on legacy curves could be set up in
a following commit.

Since OB_TYPE_IS_GEOMETRY is also used in depsgraph driver handling,
will seek additional review from more devs.

e7bea3fb6ed0 disabled this. I do believe excluding `OB_CURVES_LEGACY` is wrong though. While it _might_ not have real geometry, it certainly _can_ have real geometry, so now legacy curves are enabled again in `OB_TYPE_IS_GEOMETRY`. A more elaborate check for real geo on legacy curves could be set up in a following commit. Since `OB_TYPE_IS_GEOMETRY` is also used in depsgraph driver handling, will seek additional review from more devs.
Philipp Oeser added 1 commit 2023-04-21 10:36:36 +02:00
fd0d4987c9 Fix #107186: Curve assets don't generate preview images
e7bea3fb6e disabled this.

I do believe excluding `OB_CURVES_LEGACY` is wrong though. While it
_might_ not have real geometry, it certainly _can_ have real geometry,
so now legacy curves are enabled again in `OB_TYPE_IS_GEOMETRY`.

A more elaborate check for real geo on legacy curves could be set up in
a following commit.

Since `OB_TYPE_IS_GEOMETRY` is also used in depsgraph driver handling,
will seek additional review from more devs.
Philipp Oeser requested review from Julian Eisel 2023-04-21 10:36:44 +02:00
Philipp Oeser requested review from Sybren A. Stüvel 2023-04-21 10:36:52 +02:00
Philipp Oeser requested review from Sergey Sharybin 2023-04-21 10:37:01 +02:00
Philipp Oeser added this to the Pipeline, Assets & IO project 2023-04-21 10:37:08 +02:00
Sergey Sharybin approved these changes 2023-04-21 10:43:22 +02:00
Sergey Sharybin left a comment
Owner

The dependency graph aspect seems correct to me.
The legacy curves do have shape keys, so the same work-around as meshes might be needed for the drivers.

The assets sounds logical as well, but it is not really my area.

The dependency graph aspect seems correct to me. The legacy curves do have shape keys, so the same work-around as meshes might be needed for the drivers. The assets sounds logical as well, but it is not really my area.
Member

For evaluated data the legacy curve type is rendered as wires, just an overlay, so maybe not real geometry like a camera. But I think this check is probably used for original objects, and legacy curve objects can evaluate to any geometry type, and often do. So they're often renderable.

For evaluated data the legacy curve type is rendered as wires, just an overlay, so maybe not real geometry like a camera. But I think this check is probably used for original objects, and legacy curve objects can evaluate to any geometry type, and often do. So they're often renderable.
First-time contributor

i found another issue, maybe related?
#107271 (comment)

i found another issue, maybe related? https://projects.blender.org/blender/blender/issues/107271#issue
Julian Eisel requested changes 2023-04-24 13:09:11 +02:00
Julian Eisel left a comment
Member

I guess this makes sense to do, it's just not a clear cut case. Would just clarify that in a comment (noted inline).

I guess this makes sense to do, it's just not a clear cut case. Would just clarify that in a comment (noted inline).
@ -540,6 +540,7 @@ typedef enum ObjectType {
OB_FONT, \
OB_MBALL, \
OB_GPENCIL_LEGACY, \
OB_CURVES_LEGACY, \
Member

I think this needs a comment explaining why this is considered to be "geometry", since it wouldn't appear so.

I'd just update the macro description like this:

/** Does the object have some render-able geometry (unlike empties, cameras, etc.). Evaluates to true for #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */
I think this needs a comment explaining why this is considered to be "geometry", since it wouldn't appear so. I'd just update the macro description like this: ``` /** Does the object have some render-able geometry (unlike empties, cameras, etc.). Evaluates to true for #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */ ```
Author
Member

done

done
Member

i found another issue, maybe related?
#107271 (comment)

Doesn't look like it to me.

> i found another issue, maybe related? > https://projects.blender.org/blender/blender/issues/107271#issue Doesn't look like it to me.
Author
Member

i found another issue, maybe related?
#107271 (comment)

Doesn't look like it to me.

Yep, that one has its own report, see #107212

> > i found another issue, maybe related? > > https://projects.blender.org/blender/blender/issues/107271#issue > > Doesn't look like it to me. Yep, that one has its own report, see #107212
Philipp Oeser added 1 commit 2023-04-24 13:18:27 +02:00
Julian Eisel approved these changes 2023-04-24 15:13:03 +02:00
@ -534,2 +534,3 @@
((_type) >= OB_GPENCIL_LEGACY && (_type) <= OB_VOLUME))
/** Does the object have some render-able geometry (unlike empties, cameras, etc.). */
/** Does the object have some render-able geometry (unlike empties, cameras, etc.). Evaluates to
* true for #OB_CURVES_LEGACY, since these often evaluate to objects with geometry. */
Member

Ouups, "evaluates [...] evaluate [...]" not nice English :)

Ouups, "evaluates [...] evaluate [...]" not nice English :)
Philipp Oeser added 1 commit 2023-04-25 10:35:58 +02:00
Philipp Oeser merged commit eda88466ee into main 2023-04-25 11:25:27 +02:00
Philipp Oeser deleted branch 107186 2023-04-25 11:25:28 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:44 +02:00
Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:01:16 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107214
No description provided.