Add Preserve Face Sets Shape option to smooth brush #107471

Closed
Toby Yang wants to merge 1 commits from tianer2820-2/blender:main into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
First-time contributor

I'm resubmitting the code review from here: https://archive.blender.org/developer/D9292

Note: I'm NOT the author of the original diff, I only copied the diff file from the original post and ported it to the latest main branch.

I'm aware that an option called "face set boundary" has been added, but they are not the same. The "Face set boundary" option pins the boundary in place and disallows any smoothing, while this feature is more like a "smooth face set + smooth geometry" brush. There is an intuitive video in the original post.

I'm resubmitting the code review from here: https://archive.blender.org/developer/D9292 Note: I'm NOT the author of the original diff, I only copied the diff file from the original post and ported it to the latest main branch. I'm aware that an option called "face set boundary" has been added, but they are not the same. The "Face set boundary" option pins the boundary in place and disallows any smoothing, while this feature is more like a "smooth face set + smooth geometry" brush. There is an intuitive video in the original post.
Toby Yang added 1 commit 2023-04-29 20:49:15 +02:00
Toby Yang changed title from WIP: add Preserve Face Sets Shape option to smooth brush to Add Preserve Face Sets Shape option to smooth brush 2023-04-29 20:50:40 +02:00
Iliya Katushenock added this to the Sculpt, Paint & Texture project 2023-04-29 20:52:42 +02:00
Julien Kaspar added the
Module
Sculpt, Paint & Texture
label 2023-05-01 10:42:10 +02:00
Julien Kaspar requested review from Joseph Eagar 2023-05-01 11:15:01 +02:00
Julien Kaspar requested review from Julien Kaspar 2023-05-01 11:15:01 +02:00
Member

Thanks for the PR! I'll look into this soon.

Thanks for the PR! I'll look into this soon.
Member

@JosephEagar This seems to be close to your proposed "Hard Surface Mode", only that the edges are not as firmly locked.
What do you think?

In general I would like to have this functionality in sculpt mode.

@JosephEagar This seems to be close to your proposed "Hard Surface Mode", only that the edges are not as firmly locked. What do you think? In general I would like to have this functionality in sculpt mode.
Member

This is done in a more general way in the dyntopo refactor PR

This is done in a more general way in the dyntopo refactor PR
Member

@JosephEagar We should better compare the effect of this implementation to the one in the dyntopo refactor.

From a bit of testing both, I so far prefer this one.
The boundaries and junction between face sets are much better preserved. It retains more of the original curvature and allows to smooth the shapes further a bit..

Meanwhile in the dyntopo refactor the "Hard Edge Mode" completely locks the junctions in place, while straightening the boundaries between junctions.
It's much too agressive and rigid.

@JosephEagar We should better compare the effect of this implementation to the one in the dyntopo refactor. From a bit of testing both, I so far prefer this one. The boundaries and junction between face sets are much better preserved. It retains more of the original curvature and allows to smooth the shapes further a bit.. Meanwhile in the dyntopo refactor the "Hard Edge Mode" completely locks the junctions in place, while straightening the boundaries between junctions. It's much too agressive and rigid.
Member

Corner pinning is kind of important though. I suppose we can add an option for it.

Corner pinning is kind of important though. I suppose we can add an option for it.
Member

@JosephEagar Is that all that Hard Edge Mode is supposed to be? Face Set corner pinning?

@JosephEagar Is that all that Hard Edge Mode is supposed to be? Face Set corner pinning?
Member

This is done in a more general way in the dyntopo refactor PR

Due to this I'll close the PR. But thanks for contributing! This helped steer the #104613 further in the right direction.

> This is done in a more general way in the dyntopo refactor PR Due to this I'll close the PR. But thanks for contributing! This helped steer the #104613 further in the right direction.
Julien Kaspar closed this pull request 2023-05-20 16:42:11 +02:00
Julien Kaspar removed this from the Sculpt, Paint & Texture project 2023-05-20 16:42:37 +02:00

Pull request closed

Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107471
No description provided.