Cleanup: Move draw_manager_profiling to C++ #107508

Hong-Shin · 2023-05-01T18:55:22+02:00

Hong-Shin commented

2023-05-01 18:55:22 +02:00

See: #103343

Hong-Shin added 1 commit 2023-05-01 18:55:29 +02:00

b72fb6f595 Cleanup: cppify draw_manager and draw_manager_profiling

Hong-Shin requested review from Hans Goudey 2023-05-01 18:55:38 +02:00

Iliya Katushenock commented

2023-05-01 19:01:11 +02:00

I not sure if this is still wip, so:
void DRW_stats_group_end(void);, NULL, ... other things also need to be changed?

I not sure if this is still wip, so: `void DRW_stats_group_end(void);`, `NULL`, ... other things also need to be changed?

👍 1

Hans Goudey requested changes 2023-05-01 19:03:59 +02:00

Hans Goudey left a comment

Thanks for putting the C++ conversion in a separate commit. Ideally the PR/commit message would reference #103343 (also to check that everything from there has been dealt with). Looks like the change is missing clang format.

source/blender/draw/intern/draw_manager_profiling.hh Outdated

						
				@ -0,0 +28,4 @@

				void DRW_stats_query_start(const char *name);

				void DRW_stats_query_end(void);

				struct rcti;

Hans Goudey commented

2023-05-01 19:02:56 +02:00

It's not clear that this forward declaration needs to move.

Hong-Shin commented

2023-05-01 19:10:44 +02:00

rcti is used below, so I moved it to be closer to where its used. No worries though - we can keep this delta minimal and revert this

`rcti` is used below, so I moved it to be closer to where its used. No worries though - we can keep this delta minimal and revert this

Hans Goudey commented

2023-05-01 22:29:26 +02:00

Usually all the forward includes are kept at the top of a file. Not sure if that's just Blender's convention or if it's in the style guide though.

Hong-Shin added 1 commit 2023-05-01 19:05:45 +02:00

e720edec09 nullptr

Hong-Shin added 2 commits 2023-05-01 19:11:07 +02:00

1116723c12 make format

buildbot/vexp-code-patch-coordinator Build done. Details

77762f78dd revert rtci

Hans Goudey commented

2023-05-01 22:29:34 +02:00

@blender-bot build

Hans Goudey requested changes 2023-05-02 14:26:44 +02:00

Hans Goudey left a comment

The test failures on the builds are unrelated, but I see an error in the Windows build:
C:\Users\blender\git\blender-vexp\blender.git\source\blender\draw\intern\draw_manager_profiling.cc(220): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax

The test failures on the builds are unrelated, but I see an error in the Windows build: `C:\Users\blender\git\blender-vexp\blender.git\source\blender\draw\intern\draw_manager_profiling.cc(220): error C4576: a parenthesized type followed by an initializer list is a non-standard explicit type conversion syntax`

Hong-Shin added 1 commit 2023-05-02 18:12:43 +02:00

8ae36c603c uniform init

Hong-Shin commented

2023-05-02 18:13:10 +02:00

Thanks for the heads up! Fixed.

Hong-Shin added 1 commit 2023-05-02 18:14:16 +02:00