Fix #107212: imb_is_a_ Failures Detecting Valid Images #107661
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#107661
Loading…
Reference in New Issue
No description provided.
Delete Branch "Harley:Imb_is_a"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Changes to some imb_is_a functions to not use imb_oiio_check
which is failing on many images.
For quick detection of valid image files we read just 64 bytes of the file and then check the header for magic numbers, using functions provided by each format's library. However since the change to using OpenImageIO for all image formats we have been calling
imb_oiio_check
which tries to read the file withget_oiio_reader
but this fails on many files. I'm guessing that this oiio function is just not meant for this purpose.In my test suite of 542 PNG images, the current
imb_is_a_png
fails on 177 of them. This PR just replaces some imb_is_a tests with direct tests of the file's signature. In the case of PNG just the first 8 bytes that are recognized as the testable signature. https://en.wikipedia.org/wiki/List_of_file_signaturesWith this PR all 542 of my test PNG are seen as valid, make thumbnails, and load fine.
IMB: Is_A Failures Detecting Valid Imagesto Fix #107212: imb_is_a_ Failures Detecting Valid ImagesAlready had a PR out #107515. It's slightly different, can you test that one actually?
@deadpin - yes, sorry didn't notice that one. Will look at right now.
Closing in favor of #107515
Pull request closed