blender
/
blender
74
260
Fork 350
Code Issues 5.9k Pull Requests 546 Projects 19 Wiki Activity

Add ORIENTATION_PARENT icon #107763

Merged
Sybren A. Stüvel merged 3 commits from KevinCBurke/blender:parent-icon into main 2023-05-11 14:50:36 +02:00
Conversation 1 Commits 3 Files Changed 6
Kevin C. Burke commented 2023-05-08 23:03:30 +02:00

Add ORIENTATION_PARENT icon for Parent Orientation enum

image

Add ORIENTATION_PARENT icon for Parent Orientation enum ![image](/attachments/9d5fe54b-f85a-4546-82cb-35955e918206)
image.png
1.5 MiB
❤️ 1
Kevin C. Burke added 1 commit 2023-05-08 23:03:38 +02:00
1ed196f93f Add ORIENTATION_PARENT icon 
Add ORIENTATION_PARENT icon for Parent Orientation enum
Kevin C. Burke added 1 commit 2023-05-08 23:04:05 +02:00
Kevin C. Burke requested review from Nate Rupsis 2023-05-08 23:05:29 +02:00
Kevin C. Burke added 1 commit 2023-05-09 00:20:26 +02:00
Nate Rupsis approved these changes 2023-05-09 05:55:46 +02:00
Nate Rupsis left a comment
Collaborator

Looks great!

Looks great!
❤️ 1
Nate Rupsis requested review from Sybren A. Stüvel 2023-05-09 05:56:03 +02:00
Nate Rupsis requested review from Harley Acheson 2023-05-09 05:56:04 +02:00
Nate Rupsis added the
Module
Animation & Rigging
 label 2023-05-09 05:56:19 +02:00
Kevin C. Burke changed title from WIP: Add ORIENTATION_PARENT icon to Add ORIENTATION_PARENT icon 2023-05-09 17:43:24 +02:00
Harley Acheson commented 2023-05-10 02:55:34 +02:00
Collaborator

Nice! And you have all the correct bits in this PR!

It will look a bit fuzzier than some of the other icons at lower resolutions. When the Blender UI scale is set to 1.0 X on a regular monitor the icons are displayed in the pixel grid as shown below. For example the vertical shaft of the arrow at the top-right will be a pixel of 50% opacity next to a pixel of 50% opacity. It would be a perfect line of white pixels if it were aligned to the grid.

image

Of course at higher resolutions it will look fine. At 2.0 scale (or on a high dpi monitor) that same arrow shaft will be two pixels wide and aligned nicely.

I tried to see if there was some way of improving it but I don't think that I can. The nature of the design doesn't leave a lot of room for nicer alignment. So this might be as nice as it gets. Which is pretty nice!

Nice! And you have all the correct bits in this PR! It will look a bit fuzzier than some of the other icons at lower resolutions. When the Blender UI scale is set to 1.0 X on a regular monitor the icons are displayed in the pixel grid as shown below. For example the vertical shaft of the arrow at the top-right will be a pixel of 50% opacity next to a pixel of 50% opacity. It would be a perfect line of white pixels if it were aligned to the grid. ![image](/attachments/d62ca6f0-80d9-46ea-a822-bd2d4c324443) Of course at higher resolutions it will look fine. At 2.0 scale (or on a high dpi monitor) that same arrow shaft will be two pixels wide and aligned nicely. I tried to see if there was some way of improving it but I don't think that I can. The nature of the design doesn't leave a lot of room for nicer alignment. So this might be as nice as it gets. Which is pretty nice!
image.png
34 KiB
Harley Acheson approved these changes 2023-05-10 02:56:34 +02:00
Sybren A. Stüvel approved these changes 2023-05-11 14:44:13 +02:00
Sybren A. Stüvel left a comment
Collaborator

Thanks Kevin!

Thanks Kevin!
❤️ 1
Sybren A. Stüvel merged commit 061712fcc6 into main 2023-05-11 14:50:36 +02:00
Sybren A. Stüvel deleted branch parent-icon 2023-05-11 14:50:37 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:40 +02:00
Merge in orign/main:

Reviewers

Nate Rupsis approved these changes 2023-05-09 05:55:46 +02:00
Harley Acheson approved these changes 2023-05-10 02:56:34 +02:00
Sybren A. Stüvel approved these changes 2023-05-11 14:44:13 +02:00
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Nate Rupsis
Harley Acheson
Sybren A. Stüvel
Labels
Apply labels
Clear labels   
Interest
Alembic
   
Interest
Animation & Rigging
   
Interest
Asset Browser
   
Interest
Asset Browser Project Overview
   
Interest
Audio
   
Interest
Automated Testing
   
Interest
Blender Asset Bundle
   
Interest
BlendFile
   
Interest
Collada
   
Interest
Compatibility
This issue affects/is about backward or forward compatibility   
Interest
Compositing
   
Interest
Core
   
Interest
Cycles
   
Interest
Dependency Graph
   
Interest
Development Management
   
Interest
EEVEE & Viewport
   
Interest
Freestyle
   
Interest
Geometry Nodes
   
Interest
Grease Pencil
   
Interest
ID Management
   
Interest
Images & Movies
   
Interest
Import Export
   
Interest
Line Art
   
Interest
Masking
   
Interest
Metal
   
Interest
Modeling
   
Interest
Modifiers
   
Interest
Motion Tracking
   
Interest
Nodes & Physics
   
Interest
OpenGL
   
Interest
Overrides
   
Interest
Performance
   
Interest
Physics
   
Interest
Pipeline, Assets & IO
   
Interest
Platforms, Builds & Tests
   
Interest
Python API
   
Interest
Render & Cycles
   
Interest
Render Pipeline
   
Interest
Sculpt, Paint & Texture
   
Interest
Text Editor
   
Interest
Translations
   
Interest
Triaging
   
Interest
Undo
   
Interest
USD
   
Interest
User Interface
   
Interest
UV Editing
   
Interest
VFX & Video
   
Interest
Video Sequencer
   
Interest
Virtual Reality
   
Interest
Vulkan
  
Interest: Wayland
  
Legacy
Blender 2.8 Project
   
Legacy
Milestone 1: Basic, Local Asset Browser
   
Legacy
OpenGL Error
  
Meta
Good First Issue
   
Meta
Papercut
   
Meta
Retrospective
   
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
  
Module
Animation & Rigging
   
Module
Core
   
Module
Development Management
   
Module
EEVEE & Viewport
   
Module
Grease Pencil
   
Module
Modeling
   
Module
Nodes & Physics
   
Module
Pipeline, Assets & IO
   
Module
Platforms, Builds & Tests
   
Module
Python API
   
Module
Render & Cycles
   
Module
Sculpt, Paint & Texture
   
Module
Triaging
   
Module
User Interface
   
Module
VFX & Video
  
Platform
FreeBSD
   
Platform
Linux
   
Platform
macOS
   
Platform
Windows
  
Priority
High
   
Priority
Low
   
Priority
Normal
   
Priority
Unbreak Now!
  
Status
Archived
   
Status
Confirmed
   
Status
Duplicate
   
Status
Needs Info from Developers
   
Status
Needs Information from User
   
Status
Needs Triage
   
Status
Resolved
  
Type
Bug
   
Type
Design
   
Type
Known Issue
   
Type
Patch
   
Type
Report
   
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107763
There is no content yet.
Delete Branch "KevinCBurke/blender:parent-icon"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?