Add ORIENTATION_PARENT icon #107763

Kevin C. Burke · 2023-05-08T23:03:30+02:00

Kevin C. Burke commented

2023-05-08 23:03:30 +02:00

Add ORIENTATION_PARENT icon for Parent Orientation enum

Add ORIENTATION_PARENT icon for Parent Orientation enum ![image](/attachments/9d5fe54b-f85a-4546-82cb-35955e918206)

image.png

1.5 MiB

❤️ 1

Kevin C. Burke added 1 commit 2023-05-08 23:03:38 +02:00

Add ORIENTATION_PARENT icon 1ed196f93f

Add ORIENTATION_PARENT icon for Parent Orientation enum

Kevin C. Burke added 1 commit 2023-05-08 23:04:05 +02:00

Merge branch 'main' into parent-icon 5b62e76725

Kevin C. Burke requested review from Nate Rupsis 2023-05-08 23:05:29 +02:00

Kevin C. Burke added 1 commit 2023-05-09 00:20:26 +02:00

Merge branch 'main' into parent-icon ab57eec93f

Nate Rupsis approved these changes 2023-05-09 05:55:46 +02:00

Nate Rupsis left a comment

Looks great!

❤️ 1

Nate Rupsis requested review from Sybren A. Stüvel 2023-05-09 05:56:03 +02:00

Nate Rupsis requested review from Harley Acheson 2023-05-09 05:56:04 +02:00

Nate Rupsis added the

Module

Animation & Rigging

label 2023-05-09 05:56:19 +02:00

Kevin C. Burke changed title from ~~WIP: Add ORIENTATION_PARENT icon~~ to Add ORIENTATION_PARENT icon

2023-05-09 17:43:24 +02:00

Harley Acheson commented

2023-05-10 02:55:34 +02:00

Nice! And you have all the correct bits in this PR!

It will look a bit fuzzier than some of the other icons at lower resolutions. When the Blender UI scale is set to 1.0 X on a regular monitor the icons are displayed in the pixel grid as shown below. For example the vertical shaft of the arrow at the top-right will be a pixel of 50% opacity next to a pixel of 50% opacity. It would be a perfect line of white pixels if it were aligned to the grid.

Of course at higher resolutions it will look fine. At 2.0 scale (or on a high dpi monitor) that same arrow shaft will be two pixels wide and aligned nicely.

I tried to see if there was some way of improving it but I don't think that I can. The nature of the design doesn't leave a lot of room for nicer alignment. So this might be as nice as it gets. Which is pretty nice!

Nice! And you have all the correct bits in this PR! It will look a bit fuzzier than some of the other icons at lower resolutions. When the Blender UI scale is set to 1.0 X on a regular monitor the icons are displayed in the pixel grid as shown below. For example the vertical shaft of the arrow at the top-right will be a pixel of 50% opacity next to a pixel of 50% opacity. It would be a perfect line of white pixels if it were aligned to the grid. ![image](/attachments/d62ca6f0-80d9-46ea-a822-bd2d4c324443) Of course at higher resolutions it will look fine. At 2.0 scale (or on a high dpi monitor) that same arrow shaft will be two pixels wide and aligned nicely. I tried to see if there was some way of improving it but I don't think that I can. The nature of the design doesn't leave a lot of room for nicer alignment. So this might be as nice as it gets. Which is pretty nice!

image.png

34 KiB

Harley Acheson approved these changes 2023-05-10 02:56:34 +02:00

Sybren A. Stüvel approved these changes 2023-05-11 14:44:13 +02:00

Sybren A. Stüvel left a comment

Thanks Kevin!

❤️ 1

Sybren A. Stüvel referenced this issue from a commit

2023-05-11 14:50:31 +02:00

Add ORIENTATION_PARENT icon

Sybren A. Stüvel merged commit 061712fcc6 into main

2023-05-11 14:50:36 +02:00