blender
/
blender
134
399
Fork 581
Code Issues 6.3k Pull Requests 756 Projects 19 Wiki Activity

Fix #107789: Prevent area maximizing when dragging #107803

Merged
YimingWu merged 3 commits from ChengduLittleA/blender:drag_prevent_maximize into main 2023-06-07 06:21:08 +02:00
Conversation 2 Commits 3 Files Changed 1 +4 -1
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/editors/screen/screen_ops.c
View File

@ -3341,11 +3341,14 @@ static bool screen_maximize_area_poll(bContext *C)
const wmWindow *win = CTX_wm_window(C);
const bScreen *screen = CTX_wm_screen(C);
const ScrArea *area = CTX_wm_area(C);
ChengduLittleA marked this conversation as resolved Outdated
Harley Acheson commented 2023-06-06 22:22:58 +02:00
Outdated
Review
Copy Link

should be const like those above

should be const like those above
const wmWindowManager *wm = CTX_wm_manager(C);
return ED_operator_areaactive(C) &&
/* Don't allow maximizing global areas but allow minimizing from them. */
((screen->state != SCREENNORMAL) || !ED_area_is_global(area)) &&
/* Don't change temporary screens. */
!WM_window_is_temp_screen(win);
!WM_window_is_temp_screen(win) &&
/* Don't maximize when dragging. */
ChengduLittleA marked this conversation as resolved Outdated
Harley Acheson commented 2023-06-06 22:24:17 +02:00
Outdated
Review
Copy Link

This "Not" is incorrect. This would only allow maximizing if you ARE dragging. You'll need to remove that "!" to do what you want.

This "Not" is incorrect. This would only allow maximizing if you ARE dragging. You'll need to remove that "!" to do what you want.
BLI_listbase_is_empty(&wm->drags);
}
static void SCREEN_OT_screen_full_area(wmOperatorType *ot)