Glog: fixed OpenBSD support #107818

Merged
Sergey Sharybin merged 1 commits from Brad-Smith/blender:openbsd_glog_build_fix into main 2023-05-16 09:30:44 +02:00
Contributor
  • Usage of syscall() is not allowed
  • Use getthrid() to retreive the thread ID
- Usage of syscall() is not allowed - Use getthrid() to retreive the thread ID
Brad-Smith force-pushed openbsd_glog_build_fix from 316c3e1046 to 4f5ba31a87 2023-05-10 20:13:29 +02:00 Compare
Author
Contributor

Also FYI I had already pushed this fix upstream.. aca9a23c83

Also FYI I had already pushed this fix upstream.. https://github.com/google/glog/commit/aca9a23c83838997f22b9f6e6f9b6fc98f8b4705
Iliya Katushenock added this to the Platforms, Builds Tests & Devices project 2023-05-14 11:09:58 +02:00

@Sergey any objection to just landing this with a note added in README.blender?

The latest glog release was a year ago so might take a while if we'd have to wait for a new version.

@Sergey any objection to just landing this with a note added in `README.blender`? The latest glog release was a year ago so might take a while if we'd have to wait for a new version.

No objections. We already have some location modifications.

@Brad-Smith Can you add such a note so we can land the PR?

No objections. We already have some location modifications. @Brad-Smith Can you add such a note so we can land the PR?
Author
Contributor

@Brad-Smith Can you add such a note so we can land the PR?

Sure, give me a bit and I'll do so.

> @Brad-Smith Can you add such a note so we can land the PR? Sure, give me a bit and I'll do so.
Brad-Smith force-pushed openbsd_glog_build_fix from 4f5ba31a87 to 8bf62cd82c 2023-05-15 21:43:44 +02:00 Compare

@blender-bot build

@blender-bot build
Sergey Sharybin approved these changes 2023-05-16 09:29:47 +02:00
Sergey Sharybin left a comment
Owner

Thanks!

Thanks!
Sergey Sharybin merged commit 02202dd5a1 into main 2023-05-16 09:30:44 +02:00
Sergey Sharybin deleted branch openbsd_glog_build_fix 2023-05-16 09:30:45 +02:00
Author
Contributor

Please have this back ported to 3.3 if possible.

Please have this back ported to 3.3 if possible.

I've added it to the list to be backported in #100749.

I've added it to the list to be backported in #100749.
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:39 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107818
No description provided.