blender
/
blender
49
199
Fork 258
Code Issues 5.5k Pull Requests 339 Projects 19 Releases Wiki Activity

WIP: Vulkan: Workbench #107886

Draft
Jeroen Bakker wants to merge 57 commits from Jeroen-Bakker/blender:vulkan-draw-manager-workbench into main
pull from: Jeroen-Bakker/blender:vulkan-draw-manager-workbench
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 0 Commits 57 Files Changed 35
Jeroen Bakker commented 2023-05-12 15:46:42 +02:00
Collaborator

This PR contains many smaller changes in order to get workbench working. This PR will be separated into smaller pieces and those will land.

  • Set blend state per color attachment
  • Add conversion FLOAT4 <-> R11F_G11F_B10F
  • GHOST Select compatible surface
  • read back of depth texture read
  • Readback of subarea of texture.
  • Conversion UINT32 <-> GPU_DEPTH_COMPONENT24
  • VKTexture::copy_to
  • Index restart

TODO

  • There is a mismatch when using texel buffers compared to the layout. (Start blender that uses curves in debug mode.)

Known issues

  • Studio lights normals are inverted (issue might be related that the facing isn't part of the gbuffers
  • Depth of field requires working mipmapping
  • Curve rendering requires texel buffers
  • Volumetrics are inversed.

Things to separate and push to main

  • GHOST Surface selection #108169
  • Low precision float conversion #108168
  • Buffer Textures #108193
  • Blend state per color attribute #108419
  • Read back of depth texture #108418
  • Read back of sub area texture #108418
  • 24bit depth workaround
This PR contains many smaller changes in order to get workbench working. This PR will be separated into smaller pieces and those will land. - [x] Set blend state per color attachment - [x] Add conversion `FLOAT4` <-> `R11F_G11F_B10F` - [x] GHOST Select compatible surface - [x] read back of depth texture read - [x] Readback of subarea of texture. - [ ] Conversion `UINT32` <-> `GPU_DEPTH_COMPONENT24` - [x] `VKTexture::copy_to` - [ ] Index restart # TODO - [x] There is a mismatch when using texel buffers compared to the layout. (Start blender that uses curves in debug mode.) # Known issues - [ ] Studio lights normals are inverted (issue might be related that the facing isn't part of the gbuffers - [ ] Depth of field requires working mipmapping - [x] Curve rendering requires texel buffers - [x] Volumetrics are inversed. # Things to separate and push to main - [x] GHOST Surface selection #108169 - [ ] Low precision float conversion #108168 - [x] Buffer Textures #108193 - [x] Blend state per color attribute #108419 - [x] Read back of depth texture #108418 - [x] Read back of sub area texture #108418 - [ ] 24bit depth workaround
Jeroen Bakker added this to the 3.6 LTS milestone 2023-05-12 15:46:42 +02:00
Jeroen Bakker added the
Interest
Vulkan
 label 2023-05-12 15:46:42 +02:00
Jeroen Bakker self-assigned this 2023-05-12 15:46:42 +02:00
Jeroen Bakker added 5 commits 2023-05-12 15:46:49 +02:00
ab725fddd4 Vulkan: IndexBuffer as Subrange 
Add support for index buffers as subrange. When an index buffer
is a subrange it should bind the source buffer and use the index start
as an offset in the buffer.
3a4605a52a Vulkan: Disable Depth Bounds Test 
Depth bounds test was always enabled, but should have be disabled.
With this change the outline of the default cube would become visible.
Jeroen Bakker added this to the EEVEE & Viewport project 2023-05-12 15:46:56 +02:00
Jeroen Bakker added 3 commits 2023-05-15 16:19:29 +02:00
Jeroen Bakker added 1 commit 2023-05-15 21:11:09 +02:00
Jeroen Bakker added 1 commit 2023-05-15 21:14:59 +02:00
Jeroen Bakker added 2 commits 2023-05-16 09:45:26 +02:00
Jeroen Bakker added 3 commits 2023-05-16 11:42:32 +02:00
Jeroen Bakker added 1 commit 2023-05-16 14:02:32 +02:00
Jeroen Bakker added 1 commit 2023-05-16 15:57:50 +02:00
Jeroen Bakker added 1 commit 2023-05-16 16:15:08 +02:00
Jeroen Bakker added 1 commit 2023-05-17 12:30:23 +02:00
Jeroen Bakker added 4 commits 2023-05-19 09:11:32 +02:00
Jeroen Bakker added 1 commit 2023-05-19 11:59:21 +02:00
Jeroen Bakker added 2 commits 2023-05-19 14:46:16 +02:00
Jeroen Bakker added 2 commits 2023-05-19 15:03:01 +02:00
Jeroen Bakker added 1 commit 2023-05-19 15:32:40 +02:00
Jeroen Bakker added 2 commits 2023-05-22 10:57:32 +02:00
Jeroen Bakker added 1 commit 2023-05-22 20:32:03 +02:00
Jeroen Bakker reviewed 2023-05-23 09:33:47 +02:00
source/blender/gpu/vulkan/vk_backend.cc Outdated
@ -159,1 +161,4 @@
GCaps.shader_image_load_store_support = true;
/* Although not used or implemented, it is required to make sure that curve/hair drawing uses the
* right branch. This should be fixed in the draw manager. */
GCaps.transform_feedback_support = true;
Jeroen Bakker commented 2023-05-23 09:33:47 +02:00
Poster
Collaborator

Can be reverted

Can be reverted
Jeroen-Bakker marked this conversation as resolved
Jeroen Bakker added 1 commit 2023-05-23 14:32:51 +02:00
Jeroen Bakker added 2 commits 2023-05-23 15:48:28 +02:00
Jeroen Bakker added 3 commits 2023-05-25 12:01:40 +02:00
Jeroen Bakker added 1 commit 2023-05-25 15:48:39 +02:00
Jeroen Bakker added 1 commit 2023-05-25 16:47:15 +02:00
Jeroen Bakker added 1 commit 2023-05-25 17:34:26 +02:00
Jeroen Bakker added 1 commit 2023-05-26 08:39:44 +02:00
Jeroen Bakker modified the milestone from 3.6 LTS to 4.0 2023-05-26 08:59:11 +02:00
Jeroen Bakker added 1 commit 2023-05-30 09:20:28 +02:00
Jeroen Bakker added 1 commit 2023-05-30 11:38:15 +02:00
Jeroen Bakker added 1 commit 2023-05-30 13:59:29 +02:00
Jeroen Bakker added 1 commit 2023-05-30 15:56:58 +02:00
Jeroen Bakker added 1 commit 2023-05-30 16:11:42 +02:00
Jeroen Bakker added 1 commit 2023-06-01 13:34:29 +02:00
Jeroen Bakker added 1 commit 2023-06-01 13:41:25 +02:00
Jeroen Bakker added 1 commit 2023-06-01 14:08:31 +02:00
Jeroen Bakker added 1 commit 2023-06-01 15:35:27 +02:00
Jeroen Bakker added 1 commit 2023-06-02 09:32:11 +02:00
Jeroen Bakker added 3 commits 2023-06-02 15:44:24 +02:00
Jeroen Bakker added 1 commit 2023-06-02 16:01:51 +02:00
Jeroen Bakker added 1 commit 2023-06-04 09:00:18 +02:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels   
Interest
Alembic
   
Interest
Animation & Rigging
   
Interest
Asset Browser
   
Interest
Asset Browser Project Overview
   
Interest
Audio
   
Interest
Automated Testing
   
Interest
Blender Asset Bundle
   
Interest
BlendFile
   
Interest
Collada
   
Interest
Compositing
   
Interest
Core
   
Interest
Cycles
   
Interest
Dependency Graph
   
Interest
Development Management
   
Interest
Eevee & Viewport
   
Interest
Freestyle
   
Interest
Geometry Nodes
   
Interest
Grease Pencil
   
Interest
ID Management
   
Interest
Images & Movies
  
Interest/Import
Export
  
Interest
Line Art
   
Interest
Masking
   
Interest
Metal
   
Interest
Modeling
   
Interest
Modifiers
   
Interest
Motion Tracking
   
Interest
Nodes & Physics
   
Interest
OpenGL
   
Interest
Overrides
   
Interest
Performance
   
Interest
Physics
   
Interest
Pipeline, Assets & IO
   
Interest
Platforms, Builds & Tests
   
Interest
Python API
   
Interest
Render & Cycles
   
Interest
Render Pipeline
   
Interest
Sculpt, Paint & Texture
   
Interest
Text Editor
   
Interest
Translations
   
Interest
Triaging
   
Interest
Undo
   
Interest
USD
   
Interest
User Interface
   
Interest
UV Editing
   
Interest
VFX & Video
   
Interest
Video Sequencer
   
Interest
Virtual Reality
   
Interest
Vulkan
  
Interest: Wayland
  
Legacy
Blender 2.8 Project
   
Legacy
Milestone 1: Basic, Local Asset Browser
   
Legacy
OpenGL Error
  
Meta
Good First Issue
   
Meta
Papercut
   
Meta
Retrospective
   
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
  
Module
Animation & Rigging
   
Module
Core
   
Module
Development Management
   
Module
Eevee & Viewport
   
Module
Grease Pencil
   
Module
Modeling
   
Module
Nodes & Physics
   
Module
Pipeline, Assets & IO
   
Module
Platforms, Builds & Tests
   
Module
Python API
   
Module
Render & Cycles
   
Module
Sculpt, Paint & Texture
   
Module
Triaging
   
Module
User Interface
   
Module
VFX & Video
  
Platform
FreeBSD
   
Platform
Linux
   
Platform
macOS
   
Platform
Windows
  
Priority
High
   
Priority
Low
   
Priority
Normal
   
Priority
Unbreak Now!
  
Status
Archived
   
Status
Confirmed
   
Status
Duplicate
   
Status
Needs Info from Developers
   
Status
Needs Information from User
   
Status
Needs Triage
   
Status
Resolved
  
Type
Bug
   
Type
Design
   
Type
Known Issue
   
Type
Patch
   
Type
Report
   
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
4.0
Projects
Set Project
Clear projects
No project
EEVEE & Viewport
Assignees
Assign users
Clear assignees
No Assignees
Jeroen Bakker
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107886
There is no content yet.
Delete Branch "Jeroen-Bakker/blender:vulkan-draw-manager-workbench"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?