blender/blender
141
451
Fork 651
Code Issues 6.5k Pull Requests 824 Projects 18 Wiki Activity

Animation: Set hardmin/max for frame start and end of action #107985

Merged
Pratik Borhade merged 8 commits from PratikPB2123/blender:107965-action-frame-range into main 2023-07-06 10:55:39 +02:00
Conversation 2 Commits 8 Files Changed 4 +11 -5
Pratik Borhade commented 2023-05-16 19:17:18 +02:00
Member
Copy Link

Currently start and end property of action don't have hardmin/hardmax. This results in an
error when exporting action having extreme range values in FBX and gltf formats (#107965).

Currently start and end property of action don't have hardmin/hardmax. This results in an error when exporting action having extreme range values in FBX and gltf formats (#107965).
Pratik Borhade added 1 commit 2023-05-16 19:17:28 +02:00 
Currently action range don't have hardmin/hardmax. This causes issue
when exporting action having extreme range values in FBX and gltf formats (#107965).
Pratik Borhade added 1 commit 2023-05-16 19:38:19 +02:00
Pratik Borhade requested review from Sybren A. Stüvel 2023-05-16 19:38:41 +02:00
Pratik Borhade changed title from Animation: Set harmin/max for frame start and end of action to Animation: Set hardmin/max for frame start and end of action 2023-05-16 19:38:55 +02:00
Pratik Borhade commented 2023-05-16 19:39:34 +02:00
Author
Member
Copy Link

@dr.sybren hi, do you think this is useful?

@dr.sybren hi, do you think this is useful?
Pratik Borhade added this to the Animation & Rigging project 2023-05-17 07:06:54 +02:00
Pratik Borhade added the
Module
Animation & Rigging
 label 2023-05-17 07:07:07 +02:00
Pratik Borhade added 1 commit 2023-05-22 17:32:39 +02:00
Pratik Borhade added 1 commit 2023-05-22 17:38:54 +02:00
Sybren A. Stüvel requested changes 2023-06-01 15:01:18 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

MINFRAME doesn't seem to be the right value for a hard minimum, as it's defined as 0. MINAFRAME would be more suitable. Also, because the start/end frame are float, MINAFRAMEF and MAXFRAMEF should be used, and {min,max}_ii should be {min,max}_ff.

`MINFRAME` doesn't seem to be the right value for a hard minimum, as it's defined as `0`. `MINAFRAME` would be more suitable. Also, because the start/end frame are `float`, `MINAFRAMEF` and `MAXFRAMEF` should be used, and `{min,max}_ii` should be `{min,max}_ff`.
Pratik Borhade added 2 commits 2023-06-01 15:30:57 +02:00
Pratik Borhade added 1 commit 2023-06-16 11:05:42 +02:00
Sybren A. Stüvel approved these changes 2023-07-03 12:29:43 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

LGTM, thanks!

Be careful when landing the PR, as by now BLENDER_FILE_SUBVERSION is already at 8.

LGTM, thanks! Be careful when landing the PR, as by now `BLENDER_FILE_SUBVERSION` is already at `8`.
source/blender/blenloader/intern/versioning_400.cc Outdated
@ -257,6 +257,12 @@ void blo_do_versions_400(FileData * /*fd*/, Library * /*lib*/, Main *bmain)
}
}
if (!MAIN_VERSION_ATLEAST(bmain, 400, 8)) {
Sybren A. Stüvel commented 2023-07-03 12:26:39 +02:00
Member
Copy Link

For future PRs, keep the versioning code in the "Versioning code until next subversion bump goes here" section, and only do the subversion bump when landing. Otherwise it's too likely to create conflicts.

For future PRs, keep the versioning code in the "Versioning code until next subversion bump goes here" section, and only do the subversion bump when landing. Otherwise it's too likely to create conflicts.
Pratik Borhade added 1 commit 2023-07-06 10:46:15 +02:00 
Fix merge conflicts
Pratik Borhade merged commit e73273e24b into main 2023-07-06 10:55:39 +02:00
Pratik Borhade deleted branch 107965-action-frame-range 2023-07-06 10:55:41 +02:00
Pratik Borhade commented 2023-07-06 10:56:33 +02:00
Author
Member
Copy Link

Merged, thanks for reviewing :)

For future PRs, keep the versioning code in the "Versioning code until next subversion bump goes here" section

ok

Merged, thanks for reviewing :) > For future PRs, keep the versioning code in the "Versioning code until next subversion bump goes here" section ok
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Animation & Rigging
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107985
No description provided.
Delete Branch "PratikPB2123/blender:107965-action-frame-range"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?