Core: Write mesh and movieclip with new format #108015

Hans Goudey · 2023-05-17T17:13:09+02:00

Hans Goudey commented

2023-05-17 17:13:09 +02:00

Finish the transition from #95966 and fe38715600 by
writing files with the new format for meshes and some movie clip fields.
This removes overhead when saving files, and makes meshes saved in
files smaller (a file with a 1 million face grid changed from 32 to 28 MB).

3.6 can still read files saved with this format, but older versions will
crash. Older files are automatically converted by versioning code when
opened.

This also allows removing all the code that converts from the new
format to the legacy format, previously used when saving files.

Finish the transition from #95966 and fe38715600c8c22d67c3 by writing files with the new format for meshes and some movie clip fields. This removes overhead when saving files, and makes meshes saved in files smaller (a file with a 1 million face grid changed from 32 to 28 MB). 3.6 can still read files saved with this format, but older versions will crash. Older files are automatically converted by versioning code when opened. This also allows removing all the code that converts from the new format to the legacy format, previously used when saving files.

Hans Goudey added 1 commit 2023-05-17 17:13:15 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

7528e73efa Core: Write mesh and movieclip with new format

Finish the transition from #95966 and fe38715600 by
writing files with the new format for meshes and some movie clip fields.
This removes overhead when saving files, and makes meshes saved in
files smaller.

3.6 can still read files saved with this format, but older versions will
crash. Older files are automatically converted by versioning code when
opened.

Hans Goudey commented

2023-05-17 17:13:24 +02:00

@blender-bot build

Hans Goudey added this to the Core project 2023-05-17 17:13:32 +02:00

Hans Goudey requested review from Sergey Sharybin 2023-05-17 17:13:38 +02:00

Sergey Sharybin requested changes 2023-05-17 17:20:08 +02:00

Sergey Sharybin left a comment

Finally!

But there are a couple of comments which needs a second look I think.

Finally! But there are a couple of comments which needs a second look I think.

source/blender/blenkernel/BKE_blender_version.h

						
				@ -31,3 +31,3 @@

				 * version. Older Blender versions will test this and show a warning if the file

				 * was written with too new a version. */

				#define BLENDER_FILE_MIN_VERSION 305

				#define BLENDER_FILE_MIN_VERSION 306

Sergey Sharybin commented

2023-05-17 17:18:14 +02:00

Shouldn't this be 400? Opening the 4.0 files in 3.6 will not work,

Hans Goudey commented

2023-05-17 17:39:29 +02:00

That's mentioned in the description. 3.6 is forward compatible with 4.0, at least for now. (at least for meshes, not quite sure about movie clips)

Sergey Sharybin commented

2023-05-17 17:46:38 +02:00

Ah, right.

I think 3.6 would be able to load the new format for the movie clips as well. At least, it was working fine for the autosave.

Which also means the comment /* NOTE: The regular .blend file saving converts the new format to the legacy format, but the can be removed in the version_motion_tracking_legacy_camera_object().

Ah, right. I think 3.6 would be able to load the new format for the movie clips as well. At least, it was working fine for the autosave. Which also means the comment `/* NOTE: The regular .blend file saving converts the new format to the legacy format, but the` can be removed in the `version_motion_tracking_legacy_camera_object()`.

source/blender/blenloader/intern/versioning_400.cc Outdated

						
				@ -99,2 +95,2 @@

				  LISTBASE_FOREACH (Mesh *, mesh, &bmain->meshes) {

				    version_mesh_legacy_to_struct_of_array_format(*mesh);

				  if (!MAIN_VERSION_ATLEAST(bmain, 400, 1)) {

				    /* This is done here because we will continue to write with the old format until 4.0, so we