Mesh: Remove face map list, convert to integer attribute #108025

Hans Goudey · 2023-05-17T21:12:44+02:00

Hans Goudey commented

2023-05-17 21:12:44 +02:00

Face maps were added as a prototype of a new rigging solution during
2.8 development. Their storage is redundant with the newer generic
attribute system (specifically with integer face attributes), and
they were never used much. This commit removes the face map list
and converts the storage to an attribute with the name face_maps.
There is nowhere to store the face map names anymore, so those
are not kept.

It probably still makes sense to have a feature like mesh face gizmo
selection for rigging. But the design and implementation woulds likely
have to change significantly, including possibly changing the storage
type, and making use of the generic attribute system instead of a
special type.

See #105317 for more discussion.

Face maps were added as a prototype of a new rigging solution during 2.8 development. Their storage is redundant with the newer generic attribute system (specifically with integer face attributes), and they were never used much. This commit removes the face map list and converts the storage to an attribute with the name `face_maps`. There is nowhere to store the face map names anymore, so those are not kept. It probably still makes sense to have a feature like mesh face gizmo selection for rigging. But the design and implementation woulds likely have to change significantly, including possibly changing the storage type, and making use of the generic attribute system instead of a special type. See #105317 for more discussion.

Hans Goudey added 1 commit 2023-05-17 21:12:50 +02:00

Mesh: Remove face map list, convert to integer attribute 1ce88b9020

See #105317

Face maps were added as a prototype of a new rigging solution during
2.8 development. Their storage is redundant with the newer generic
attribute system (specifically with integer face attributes), and
they were never used much. This removes the face map list and
converts the storage to an attribute with the name `face_maps`.
There is nowehere to store the face map names anymore, so those
are not converted.

If it's preferred, the two features removed here (gizmo drawing
and edit mode select similar) could be reimplemented for integer
attributes). Personally I think it's better to wait for more
generic attribute editing/gizmo features though.

Hans Goudey added this to the 4.0 milestone 2023-05-17 21:12:55 +02:00

Hans Goudey added this to the Modeling project 2023-05-17 21:12:59 +02:00

Hans Goudey requested review from Campbell Barton 2023-05-17 21:13:06 +02:00

Nika Kutsniashvili commented

2023-05-18 12:55:41 +02:00

Hello, I use face maps very frequently for creating face sets from edit mode, it is much more convenient to create face maps and turn them into face sets with one click instead of one-by-one. Does this change means I'll no longer be able to create and store face maps? What does this change look like from user perspective

Campbell Barton commented

2023-05-19 05:58:12 +02:00

Hello, I use face maps very frequently for creating face sets from edit mode, it is much more convenient to create face maps and turn them into face sets with one click instead of one-by-one. Does this change means I'll no longer be able to create and store face maps? What does this change look like from user perspective

From a user perspective yes, although the data could be accessed via Python.

Replied to #105317.

> Hello, I use face maps very frequently for creating face sets from edit mode, it is much more convenient to create face maps and turn them into face sets with one click instead of one-by-one. Does this change means I'll no longer be able to create and store face maps? What does this change look like from user perspective From a user perspective yes, although the data could be accessed via Python. Replied to #105317.

Nika Kutsniashvili commented

2023-05-19 18:15:19 +02:00

Hello, I use face maps very frequently for creating face sets from edit mode, it is much more convenient to create face maps and turn them into face sets with one click instead of one-by-one. Does this change means I'll no longer be able to create and store face maps? What does this change look like from user perspective

From a user perspective yes, although the data could be accessed via Python.

Replied to #105317.

Oh well, but I guess I'm one of the very few who use that feature. This won't be missed if Vertex Group could have ability to store Edge and Face groups too as generic attributes, it would also help very much in Geometry Nodes. Thank you for replying.

> > Hello, I use face maps very frequently for creating face sets from edit mode, it is much more convenient to create face maps and turn them into face sets with one click instead of one-by-one. Does this change means I'll no longer be able to create and store face maps? What does this change look like from user perspective > > From a user perspective yes, although the data could be accessed via Python. > > Replied to #105317. Oh well, but I guess I'm one of the very few who use that feature. This won't be missed if Vertex Group could have ability to store Edge and Face groups too as generic attributes, it would also help very much in Geometry Nodes. Thank you for replying.

Hans Goudey added 1 commit 2023-05-19 20:12:37 +02:00

Merge branch 'main' into mesh-remove-face-maps 941cd8ae5e

Hans Goudey added 1 commit 2023-06-03 03:40:44 +02:00

Merge branch 'main' into mesh-remove-face-maps 2edb463a7c

Hans Goudey added 1 commit 2023-06-08 23:18:57 +02:00

Merge branch 'main' into mesh-remove-face-maps 1c7da12758

Campbell Barton approved these changes 2023-06-09 01:27:10 +02:00

Hans Goudey merged commit 46cf093270 into main

2023-06-09 13:54:57 +02:00

Hans Goudey deleted branch mesh-remove-face-maps

2023-06-09 13:54:58 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Mesh: Remove face map list, convert to integer attribute #108025