Depsgraph: Refactor collection builder and add explicit hierarchy #108182

Sergey Sharybin · 2023-05-23T13:14:56+02:00

Sergey Sharybin commented

2023-05-23 13:14:56 +02:00

This is an extract of the non-light-linking specific dependency graph changes done in the cycles-light-linking branch. Those were supposed to be individually reviewed already. but it felt like a good idea to double-check on the changes.

This includes the following two commits

Refactor instanced collection relation builder in depsgraph

Move the instancing related code to a dedicated function, leaving the generic build_collection() dedicated to the building of the collection itself.

Should be no functional changes: the code paths should effectively still be the same. This is because non-instancing cases were passing object as a null pointer, disabling the non-generic code path.

Add explicit object collection hierarchy tracking

The practical problem this change addresses is ability to have base flag dependent functionality in Cycles without re-setting the render on selection. This problem initially arose during the Cycles light linking project.

The original review happened there: #105837

This is an extract of the non-light-linking specific dependency graph changes done in the cycles-light-linking branch. Those were supposed to be individually reviewed already. but it felt like a good idea to double-check on the changes. This includes the following two commits # Refactor instanced collection relation builder in depsgraph Move the instancing related code to a dedicated function, leaving the generic `build_collection()` dedicated to the building of the collection itself. Should be no functional changes: the code paths should effectively still be the same. This is because non-instancing cases were passing object as a null pointer, disabling the non-generic code path. # Add explicit object collection hierarchy tracking The practical problem this change addresses is ability to have base flag dependent functionality in Cycles without re-setting the render on selection. This problem initially arose during the Cycles light linking project. The original review happened there: https://projects.blender.org/blender/blender/pulls/105837

Sergey Sharybin added 2 commits 2023-05-23 13:15:01 +02:00

afc32c5ee3 Refactor instanced collection relation builder in depsgraph

Move the instancing related code to a dedicated function, leaving
the generic `build_collection()` dedicated to the building of the
collection itself.

Should be no functional changes: the code paths should effectively
still be the same. This is because non-instancing cases were passing
object as a null pointer, disabling the non-generic code path.

buildbot/vexp-code-patch-coordinator Build done. Details

38ce26bd26 Depsgraph: Add explicit object collection hierarchy tracking

The practical problem this change addresses is ability to have base
flag dependent functionality in Cycles without re-setting the render
on selection. This problem initially arose during the Cycles light
linking project.

The original review happened there:

    #105837

Sergey Sharybin requested review from Brecht Van Lommel 2023-05-23 13:15:15 +02:00

Sergey Sharybin commented

2023-05-23 13:15:28 +02:00

@blender-bot build

Brecht Van Lommel approved these changes 2023-05-23 13:17:58 +02:00

Sergey Sharybin changed title from ~~deg-collection~~ to Depsgraph: Refactor collection builder and add explicit hierarchy

2023-05-23 13:56:59 +02:00

Sergey Sharybin merged commit 61ed5b3d24 into main

2023-05-23 14:02:51 +02:00

Sergey Sharybin referenced this issue from a commit

2023-05-23 14:02:52 +02:00

Depsgraph: Add explicit object collection hierarchy tracking