Fix #108171: crash calling bpy.ops.uv.pack_islands #108185

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:108171 into blender-v3.6-release 2023-05-24 11:57:28 +02:00
Member

When the operator was executed directly (instead of being invoked as
from the UI), stop, do_update & progress were passed to the job
uninitialized, but pack_islands_startjob assigns to them (leading to
crash).

Now write protect in pack_islands_startjob.

Also fix memleak (missing call to pack_islands_freejob).

When the operator was executed directly (instead of being invoked as from the UI), `stop`, `do_update` & `progress` were passed to the job uninitialized, but `pack_islands_startjob` assigns to them (leading to crash). Now write protect in `pack_islands_startjob`. Also fix memleak (missing call to `pack_islands_freejob`).
Philipp Oeser added 1 commit 2023-05-23 14:06:58 +02:00
e235d397e6 Fix #108171: crash calling bpy.ops.uv.pack_islands
When the operator was executed directly (instead of being invoked as
from the UI), `stop`, `do_update` & `progress` were passed to the job
uninitialized, but `pack_islands_startjob` assigns to them (leading to
crash).

Also fix memleak (missing call to `pack_islands_freejob`).
Philipp Oeser added this to the Modeling project 2023-05-23 14:07:07 +02:00
Philipp Oeser requested review from Campbell Barton 2023-05-23 14:07:13 +02:00
Philipp Oeser removed review request for Campbell Barton 2023-05-23 14:07:22 +02:00
Philipp Oeser requested review from Chris Blackbourn 2023-05-23 14:07:22 +02:00
Philipp Oeser requested review from Campbell Barton 2023-05-23 14:07:36 +02:00

Nice spotting!
It should be safe to pass nullptr in here.
Fix is slightly different, add null-protection around the writes...

Nice spotting! It should be safe to pass `nullptr` in here. Fix is slightly different, add null-protection around the writes...
Author
Member

Nice spotting!
It should be safe to pass nullptr in here.
Fix is slightly different, add null-protection around the writes...

Not sure what the benefit is though?
Anyways, do you want me to update the patch?

> Nice spotting! > It should be safe to pass `nullptr` in here. > Fix is slightly different, add null-protection around the writes... Not sure what the benefit is though? Anyways, do you want me to update the patch?

Not sure what the benefit is though?
It might get called from somewhere else with nullptr parameters.

Anyways, do you want me to update the patch?
Yes please!

> Not sure what the benefit is though? It might get called from somewhere else with `nullptr` parameters. > Anyways, do you want me to update the patch? Yes please!
Campbell Barton approved these changes 2023-05-24 02:33:30 +02:00
Philipp Oeser added 1 commit 2023-05-24 09:05:15 +02:00
Chris Blackbourn approved these changes 2023-05-24 09:25:10 +02:00
Philipp Oeser merged commit c4f39eab88 into blender-v3.6-release 2023-05-24 11:57:28 +02:00
Philipp Oeser deleted branch 108171 2023-05-24 11:57:31 +02:00
Howard Trickey referenced this issue from a commit 2023-05-29 02:51:37 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108185
No description provided.