Fix #108254: Infinite loop in rna_info.BuildRNAInfo when a registered class has a non-registered superclass #108256

Thomas Barlow · 2023-05-25T06:23:59+02:00

Thomas Barlow commented

2023-05-25 06:23:59 +02:00

The while loop in rna_info.get_py_class_from_rna was not mutating the
variables within the loop nor the variable in its condition, meaning it
would loop infinitely if the loop didn't exit in its first iteration.

When yielding registered classes in subclasses_recurse, the function
was erroneously checking if the class' superclass was registered rather
than checking the class itself, causing registered classes to be skipped
if their superclass was not also registered. If the class to be found
was skipped, the while loop would not exit in its first iteration and
would thus loop infinitely.

The while loop has been modified to iterate through each base rna type
until there is no further base type.

The subclasses_recurse function now correctly checks whether the
subclass is registered, not its superclass, when determining if the
subclass should be yielded.

The while loop in `rna_info.get_py_class_from_rna` was not mutating the variables within the loop nor the variable in its condition, meaning it would loop infinitely if the loop didn't exit in its first iteration. When yielding registered classes in `subclasses_recurse`, the function was erroneously checking if the class' superclass was registered rather than checking the class itself, causing registered classes to be skipped if their superclass was not also registered. If the class to be found was skipped, the while loop would not exit in its first iteration and would thus loop infinitely. The while loop has been modified to iterate through each base rna type until there is no further base type. The `subclasses_recurse` function now correctly checks whether the subclass is registered, not its superclass, when determining if the subclass should be yielded.

Thomas Barlow added 1 commit 2023-05-25 06:24:10 +02:00

ba01a3ac64 Fix #108254 : Infinite loop in rna_info.BuildRNAInfo when a registered class has a non-registered superclass

The while loop in `rna_info.get_py_class_from_rna` was not mutating the
variables within the loop nor the variable in its condition, meaning it
would loop infinitely if the loop didn't exit in its first iteration.

When yielding registered classes in `subclasses_recurse`, the function
was erroneously checking if the class' superclass was registered rather
than checking the class itself, causing registered classes to be skipped
if their superclass was not also registered. If the class to be found
was skipped, the while loop would not exit in its first iteration and
would thus loop infinitely.

The while loop has been modified to iterate through each base rna type
until there is no further base type.

The `subclasses_recurse` function now correctly checks whether the
subclass is registered, not its superclass, when determining if the
subclass should be yielded.

Iliya Katushenock added this to the Core project 2023-05-25 07:53:29 +02:00

Iliya Katushenock added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #108254: Infinite loop in rna_info.BuildRNAInfo when a registered class has a non-registered superclass #108256

Checkout