Fix #108229: Wider tolerance shuffling NLA strips #108257

Merged
YimingWu merged 1 commits from ChengduLittleA/blender:fix-108229 into main 2023-06-08 04:15:53 +02:00
Member

In transdata_get_time_shuffle_offset_side, the tolerance for
terminating the loop is too tight, sometimes it will lead to a infinite
loop due to non-integral start/end values. Now fixed.

In `transdata_get_time_shuffle_offset_side`, the tolerance for terminating the loop is too tight, sometimes it will lead to a infinite loop due to non-integral start/end values. Now fixed.
YimingWu added 1 commit 2023-05-25 06:24:41 +02:00
350366b25f Fix #108229: Wider tolerance shuffling NLA strips
In `transdata_get_time_shuffle_offset_side`, the tolerance for
terminating the loop is too tight, sometimes it will lead to a infinite
loop due to non-integral start/end values. Now fixed.
YimingWu added the
Module
Animation & Rigging
Interest
Animation & Rigging
labels 2023-05-25 06:24:54 +02:00
YimingWu added this to the Animation & Rigging project 2023-05-25 06:25:00 +02:00
Sybren A. Stüvel requested review from Sybren A. Stüvel 2023-06-01 14:20:37 +02:00
Sybren A. Stüvel requested review from Nate Rupsis 2023-06-01 14:20:37 +02:00
Sybren A. Stüvel removed the
Interest
Animation & Rigging
label 2023-06-01 14:20:41 +02:00
Member

@ChengduLittleA what are the steps to reproduce this?

@ChengduLittleA what are the steps to reproduce this?
Author
Member

Hi @nrupsis you can check the file in #108229, and drag the second strip to the beginning, but keep a little bit overlap.

Hi @nrupsis you can check the file in #108229, and drag the second strip to the beginning, but keep a little bit overlap.
Nate Rupsis approved these changes 2023-06-07 09:57:54 +02:00
Nate Rupsis left a comment
Member

Was able to reproduce the issue, and can confirm the changes work.

Thanks for the fix!

Was able to reproduce the issue, and can confirm the changes work. Thanks for the fix!
Sybren A. Stüvel approved these changes 2023-06-07 11:02:00 +02:00
Sybren A. Stüvel left a comment
Member

Code LGTM

Code LGTM
YimingWu merged commit 116cbcbc86 into main 2023-06-08 04:15:53 +02:00
YimingWu deleted branch fix-108229 2023-06-08 04:15:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108257
No description provided.