Fix #108363: Light linking does not work when linked to self #108425

Sergey Sharybin · 2023-05-30T15:18:40+02:00

Sergey Sharybin commented

2023-05-30 15:18:40 +02:00

The code which was preventing this originated to an early days of the
light linking project where bits accumulation was done as part of the
graph evaluation. Since then it was changed to be pre-calculated at
the graph build time.

The updates of the receivers is ensured via the HIERARCHY nodes and
relations between them.

Also made it explicit that the emitter is updated with the tag of
the collection: before it was relying on implicit Copy-on-Write
component tag.

The code which was preventing this originated to an early days of the light linking project where bits accumulation was done as part of the graph evaluation. Since then it was changed to be pre-calculated at the graph build time. The updates of the receivers is ensured via the HIERARCHY nodes and relations between them. Also made it explicit that the emitter is updated with the tag of the collection: before it was relying on implicit Copy-on-Write component tag.

Sergey Sharybin added 1 commit 2023-05-30 15:18:50 +02:00

72e2722b3f Fix #108363 : Light linking does not work when linked to self

The code which was preventing this originated to an early days of the
light linking project where bits accumulation was done as part of the
graph evaluation. Since then it was changed to be pre-calculated at
the graph build time.

The updates of the receivers is ensured via the HIERARCHY nodes and
relations between them.

Also made it explicit that the emitter is updated with the tag of
the collection: before it was relying on implicit Copy-on-Write
component tag.

Sergey Sharybin requested review from Brecht Van Lommel 2023-05-30 15:18:57 +02:00

Brecht Van Lommel approved these changes 2023-05-30 17:43:17 +02:00

Brecht Van Lommel left a comment

Could not find issues in testing, seems to work as expected.

Sergey Sharybin merged commit 9b946aeecb into main

2023-05-30 20:22:36 +02:00

Sergey Sharybin deleted branch fix_108363

2023-05-30 20:22:37 +02:00

Sergey Sharybin referenced this issue from a commit

2023-05-30 20:22:38 +02:00

Fix #108363: Light linking does not work when linked to self

Sergey Sharybin referenced this pull request