Fix #108374: Sun light linking issue on direct sampling #108427

Sergey Sharybin · 2023-05-30T17:24:51+02:00

Sergey Sharybin commented

2023-05-30 17:24:51 +02:00

This is a continuation of a fix from the last week in #108311.
The issue was not fully fixed due to a mistake in the regression
test file.

There are two major things which left to be fixed since the
previous patch:

Root nodes can not be shared, even if the local and distant
lights belong to the same light set. If the root node is shared
then the flattening will use the same node index for specialized
trees, which is not a desired behavior.
The node type needs to be preserved when a new node is
created for a subset of emitters. This is because tree sampling
in kernel will handle distant and local lights differently for
nodes where there are multiple emitters.

This is a continuation of a fix from the last week in #108311. The issue was not fully fixed due to a mistake in the regression test file. There are two major things which left to be fixed since the previous patch: 1. Root nodes can not be shared, even if the local and distant lights belong to the same light set. If the root node is shared then the flattening will use the same node index for specialized trees, which is not a desired behavior. 2. The node type needs to be preserved when a new node is created for a subset of emitters. This is because tree sampling in kernel will handle distant and local lights differently for nodes where there are multiple emitters.

light_link_distant_tree.blend

681 KiB

light_link_distant_multi_tree.blend

682 KiB

Sergey Sharybin added 1 commit 2023-05-30 17:24:58 +02:00

b074268675 Fix #108374 : Sun light linking issue on direct sampling

This is a continuation of a fix from the last week in #108311.
The issue was not fully fixed due to a mistake in the regression
test file.

There are two major things which left to be fixed since the
previous patch:

1. Root nodes can not be shared, even if the local and distant
lights belong to the same light set. If the root node is shared
then the flattening will use the same node index for specialized
trees, which is not a desired behavior.

2. The node type needs to be preserved when a new node is
created for a subset of emitters. This is because tree sampling
in kernel will handle distant and local lights differently for
nodes where there are multiple emitters.

Sergey Sharybin added the

Module

Render & Cycles

label 2023-05-30 17:26:18 +02:00

Sergey Sharybin requested review from Brecht Van Lommel 2023-05-30 17:26:22 +02:00

Brecht Van Lommel approved these changes 2023-05-30 17:31:54 +02:00

Sergey Sharybin merged commit 5c25277f6c into main

2023-05-30 17:39:55 +02:00

Sergey Sharybin referenced this issue from a commit

2023-05-30 17:39:57 +02:00

Fix #108374: Sun light linking issue on direct sampling

Sergey Sharybin deleted branch fix_108374

2023-05-30 17:39:59 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #108374: Sun light linking issue on direct sampling #108427