UI: Add Mute property to node panel #108634

Closed

Colin Basnett wants to merge 2 commits from cmbasnett/bdk-blender:add-mute-to-node-panel into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Colin Basnett commented

2023-06-05 21:04:10 +02:00

Member

This adds the Mute property to the Node panel. This also aligns all the properties in columns similar to other panels.

Before:

After:

This adds the `Mute` property to the Node panel. This also aligns all the properties in columns similar to other panels. Before: ![nodebeforemute.png](/attachments/ab251783-a1f2-41b3-8f76-bcf30233f424) After: ![nodeaftermute.png](/attachments/9d9d1f8d-c2a2-4ea3-aa40-8db3b5864d11)

nodebeforemute.png

5.8 KiB

nodeaftermute.png

6.2 KiB

Colin Basnett added 1 commit 2023-06-05 21:04:20 +02:00

d094cb0dff Nodes: Add Mute property to node panel

Colin Basnett added the

Nodes & Physics

labels 2023-06-05 21:04:42 +02:00

Colin Basnett requested review from Pablo Vazquez 2023-06-05 21:05:01 +02:00

Colin Basnett added the

label 2023-06-05 21:06:28 +02:00

Iliya Katushenock commented

2023-06-05 21:19:34 +02:00

Member

Hello, i see (?) reason for this, but i really not sure if such node state should be exposed to user as button in panel. Is there use case?

Hello, i see (?) reason for this, but i really not sure if such node state should be exposed to user as button in panel. Is there use case?

Colin Basnett commented

2023-06-05 22:23:53 +02:00

Author

Member

Yes, my specific use case was that I wanted to inspect the driver on the mute property (i.e., right click, edit driver). Without this property being exposed, I had to go and manually find it in the driver editor which is not ideal.

Yes, my specific use case was that I wanted to inspect the driver on the mute property (i.e., right click, edit driver). Without this property being exposed, I had to go and manually find it in the driver editor which is not ideal.

Hans Goudey commented

2023-06-05 22:37:37 +02:00

Member

Didn't look into this much now, but it's probably worth making sure this addresses the issue from this old patch: https://archive.blender.org/developer/differential/0013/0013486/index.html

Didn't look into this much now, but it's probably worth making sure this addresses the issue from this old patch: https://archive.blender.org/developer/differential/0013/0013486/index.html

Colin Basnett changed title from ~~UI: Add Mute property to node panel~~ to WIP: UI: Add Mute property to node panel

2023-06-05 23:01:01 +02:00

Colin Basnett added 1 commit 2023-06-06 03:47:50 +02:00

fbd1de59df Now hiding the mute option for nodes that are not mutable (using new `mute_supported` read-only property).

Colin Basnett changed title from ~~WIP: UI: Add Mute property to node panel~~ to UI: Add Mute property to node panel

2023-06-06 03:48:08 +02:00

Colin Basnett commented

2023-06-06 03:48:59 +02:00

Author

Member

@HooglyBoogly I've added the mute_supported as a read-only property for the Node type and have hidden the mute option when muting is not allowed, as per the previous diff.

@HooglyBoogly I've added the `mute_supported` as a read-only property for the `Node` type and have hidden the `mute` option when muting is not allowed, as per the previous diff.

Iliya Katushenock commented

2023-06-06 06:11:54 +02:00

Member

What's the point of animating a muted node? It sounds like commenting out the code with a flag macro...

What's the point of animating a muted node? It sounds like commenting out the code with a flag macro...

Colin Basnett commented

2023-06-06 09:41:29 +02:00

Author

Member

I am developing an add-on that provides the user a way to create a complex geometry node setup through a simpler interface.

The hide buttons here are controlling the mute property of certain nodes of the generated node tree.

I am developing an add-on that provides the user a way to create a complex geometry node setup through a simpler interface. The hide buttons here are controlling the mute property of certain nodes of the generated node tree. <video src="/attachments/612d66b7-3ccb-4a40-bcd2-663d72f0a088" title="2023-06-06 00-40-35.mp4" controls></video>

2023-06-06 00-40-35.mp4

1.2 MiB

Colin Basnett requested review from Hans Goudey 2023-06-06 21:57:09 +02:00

Colin Basnett requested review from Brecht Van Lommel 2023-06-06 21:57:17 +02:00

Brecht Van Lommel commented

2023-06-06 22:18:41 +02:00

Owner

I'm fine with the Mute property showing in the UI, but I don't know that it should be possible to animate or drive it. For two reasons:

In general it's the wrong solution for the use case here, as it affects all instances of a node group. It would be better to expose this as parameter of a node group. There may be limitations in the node groups that make the UI unideal right now though.
For optimization purposes, I would rather not allow the node graph topology to be animated or driven. If sockets are animated then for animation playback we can do optimizations to keep it interactive. However if the topology is animated that is harder, and means we may have to recompile e.g. GPU shaders from scratch every frame.

It's also unclear why an add-on would need drivers for this, as it could just run code to mute/unmute the nodes?

I'm fine with the Mute property showing in the UI, but I don't know that it should be possible to animate or drive it. For two reasons: * In general it's the wrong solution for the use case here, as it affects all instances of a node group. It would be better to expose this as parameter of a node group. There may be limitations in the node groups that make the UI unideal right now though. * For optimization purposes, I would rather not allow the node graph topology to be animated or driven. If sockets are animated then for animation playback we can do optimizations to keep it interactive. However if the topology is animated that is harder, and means we may have to recompile e.g. GPU shaders from scratch every frame. It's also unclear why an add-on would need drivers for this, as it could just run code to mute/unmute the nodes?

Colin Basnett commented

2023-06-06 23:04:46 +02:00

Author

Member

It's also unclear why an add-on would need drivers for this, as it could just run code to mute/unmute the nodes?

I was doing it more out of convenience, in that I can set & forget the driver and not have to manage a reference to the relevant node in my own property group. I could attach the driver to a socket value and it would work just as well.

I'm fine with the Mute property showing in the UI, but I don't know that it should be possible to animate or drive it. For two reasons:

In general it's the wrong solution for the use case here, as it affects all instances of a node group. It would be better to expose this as parameter of a node group. There may be limitations in the node groups that make the UI unideal right now though.

For optimization purposes, I would rather not allow the node graph topology to be animated or driven. If sockets are animated then for animation playback we can do optimizations to keep it interactive. However if the topology is animated that is harder, and means we may have to recompile e.g. GPU shaders from scratch every frame.

Yea, those are both good points. Do you think the animatable flag should be removed from the mute property? If so, I can make another PR to do just that.

> It's also unclear why an add-on would need drivers for this, as it could just run code to mute/unmute the nodes? I was doing it more out of convenience, in that I can set & forget the driver and not have to manage a reference to the relevant node in my own property group. I could attach the driver to a socket value and it would work just as well. > I'm fine with the Mute property showing in the UI, but I don't know that it should be possible to animate or drive it. For two reasons: > > * In general it's the wrong solution for the use case here, as it affects all instances of a node group. It would be better to expose this as parameter of a node group. There may be limitations in the node groups that make the UI unideal right now though. > * For optimization purposes, I would rather not allow the node graph topology to be animated or driven. If sockets are animated then for animation playback we can do optimizations to keep it interactive. However if the topology is animated that is harder, and means we may have to recompile e.g. GPU shaders from scratch every frame. Yea, those are both good points. Do you think the animatable flag should be removed from the `mute` property? If so, I can make another PR to do just that.

Iliya Katushenock commented

2023-06-07 11:20:58 +02:00

Member

It seemed to me that it was rather sugar, which was needed for a quick check.
And not when I thought about his support as something that is subject to animation. Even just remote control through drivers.
If I wanted to do this, it would be a switch node just...

It seemed to me that it was rather sugar, which was needed for a quick check. And not when I thought about his support as something that is subject to animation. Even just remote control through drivers. If I wanted to do this, it would be a switch node just...

Brecht Van Lommel commented

2023-06-07 15:53:57 +02:00

Owner

I'd be fine with a PR that disables animation/drivers for the mute property.

I'd be fine with a PR that disables animation/drivers for the mute property.

Colin Basnett referenced this issue from a commit

2023-06-11 04:10:09 +02:00

The mute property is not longer animatable

Colin Basnett referenced this pull request

2023-06-11 04:11:42 +02:00

Nodes: Don't allow animation for node mute property #108849

Colin Basnett commented

2023-06-11 04:12:37 +02:00

Author

Member

@brecht #108849 removes the animatable flag from the mute property.

@brecht https://projects.blender.org/blender/blender/pulls/108849 removes the animatable flag from the mute property.

Colin Basnett referenced this issue from a commit

2023-06-26 11:40:20 +02:00

Nodes: Don't allow animation for node mute property

Christoph Lendenfeld referenced this issue from a commit

2023-07-06 10:14:57 +02:00

Nodes: Don't allow animation for node mute property

Colin Basnett commented

2023-07-21 06:59:32 +02:00

Author

Member

Abandoning this since the original purpose is now moot as of #108849.

Abandoning this since the original purpose is now moot as of #108849.

Colin Basnett closed this pull request

2023-07-21 06:59:34 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108634

No description provided.