Fix #106759: Error on running blender_icons_geom.py with curve #108647

Merged

Philipp Oeser merged 2 commits from lichtwerk/blender:106759 into blender-v3.6-release

2023-06-08 10:22:00 +02:00

Philipp Oeser commented

2023-06-06 09:48:51 +02:00

Member

288e7d0af0 added support for legacy curves, these dont have attributes
though, but code was checking for an active color atttribute.

Now, only do this check (and skip that object) if it is a mesh (that
doesnt have vertex an active color atttribute).

288e7d0af0c2 added support for legacy curves, these dont have attributes though, but code was checking for an active color atttribute. Now, only do this check (and skip that object) if it is a mesh (that doesnt have vertex an active color atttribute).

Philipp Oeser added 1 commit 2023-06-06 09:49:02 +02:00

eb581c0281 Fix #106759 : Error on running blender_icons_geom.py with curve

288e7d0af0 added support for legacy curves, these dont have attributes
though, but code was checking for an active color atttribute.

Now, only do this check (and skip that object) if it is a mesh (that
doesnt have vertex an active color atttribute).

Philipp Oeser added this to the User Interface project 2023-06-06 09:49:16 +02:00

Philipp Oeser requested review from Dalai Felinto 2023-06-06 09:49:23 +02:00

Philipp Oeser added the

label 2023-06-06 09:49:33 +02:00

Dalai Felinto requested changes 2023-06-06 10:19:57 +02:00

Dalai Felinto left a comment

Owner

I would try something like this:

diff --git a/release/datafiles/blender_icons_geom.py b/release/datafiles/blender_icons_geom.py
index 45447892700..ae15dccae32 100644
--- a/release/datafiles/blender_icons_geom.py
+++ b/release/datafiles/blender_icons_geom.py
@@ -45,7 +45,7 @@ import bpy
 
 # Generic functions
 
-OBJECTS_TYPES_MESH_COMPATIBLE = {'CURVE', 'MESH'}
+OBJECTS_TYPES_MESH_COMPATIBLE = {'CURVE', 'CURVES', 'MESH'}
 
 
 def area_tri_signed_2x_v2(v1, v2, v3):
@@ -350,7 +350,7 @@ def main():
         if name.rpartition(".")[2].isdigit():
             continue
 
-        if not ob_eval.data.attributes.active_color:
+        if (not hasattr(ob_eval.data, 'attributes')) or not ob_eval.data.attributes.active_color:
             print("Skipping:", name, "(no vertex colors)")
             continue

I haven't tested it though, but this would make things a bit more future proof. Also notice that CURVES have attributes, while CURVE doesn't.

I would try something like this: ```diff diff --git a/release/datafiles/blender_icons_geom.py b/release/datafiles/blender_icons_geom.py index 45447892700..ae15dccae32 100644 --- a/release/datafiles/blender_icons_geom.py +++ b/release/datafiles/blender_icons_geom.py @@ -45,7 +45,7 @@ import bpy # Generic functions -OBJECTS_TYPES_MESH_COMPATIBLE = {'CURVE', 'MESH'} +OBJECTS_TYPES_MESH_COMPATIBLE = {'CURVE', 'CURVES', 'MESH'} def area_tri_signed_2x_v2(v1, v2, v3): @@ -350,7 +350,7 @@ def main(): if name.rpartition(".")[2].isdigit(): continue - if not ob_eval.data.attributes.active_color: + if (not hasattr(ob_eval.data, 'attributes')) or not ob_eval.data.attributes.active_color: print("Skipping:", name, "(no vertex colors)") continue ``` I haven't tested it though, but this would make things a bit more future proof. Also notice that CURVES have attributes, while CURVE doesn't.

Philipp Oeser added 1 commit 2023-06-06 11:12:22 +02:00

f7b66cedf5 be more general in checking existance of attribute

we could have other object types supported as well (e.g. curves -- which
I wont add in this commit to make this a pure bugfix)

Philipp Oeser commented

2023-06-06 11:14:03 +02:00

Author

Member

Yeah, makes sense (I didnt add the support for curves in this commit though to make this a "pure" fix)

Yeah, makes sense (I didnt add the support for curves in this commit though to make this a "pure" fix)

Dalai Felinto approved these changes 2023-06-08 09:57:01 +02:00

Philipp Oeser merged commit 7ffd73100e into blender-v3.6-release

2023-06-08 10:22:00 +02:00

Philipp Oeser referenced this issue from a commit

2023-06-08 10:22:01 +02:00

Fix #106759: Error on running blender_icons_geom.py with curve

Philipp Oeser deleted branch 106759

2023-06-08 10:22:03 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108647

No description provided.