WIP: pull request to test a pose library feature #108670

Sybren A. Stüvel · 2023-06-06T17:52:46+02:00

Sybren A. Stüvel commented

2023-06-06 17:52:46 +02:00

This PR contains both #108547 and blender/blender-addons#104673 in order to create a test build for blender/blender-addons#104673

Sybren A. Stüvel added 7 commits 2023-06-06 17:52:53 +02:00

2cd1343af0 Assets: add function to copy asset data to another ID

Add a function `some_id.asset_data.copy_to_id(other_id)` to copy the asset
data from one data-block to another. This is intended to be used in the
pose library, when updating a pose by simply creating a new asset and
having that replace the old one.

This is intentionally taking a copy, even though the above use case could
have sufficed with a higher-level 'move' function. By exposing this as a
copy, it can be used in a wider range of situations, from whatever Python
code wants to use it. This could include copying the asset data from the
active asset to all the other selected ones.

Any pre-existing asset data is freed before the copy is assigned. The
target ID doesn't have to be marked as asset yet for this function to work.
Note that using this function will make the destination ID an asset,
without going through the regular operator.

e7a21c6eda Review feedback

- Move functionality from RNA to ED
- Change from `src.asset_data.copy_to_id(dst)` function to direct
  assignment `dst.asset_data = src.asset_data`

9e1bcc75e2 Allow 'clear asset' by assigning `None`

`id.asset_data = None` is now a way to clear the 'is asset' status. This
makes the assignment symmetrical, as `id.asset_data = some_other_data` can
also be used to actually mark the ID as asset.

3bceeda146 Slightly improve error message when assigning to non-assettable ID type

a65f2437f8 Include comment to explain why you can clear the asset status by assigning None

84b42045c3 Merge remote-tracking branch 'origin/main' into pr/asset-data-copy-to-id

df0ec2b1c9 Disallow mark/clear asset by assigning to `asset_data`

Sybren A. Stüvel added 1 commit 2023-06-06 17:54:01 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

5a0565662e Switch the addons to branch pr/poselib-blender-addons-104673

This is just for the purpose of constructing a test build on the buildbot.

Sybren A. Stüvel commented

2023-06-06 17:54:11 +02:00

@blender-bot package

Blender Bot commented

2023-06-06 17:54:14 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR108670) when ready.

buildbot/vexp-code-patch-coordinator Build done.

Details

This pull request has changes conflicting with the target branch.

source/blender/blenkernel/BKE_asset.h
source/blender/blenkernel/intern/asset.cc
source/blender/editors/asset/ED_asset_mark_clear.h
source/blender/editors/asset/intern/asset_mark_clear.cc
source/blender/makesrna/intern/rna_ID.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u pr/poselib-blender-addons-104673:dr.sybren-pr/poselib-blender-addons-104673

git checkout dr.sybren-pr/poselib-blender-addons-104673

Sign in to join this conversation.

No reviewers

No Label

Asset Browser Project Overview

Development Management

Pipeline, Assets & IO

Interest

Platforms, Builds & Tests

Sculpt, Paint & Texture

Milestone 1: Basic, Local Asset Browser

Development Management

Pipeline, Assets & IO

Module

Platforms, Builds & Tests

Sculpt, Paint & Texture

Needs Info from Developers

Status

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108670

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: pull request to test a pose library feature #108670

Checkout