Nodes: make node searches use both translated and original names #108681

Open

lictex_ wants to merge 4 commits from lictex/blender:search into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

lictex_ commented

2023-06-06 23:02:16 +02:00

First-time contributor

makes the english name of nodes always available for add node search & drag link search, regardless of the interface language

typing a name with IMEs isnt that fast. when using searching as a shortcut, some interface lang (like chinese) users might be slower than an english user

(however to avoid bloating the ui, the english name wont show up. so users might not be able to directly find out what english name of a node is.. consider this is a somewhat advanced operation i think its acceptable)

also a rcs request about this: https://blender.community/c/rightclickselect/sFcbbc

makes the english name of nodes always available for add node search & drag link search, regardless of the interface language typing a name with IMEs isnt that fast. when using searching as a shortcut, some interface lang (like chinese) users might be slower than an english user (however to avoid bloating the ui, the english name wont show up. so users might not be able to directly find out what english name of a node is.. consider this is a somewhat advanced operation i think its acceptable) also a rcs request about this: https://blender.community/c/rightclickselect/sFcbbc ---- <video src="/attachments/7841d105-f876-484c-8395-214cf665abc8" title="0.webm" controls></video>

258 KiB

lictex_ added 1 commit 2023-06-06 23:02:21 +02:00

e5f025c248 make node searches use both translated and original names

Iliya Katushenock added the

Nodes & Physics

labels 2023-06-07 10:59:49 +02:00

Damien Picard commented

2023-06-27 20:29:42 +02:00

Member

This makes sense, but there are a few issues:

Some translations are associated with a context. After this change, those are no longer used. For example, try searching for "Ceil" or any operation from the Math node. The search comes up with items in English instead of the local language. In this capture, Ceil is supposed to be translated to "Plafond" in French:
Many translation macros (IFACE_()) were removed, so these messages are no longer extracted to the .po files after applying this PR, and they become untranslatable:

"End (Length)"
"Factor (Non-Uniform)"
"End (Factor)"
"Add a new simulation input and output nodes to the node tree"
"Start (Length)"
"Start (Factor)"

To fix this, the translation macros can be replaced by simple extraction macros N_(), or new extraction regexes can be introduced for add_item(), in the same style as 6d39ba7b41.

This makes sense, but there are a few issues: - Some translations are associated with a context. After this change, those are no longer used. For example, try searching for "Ceil" or any operation from the Math node. The search comes up with items in English instead of the local language. In this capture, Ceil is supposed to be translated to "Plafond" in French: ![image](/attachments/2aa0cb98-a0bd-43bf-823f-1587192e243b) - Many translation macros (`IFACE_()`) were removed, so these messages are no longer extracted to the .po files after applying this PR, and they become untranslatable: ``` "End (Length)" "Factor (Non-Uniform)" "End (Factor)" "Add a new simulation input and output nodes to the node tree" "Start (Length)" "Start (Factor)" ``` To fix this, the translation macros can be replaced by simple extraction macros `N_()`, or new extraction regexes can be introduced for `add_item()`, in the same style as 6d39ba7b41d.

40 KiB

lictex_ added 3 commits 2023-07-04 10:11:51 +02:00

0624aedac3 use translation markers

0a8af28a9d fix socket translation contexts

3fc9ca9f45 Merge remote-tracking branch 'upstream/main' into search

lictex_ commented

2023-07-04 11:11:49 +02:00

Author

First-time contributor

think they should work well now

functions like add_item() however seem to be difficult to match by regexes, as some more complex args are there (like closures)..

think they should work well now functions like `add_item()` however seem to be difficult to match by regexes, as some more complex args are there (like closures)..

Damien Picard commented

2023-07-05 22:51:53 +02:00

Member

Looks better, but some markers are now useless. N() is only useful with a literal inside, so it has no effect on things like N_(item->name), N_(name.c_str()), etc.

(There is still an issue with the "Ceil" from vector maths, but it was already there before and can be fixed separately.)

Looks better, but some markers are now useless. `N()` is only useful with a literal inside, so it has no effect on things like `N_(item->name)`, `N_(name.c_str())`, etc. (There is still an issue with the "Ceil" from vector maths, but it was already there before and can be fixed separately.)

Damien Picard requested review from Bastien Montagne 2023-07-05 22:52:27 +02:00

Bastien Montagne commented

2023-07-06 10:26:46 +02:00

Owner

This is a fairly big change to our UI, think it needs design validation from the UI team first. Among other questions, I would expect such issue to be present in any type of search menu over items with translated names? This is also not really needed in many languages (all the roman-based one e.g.) I believe, so probably would need to be an opt-in option, maybe with default ON in case detected language of the user matches a certain set of these?

This is a fairly big change to our UI, think it needs design validation from the UI team first. Among other questions, I would expect such issue to be present in any type of search menu over items with translated names? This is also not really needed in many languages (all the roman-based one e.g.) I believe, so probably would need to be an opt-in option, maybe with default ON in case detected language of the user matches a certain set of these?

Bastien Montagne refused to review 2023-07-06 10:26:52 +02:00

Bastien Montagne added

and removed

labels 2023-07-06 10:27:13 +02:00

This pull request has changes conflicting with the target branch.

source/blender/editors/space_node/add_node_search.cc
source/blender/editors/space_node/link_drag_search.cc
source/blender/nodes/NOD_add_node_search.hh
source/blender/nodes/geometry/nodes/node_geo_accumulate_field.cc
source/blender/nodes/geometry/nodes/node_geo_sample_volume.cc
source/blender/nodes/geometry/nodes/node_geo_simulation_output.cc
source/blender/nodes/intern/add_node_search.cc
source/blender/nodes/intern/socket_search_link.cc
source/blender/nodes/shader/nodes/node_shader_mix.cc
source/blender/nodes/shader/nodes/node_shader_vector_math.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u search:lictex-search

git checkout lictex-search

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108681

No description provided.