Cleanup: replace the use of listbase in io_alembic.cc with vector #108686

Guillermo Venegas · 2023-06-07T05:08:32+02:00

Guillermo Venegas commented

2023-06-07 05:08:32 +02:00

No visible changes expected.

See: #103343

No visible changes expected. See: #103343

Guillermo Venegas added 1 commit 2023-06-07 05:08:37 +02:00

6a2603ed19 Cleanup: replace the use of listbase in io_allembic.cc with vector

No visible changes expected.

Hans Goudey commented

2023-06-07 14:23:59 +02:00

In Blender code we typically use Vector (blender::Vector) instead of std::vector.

In Blender code we typically use `Vector` (`blender::Vector`) instead of `std::vector`.

Guillermo Venegas added 1 commit 2023-06-07 14:46:58 +02:00

2c61583c3e Merge remote-tracking branch 'origin' into cleanup-io-allembic-listbase

Guillermo Venegas changed title from ~~Cleanup: replace the use of listbase in io_allembic.cc with vector~~ to Cleanup: replace the use of listbase in io_alembic.cc with vector

2023-06-07 14:58:24 +02:00

Guillermo Venegas added 1 commit 2023-06-07 15:05:16 +02:00

c1108f23a1 use blender::vector instead of std::vector

Guillermo Venegas added 1 commit 2023-06-10 04:10:28 +02:00

782a356e40 fix sort predicate

Iliya Katushenock commented

2023-06-10 11:33:09 +02:00

if (frames.size() > 0) {...} return 1; -> if (frames.is_empty()) { return 1; } ...
blender::Vector<CacheFrame> frames{}; -> blender::Vector<CacheFrame> frames;
int frame_curr = frames[0].framenr; -> int frame_curr = frames.first().framenr;

`if (frames.size() > 0) {...} return 1;` -> `if (frames.is_empty()) { return 1; } ...` `blender::Vector<CacheFrame> frames{};` -> `blender::Vector<CacheFrame> frames;` `int frame_curr = frames[0].framenr;` -> `int frame_curr = frames.first().framenr;`

👍 1

Guillermo Venegas added 1 commit 2023-06-10 19:13:51 +02:00

a04a7346d0 Merge remote-tracking branch 'origin' into cleanup-io-allembic-listbase

Guillermo Venegas added 1 commit 2023-06-10 19:28:06 +02:00

5e3015f767 cleanup

Guillermo Venegas added 1 commit 2023-06-10 21:28:06 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

995d87c439 cleanup

Guillermo Venegas commented

2023-06-10 21:29:07 +02:00

Thanks, done!

Hans Goudey reviewed 2023-06-15 21:53:44 +02:00

Hans Goudey left a comment

Just to be sure, did you test this functionality before and after the change?

Hans Goudey commented

2023-06-15 21:54:00 +02:00

@blender-bot build

Guillermo Venegas commented

2023-06-15 22:54:51 +02:00

yes here is a test on console

and with this files, but tbh not I'm not really sure what the importer does with that number

yes here is a test on console ![image](/attachments/c29e23f6-84c6-46fe-b5dc-ecc94b0bff7d) and with this files, but tbh not I'm not really sure what the importer does with that number ![image](/attachments/e1a5485b-778c-4ec2-bcfb-9665317859b4)

image.png

200 KiB

image.png

180 KiB

image.png

9.7 KiB