Text: remove syntax highlighting for POV & POV-INI #108689

Campbell Barton · 2023-06-07T08:34:00+02:00

Campbell Barton commented

2023-06-07 08:34:00 +02:00

Remove text editor formatters for languages not directly supported by Blender,
these were added a while ago, and I don't think we get much value from distributing Blender with them.

These formatters contain around 1800 lines of code, while they work well and have not been a maintenance burden, I don't think they provide much in the way of user benefits either.

As a rule of thumb I think it's reasonable to support formatting for text files which Blender uses as part of it's core functionality, which leaves us with Python & OSL.

In the future we might want to expand this to include defacto standards such as JSON/TOML.
Although I don't see this as a priority either.

Remove text editor formatters for languages not directly supported by Blender, these were added a while ago, and I don't think we get much value from distributing Blender with them. ---- These formatters contain around 1800 lines of code, while they work well and have not been a maintenance burden, I don't think they provide much in the way of user benefits either. As a rule of thumb I think it's reasonable to support formatting for text files which Blender uses as part of it's core functionality, which leaves us with `Python` & `OSL`. In the future we might want to expand this to include defacto standards such as JSON/TOML. Although I don't see this as a priority either.

Campbell Barton changed title from ~~Text: Remove formatters for LUA/POVRay & POVRay INI~~ to Text: Remove formatters for LUA, POV & POV-INI

2023-06-07 08:34:41 +02:00

Campbell Barton requested review from Maurice Raybaud 2023-06-07 08:38:03 +02:00

Campbell Barton requested review from Bastien Montagne 2023-06-07 08:38:04 +02:00

Campbell Barton commented

2023-06-07 08:41:49 +02:00

Added Maurice Raybaud who implemented the initial POVRAY formatter, I can't add @btolputt (likely the account is inactive).

Campbell Barton changed title from ~~Text: Remove formatters for LUA, POV & POV-INI~~ to Text: remove syntax highlighting for LUA, POV & POV-INI

2023-06-07 08:50:23 +02:00

BenjaminTolputt commented

2023-06-07 09:14:28 +02:00

First-time contributor

... I can't add @btolputt (likely the account is inactive).

I'm still around but not active in development anymore. I'm perfectly OK with removing the Lua formatters I put together for Blender given it's a hold-over from the Game Engine integration stuff that's LONG been removed/outdated from the Blender codebase.

I still think it would be better if there were a way to add text formatters without hard-coding them, but that's a completely different issue than here, so I'll leave it at "Go ahead, happy to see them go"

> ... I can't add @btolputt (likely the account is inactive). > I'm still around but not active in development anymore. I'm perfectly OK with removing the Lua formatters I put together for Blender given it's a hold-over from the Game Engine integration stuff that's LONG been removed/outdated from the Blender codebase. I still think it would be better if there were a way to add text formatters without hard-coding them, but that's a completely different issue than here, so I'll leave it at _"Go ahead, happy to see them go"_

👍 1

Bastien Montagne commented

2023-06-07 11:55:21 +02:00

Am fine with the LUA removal, indeed not related anymore to Blender as it is nowadays.

A bit more hesitant regarding POV removal... As niche as it may be, it still makes some level of sense to keep it imho. Would let @MauriceRaybaud decide on this one.

Am fine with the LUA removal, indeed not related anymore to Blender as it is nowadays. A bit more hesitant regarding POV removal... As niche as it may be, it still makes some level of sense to keep it imho. Would let @MauriceRaybaud decide on this one.

Campbell Barton referenced this issue from a commit

2023-06-10 08:30:51 +02:00

Text Editor: remove support for syntax highlighting LUA

Campbell Barton commented

2023-06-10 09:23:37 +02:00

Removed LUA 95ca04dc20

Removed LUA 95ca04dc207f8bbbdb18287223ba8fdabdd54511

Campbell Barton changed title from ~~Text: remove syntax highlighting for LUA, POV & POV-INI~~ to Text: remove syntax highlighting for POV & POV-INI

2023-06-10 09:23:53 +02:00

Campbell Barton force-pushed pr-text-formatters-remove from 6882946a61 to e4b8cd8a77

2023-06-10 09:27:42 +02:00

Compare

Maurice Raybaud commented

2023-09-17 13:12:26 +02:00

Indeed We'd rather have this stay until external syntax files are supported. Thanks for your patience

Campbell Barton closed this pull request

2023-09-18 05:21:59 +02:00

Campbell Barton commented

2023-09-18 05:22:21 +02:00

Thanks for the feedback, closing this PR then.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Text: remove syntax highlighting for POV & POV-INI #108689

Pull request closed