Fix #105942: Wrong text in MeshSequenceCache and Transform Cache #108701

Merged
Philipp Oeser merged 2 commits from lichtwerk/blender:105942 into blender-v3.6-release 2023-06-15 11:16:10 +02:00
Member

The Alembic procedural was refrenced here even if USD was loaded.

Now check the CacheFile type and let the user know Render Procedurals
are only supported for Alembic atm.

The Alembic procedural was refrenced here even if USD was loaded. Now check the CacheFile type and let the user know Render Procedurals are only supported for Alembic atm.
Philipp Oeser added 1 commit 2023-06-07 14:01:44 +02:00
The Alembic procedural was refrenced here even if USD was loaded.

Now check the CacheFile type and let the user know Render Procedurals
are only supported for Alembic atm.
Philipp Oeser added this to the Pipeline, Assets & IO project 2023-06-07 14:01:55 +02:00
Philipp Oeser requested review from Sybren A. Stüvel 2023-06-07 14:02:06 +02:00
Sybren A. Stüvel requested review from Kévin Dietrich 2023-06-09 12:03:53 +02:00
Sybren A. Stüvel added the
Module
Pipeline, Assets & IO
label 2023-06-09 12:04:05 +02:00
Sybren A. Stüvel approved these changes 2023-06-09 12:05:50 +02:00
Sybren A. Stüvel left a comment
Member

The code LGTM. I've added @kevindietrich as reviewer, as the handling of Alembic procedurals was written by him.

The code LGTM. I've added @kevindietrich as reviewer, as the handling of Alembic procedurals was written by him.
Kévin Dietrich requested changes 2023-06-15 08:44:23 +02:00
Kévin Dietrich left a comment
Member

I think it would be good to also disable the buttons if the cache is not Alembic, e.g.:

uiLayoutSetActive(row, is_alembic && engine_supports_procedural);
I think it would be good to also disable the buttons if the cache is not Alembic, e.g.: ``` uiLayoutSetActive(row, is_alembic && engine_supports_procedural); ```
Philipp Oeser added 1 commit 2023-06-15 10:15:58 +02:00
Kévin Dietrich approved these changes 2023-06-15 10:59:05 +02:00
Philipp Oeser merged commit da052ab9f6 into blender-v3.6-release 2023-06-15 11:16:10 +02:00
Philipp Oeser deleted branch 105942 2023-06-15 11:16:13 +02:00
Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:00:55 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108701
No description provided.