Curves: Add separate start and end amounts to Select End operator #108799
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#108799
Loading…
Reference in New Issue
No description provided.
Delete Branch "filedescriptor/blender:curves-select-ends-mode"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It felt a bit weird to have a boolean to select between front and back, I think using an enum
mode
makes sense here.That also means you could select both ends without having to call the operator twice.
Interesting, I agree this an improvement. But what about exposing a UI more like the Endpoint Selection node?
That seems pretty simple, and also gives the option of selecting a different amount for the start and end.
Ah! Yes I agree, that makes even more sense. Also means that the operator wouldn't need a
RNA_def_enum
which feels a bit better.Curves: Add "mode" for select_endsto Curves: Add "amount_front" and "-back" for select_ends3e12a8fe78
to1627de3197
I changed the operator name from
CURVES_OT_select_end
toCURVES_OT_select_ends
. Not sure if that is ok or not (breaking compatibility?). I can also revert that if needed.Breaking the operator name shouldn't be a problem compared to changing its properties. Anyway, operators have less strict no-breakage requirements I think.
This looks great. I think the UI could be specialized though, to look more like this:
Also, might as well change the operator UI name to "Select Ends" now too.
Curves: Add "amount_front" and "-back" for select_endsto Curves: Add separate front and back amounts to Select End operatorI'm finding the "Front" and "Back" words a bit confusing. Maybe reusing the same "Start" and "End" from the node would make sense too. Other than that this looks good.
Curves: Add separate front and back amounts to Select End operatorto Curves: Add separate start and end amounts to Select End operator