GPv3: "Select Linked" operator #108829

Chao Li · 2023-06-10T02:11:12+02:00

Chao Li commented

2023-06-10 02:11:12 +02:00

This adds OPENCIL_OT_select_linked operator for the new grease pencil
data.

Resolves #108750.

This adds `OPENCIL_OT_select_linked` operator for the new grease pencil data. Resolves #108750.

Chao Li added 1 commit 2023-06-10 02:11:22 +02:00

16174b1747 GPv3: "Select Linked" operator

This adds `OPENCIL_OT_select_linked` operator for the new grease pencil
data.

See #108750

Iliya Katushenock added this to the Grease Pencil project 2023-06-10 02:14:36 +02:00

Iliya Katushenock requested review from Falk David 2023-06-10 02:14:52 +02:00

Falk David requested changes 2023-06-11 16:06:27 +02:00

Falk David left a comment

Few comments on things that need to be deleted.

scripts/startup/bl_ui/space_view3d.py

						
				@ -2031,2 +2031,4 @@

				        layout.separator()

				        layout.operator("grease_pencil.select_linked", text="Linked")

				        layout.operator_menu_enum("grease_pencil.select_grouped", "type", text="Grouped")

Falk David commented

2023-06-11 16:03:10 +02:00

There is no grease_pencil.select_grouped operator yet, so this line needs to be removed.

There is no `grease_pencil.select_grouped` operator yet, so this line needs to be removed.

filedescriptor marked this conversation as resolved

source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc Outdated

						
				@ -64,1 +64,4 @@

				static int select_linked_exec(bContext *C, wmOperator *op)

				{

				  int action = RNA_enum_get(op->ptr, "action");

Falk David commented

2023-06-11 16:05:23 +02:00

There is no need for an action enum in this operator. Should be removed.

There is no need for an `action` enum in this operator. Should be removed.

filedescriptor marked this conversation as resolved

source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc Outdated

						
				@ -65,0 +70,4 @@

				  GreasePencil &grease_pencil = *static_cast<GreasePencil *>(object->data);

				  grease_pencil.foreach_editable_drawing(

				      scene->r.cfra, [action](int /*drawing_index*/, GreasePencilDrawing &drawing) {

Falk David commented

2023-06-11 16:05:53 +02:00

[action] -> []

`[action]` -> `[]`

filedescriptor marked this conversation as resolved

Chao Li added 2 commits 2023-06-11 16:41:00 +02:00

5cc9f1552e Remove action in select linked exec

cce58a5051 Remove select_grouped

Chao Li changed title from ~~GPv3: "Select Linked" operator~~ to WIP: GPv3: "Select Linked" operator

2023-06-11 16:59:21 +02:00

Falk David approved these changes 2023-06-11 17:05:19 +02:00

Falk David left a comment

Thanks for the changes, looks good now.

Please merge your branch with main and resolve the conflicts (Should just be the new operator that was added, so keep both the new operator and move your changes below).

Thanks for the changes, looks good now. Please merge your branch with `main` and resolve the conflicts (Should just be the new operator that was added, so keep both the new operator and move your changes below).

👍 1

Chao Li added 1 commit 2023-06-11 17:27:22 +02:00

c421b1a85c Merge branch 'main' into gpv3-select-linked-local

Chao Li added 1 commit 2023-06-11 17:30:23 +02:00

aca9fd2885 Move grease pencil operator append order to keep consistent

Falk David changed title from ~~WIP: GPv3: "Select Linked" operator~~ to GPv3: "Select Linked" operator

2023-06-11 17:31:07 +02:00

Falk David merged commit 126bff3099 into main

2023-06-11 17:35:54 +02:00

Falk David referenced this issue from a commit

2023-06-11 17:35:56 +02:00

GPv3: "Select Linked" operator