GPv3: Select ends operator #108864

Chao Li · 2023-06-11T19:20:49+02:00

Chao Li commented

2023-06-11 19:20:49 +02:00

This adds Select ends operators.
This resolves #108802.

This adds Select ends operators. This resolves #108802.

Chao Li added 1 commit 2023-06-11 19:20:57 +02:00

318549f92e GPv3: "Select First"/"Select Last" operators

This resolves #108802.

Hans Goudey reviewed 2023-06-12 04:30:25 +02:00

source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc

						
				@ -175,0 +182,4 @@

				  grease_pencil.foreach_editable_drawing(

				      scene->r.cfra,

				      [amount_start, amount_end](int /*drawing_index*/, GreasePencilDrawing &drawing) {

Hans Goudey commented

2023-06-12 04:29:57 +02:00

Just capture [&] in the lambda instead of these specific variables. There's no benefit to being specific here

Just capture `[&]` in the lambda instead of these specific variables. There's no benefit to being specific here

Chao-Li marked this conversation as resolved

source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc

						
				@ -175,0 +183,4 @@

				  grease_pencil.foreach_editable_drawing(

				      scene->r.cfra,

				      [amount_start, amount_end](int /*drawing_index*/, GreasePencilDrawing &drawing) {

				        // TODO: Support different selection domains.

Hans Goudey commented

2023-06-12 04:29:31 +02:00

Comments should use the /* */ style (https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments)

But also this isn't really correct, right? There's no way to support this on the curve domain.

Comments should use the `/* */` style (https://wiki.blender.org/wiki/Style_Guide/C_Cpp#Comments) But also this isn't really correct, right? There's no way to support this on the curve domain.

Falk David commented

2023-06-12 15:05:38 +02:00

Correct, the comment should be removed.

Chao-Li marked this conversation as resolved

Chao Li added 2 commits 2023-06-12 17:44:40 +02:00

c686d365f5 Remove comment

631689c827 Capture [&] instead of specifying vairables

Hans Goudey commented

2023-06-12 17:50:01 +02:00

Thanks for the update. There's some inconsistency in the terminology here. I see first/start/front and last/back/end. I think it would be best to use "start" and "end" consistently in the commit title, description, code, and UI labels.

Chao Li changed title from ~~GPv3: "Select First"/"Select Last" operators~~ to GPv3: "Select Start"/"Select End" operators

2023-06-12 17:57:50 +02:00

Falk David approved these changes 2023-06-12 17:58:16 +02:00

Falk David left a comment

I think it's good the way it is. Since the operator in the menu just selects the first/last point, I wouldn't change that.

source/blender/editors/grease_pencil/intern/grease_pencil_ops.cc Outdated

						
				@ -175,0 +197,4 @@

				{

				  ot->name = "Select Ends";

				  ot->idname = "GREASE_PENCIL_OT_select_ends";

				  ot->description = "Select end points of curves";