Fix #108613: Mute Audio for Playback also mutes for rendering #108871

Richard Antalik · 2023-06-12T02:28:51+02:00

Richard Antalik commented

2023-06-12 02:28:51 +02:00

AUDIO_MUTE flag of scene->audio.flag works as intended and tooltip
for this property is not correct. However muting scene audio for
playback and rendering is not be very useful, since users can render
with no audio explicitly or adjust scene volume.

Add no_muting argument to BKE_scene_update_sound() so muting can be
bypassed for rendering.

`AUDIO_MUTE` flag of `scene->audio.flag` works as intended and tooltip for this property is not correct. However muting scene audio for playback and rendering is not be very useful, since users can render with no audio explicitly or adjust scene volume. Add `no_muting` argument to `BKE_scene_update_sound()` so muting can be bypassed for rendering.

Richard Antalik added 1 commit 2023-06-12 02:28:56 +02:00

Fix 108613 a7b488cfe4

Richard Antalik requested review from Sergey Sharybin 2023-06-12 02:29:04 +02:00

Sergey Sharybin commented

2023-06-12 11:34:49 +02:00

If the muting only supposed to be affecting viewport (non-rendering) then isn't it easier to do

const bool is_mute = (DEG_get_mode(depsgraph) == DAG_EVAL_VIREWPORT) && (scene->audio.flag & AUDIO_MUTE);

?

If the muting only supposed to be affecting viewport (non-rendering) then isn't it easier to do ``` const bool is_mute = (DEG_get_mode(depsgraph) == DAG_EVAL_VIREWPORT) && (scene->audio.flag & AUDIO_MUTE); ``` ?

Richard Antalik commented

2023-06-13 01:58:05 +02:00

Thanks, I wanted to do that, just expected the function in DEG_depshraph.h. Will commit that instead.

Thanks, I wanted to do that, just expected the function in `DEG_depshraph.h`. Will commit that instead.

Richard Antalik closed this pull request

2023-06-13 01:58:06 +02:00

Sergey Sharybin commented

2023-06-13 09:33:41 +02:00

Please go via the code review.

The use of DEG_graph_id_tag_update in the pipeline.cc is not really clear. Like, why is it needed and why only for render depsgraph and only for muting? The newly created dependency graph is not supposed to be tagged for updates for the proper initial evaluaiton.

Please go via the code review. The use of `DEG_graph_id_tag_update` in the `pipeline.cc` is not really clear. Like, why is it needed and why only for render depsgraph and only for muting? The newly created dependency graph is not supposed to be tagged for updates for the proper initial evaluaiton.

Richard Antalik commented

2023-06-13 09:57:39 +02:00

Sorry for that, will update patch next time. The reason for tagging was, because recalc & ID_RECALC_AUDIO_MUTE evaluates to false in BKE_scene_update_sound() when rendering animation.

Sorry for that, will update patch next time. The reason for tagging was, because `recalc & ID_RECALC_AUDIO_MUTE` evaluates to false in `BKE_scene_update_sound()` when rendering animation.

Sergey Sharybin commented

2023-06-13 12:59:32 +02:00

To me this sounds like a description of a symptom, not an actual cause.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #108613: Mute Audio for Playback also mutes for rendering #108871

Pull request closed