Fix #107918: Weight Gradient tool paints over locked vertex groups #108974
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#108974
Loading…
Reference in New Issue
No description provided.
Delete Branch "PratikPB2123/blender:107918-gradient-lock-vgroup"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Exit the operator code if
DG_LOCK_WEIGHT
flag is set for active vertexgroup to avoid painting over locked vertex group.
New function
BKE_object_defgroup_active_is_locked
created to handle this.@ -745,0 +748,4 @@
int ret;
if (dg->flag & DG_LOCK_WEIGHT) {
The code above this line should be extracted into their own function, like
bool BKE_object_defgroup_active_is_locked(ob)
, as "figure out whether the active group is locked" is not part if this function's responsibility. Also I'm fairly sure the logic will have to be used in other areas as well (for example invertex_group_vert_select_unlocked_poll()
), and then it's just a single function call to refactor those. That refactor is not for this PR though.yes, noticed we could use this function in other areas. Let me know if you want the cleanup/refactor in new PR
Much better, just one tiny nag that can be addressed when landing.
@ -146,0 +147,4 @@
/**
* Return lock status of active vertex group.
*/
bool BKE_object_defgroup_active_is_locked(struct Object *ob);
ob
should be aconst
pointer, as it won't get changed by this function.OOPS sorry I accidentally marked the wrong PR as merged! No idea how to un-mark it 😿
Not possible I guess 😅
I'll commit "const pointer" change separately then?
Thanks for the review & merging :)
I didn't merge it! I only marked it as merged by accident, and the commit it now points to is unrelated to this PR (it belongs to #110424).
You could just squash & land things manually and mention the commit hash here for reference?
Committed manually:
6f0477bd1d