Fix: Memory leak while movie strip adding for incorrect/unsupported files #109078

Iliya Katushenock · 2023-06-17T15:27:12+02:00

Iliya Katushenock commented

2023-06-17 15:27:12 +02:00

Any video files in lite debug or simply incorrect files for release will cause this leak.

Iliya Katushenock added 1 commit 2023-06-17 15:27:22 +02:00

963b9e0249 init

Iliya Katushenock requested review from Brecht Van Lommel 2023-06-17 15:28:43 +02:00

Iliya Katushenock added this to the Video Sequencer project 2023-06-17 15:29:27 +02:00

Brecht Van Lommel refused to review 2023-06-19 10:56:14 +02:00

Brecht Van Lommel requested review from Richard Antalik 2023-06-19 10:56:15 +02:00

Richard Antalik commented

2023-06-19 19:04:44 +02:00

I wasn't able to reproduce by adding invalid file, but I assume I am doing something wrong, patch makes sense.

👍 1

Richard Antalik approved these changes 2023-06-19 19:04:55 +02:00

Iliya Katushenock commented

2023-06-19 19:06:04 +02:00

@iss You can just uncheck the visibility flags in the file browser and try adding a blend file.

Richard Antalik commented

2023-06-19 19:09:14 +02:00

I did disable filter and added .blend file instead of movie

Iliya Katushenock commented

2023-06-19 19:11:22 +02:00

Blender quit
Error: Not freed memory blocks: 1, total unfreed memory 0.000313 MB

``` Blender quit Error: Not freed memory blocks: 1, total unfreed memory 0.000313 MB ```

Richard Antalik commented

2023-06-19 19:17:41 +02:00

Here is my log:

Switching to fully guarded memory allocator.
Blender 4.0.0 Alpha
argv[0] = C:\Blender-git\build_windows_x64_vc17_Release\bin\Debug\blender.exe
argv[1] = -d
argv[2] = --debug-memory
argv[3] = -con
argv[4] = --env-system-scripts
argv[5] = C:/Blender-git/1/scripts
Read prefs: "C:\Users\John\AppData\Roaming\Blender Foundation\Blender\4.0\config\userpref.blend"
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2
Version: 4.5.0 NVIDIA 526.98
Context Version: 4.5
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2
Version: 4.5.0 NVIDIA 526.98
Context Version: 4.5
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2
Version: 4.5.0 NVIDIA 526.98
Context Version: 4.5
not an anim: C:\Users\John\Desktop\work\bugs\2.stl
Saved session recovery to "C:\Users\John\AppData\Local\Temp\quit.blend"

Blender quit
Press any key to exit . . .

Can you run Blender with --debug-memory argument? it should give name of allocated block

Here is my log: ``` Switching to fully guarded memory allocator. Blender 4.0.0 Alpha argv[0] = C:\Blender-git\build_windows_x64_vc17_Release\bin\Debug\blender.exe argv[1] = -d argv[2] = --debug-memory argv[3] = -con argv[4] = --env-system-scripts argv[5] = C:/Blender-git/1/scripts Read prefs: "C:\Users\John\AppData\Roaming\Blender Foundation\Blender\4.0\config\userpref.blend" Vendor: NVIDIA Corporation Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2 Version: 4.5.0 NVIDIA 526.98 Context Version: 4.5 Vendor: NVIDIA Corporation Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2 Version: 4.5.0 NVIDIA 526.98 Context Version: 4.5 Vendor: NVIDIA Corporation Renderer: NVIDIA GeForce RTX 3060/PCIe/SSE2 Version: 4.5.0 NVIDIA 526.98 Context Version: 4.5 not an anim: C:\Users\John\Desktop\work\bugs\2.stl Saved session recovery to "C:\Users\John\AppData\Local\Temp\quit.blend" Blender quit Press any key to exit . . . ``` Can you run Blender with `--debug-memory` argument? it should give name of allocated block

Iliya Katushenock commented

2023-06-19 19:19:49 +02:00

sequencer_add_init len: 328 000001D459A6CBB8

`sequencer_add_init len: 328 000001D459A6CBB8`

Richard Antalik commented

2023-06-19 19:29:45 +02:00

Checked with lite build and I could reproduce the issue. Not sure why full build is different... I will try to force leak, perhaps reporting has changed.

Richard Antalik commented

2023-06-19 19:33:28 +02:00

Hmm seems to MSVC issue somehow. Or I have set up arguments incorrectly, but I see the leak in terminal. Will investigate, but this patch is good to go.