blender
/
blender
136
409
Fork 592
Code Issues 6.3k Pull Requests 775 Projects 19 Wiki Activity

Nodes: Skip node tree update for unused sockets of muted node #109088

Open
Iliya Katushenock wants to merge 2 commits from mod_moder/blender:tmp_skip_socket_update into main
pull from: mod_moder/blender:tmp_skip_socket_update
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 2 Files Changed 1 +19 -1
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
source/blender/makesrna/intern/rna_nodetree.cc
View File

@ -2912,7 +2912,25 @@ static void rna_NodeSocket_update(Main *bmain, Scene * /*scene*/, PointerRNA *pt
{
bNodeTree *ntree = reinterpret_cast<bNodeTree *>(ptr->owner_id);
bNodeSocket *sock = static_cast<bNodeSocket *>(ptr->data);
const bool skip_tree_update = [&]() -> bool {
mod_moder marked this conversation as resolved Outdated
Jacques Lucke commented 2023-06-19 20:45:30 +02:00
Outdated
Review
Copy Link

Why use [=] instead of [&]?

Why use `[=]` instead of `[&]`?
Iliya Katushenock commented 2023-06-19 20:51:50 +02:00
Outdated
Review
Copy Link

Just socket/tree pointers, can be captured by value

Just socket/tree pointers, can be captured by value
Jacques Lucke commented 2023-06-19 21:00:00 +02:00
Outdated
Review
Copy Link

Yeah, generally prefer [&] if the lambda does not leave the current scope, unless there is a good reason for doing something else.

Yeah, generally prefer `[&]` if the lambda does not leave the current scope, unless there is a good reason for doing something else.
if (!sock->is_input()) {
return false;
}
ntree->ensure_topology_cache();
const bNode &node = sock->owner_node();
if (!node.is_muted()) {
return false;
}
for (const bNodeLink &link : node.internal_links()) {
if (link.fromsock == sock) {
return false;
}
}
return true;
}();
if (skip_tree_update) {
return;
}
BKE_ntree_update_tag_socket_property(ntree, sock);
ED_node_tree_propagate_change(nullptr, bmain, ntree);
}