Build: update Python, OpenSSL, libtiff, libxml2 to new versions for security #109133

Merged
Brecht Van Lommel merged 4 commits from brecht/blender:fix-cve-3.6 into blender-v3.6-release 2023-06-21 15:14:50 +02:00

Ref #104895

Ref #104895
Brecht Van Lommel added 1 commit 2023-06-19 18:58:11 +02:00
Brecht Van Lommel changed title from Build: update Python, OpenSSL, libtiff, libxml2 to new versions for security to Build: update Python, OpenSSL, libtiff, libxml2 to new versions for security 2023-06-19 18:58:22 +02:00
brecht changed target branch from main to blender-v3.6-release 2023-06-19 18:58:23 +02:00
Brecht Van Lommel added 1 commit 2023-06-20 13:58:35 +02:00
Brecht Van Lommel requested review from Campbell Barton 2023-06-20 14:19:51 +02:00
Brecht Van Lommel requested review from Ray molenkamp 2023-06-20 14:20:01 +02:00
Member

It'll require some messing about but looks like i can make openssl3/python3.10 work on windows, given i have no idea how to update someone-else's patch just land this as is, i'll fix it afterwards.

While browsing the python tracker i did bump into this one highlighting some debug issues on darwin-aarch64

https://github.com/python/cpython/issues/99079#issuecomment-1546511824

unsure if that's a problem for us or not, but something to be aware of nonetheless i suppose.

It'll require some messing about but looks like i can make openssl3/python3.10 work on windows, given i have no idea how to update someone-else's patch just land this as is, i'll fix it afterwards. While browsing the python tracker i did bump into this one highlighting some debug issues on darwin-aarch64 https://github.com/python/cpython/issues/99079#issuecomment-1546511824 unsure if that's a problem for us or not, but something to be aware of nonetheless i suppose.
Ray molenkamp approved these changes 2023-06-20 18:33:48 +02:00
Author
Owner

It seems Python itself will use 3.0 since that is still going to be supported for a long time. I think we might as well use the same version as Python then, to minimize the chance of other bugs.

It seems Python itself will use 3.0 since that is still going to be supported for a long time. I think we might as well use the same version as Python then, to minimize the chance of other bugs.
Brecht Van Lommel added 1 commit 2023-06-20 20:14:56 +02:00
Member

3.0.9 is ok on windows, no issues. I know we usually don't run tests of deps, but given we're a bit off the beaten path here, may i suggest at least manually running the python ssl tests just to make sure the libs check out?

C:\db\build\S\VS1564R\build\python\src\external_python\PCbuild\amd64>python c:\db\build\S\VS1564R\build\python\src\external_python\Lib\test\test_ssl.py

test_ssl: testing with 'OpenSSL 3.0.9 30 May 2023' (3, 0, 0, 9, 0)
          under Windows ('10', '10.0.19044', 'SP0', 'Multiprocessor Free')

[lots of noise here] 

Ran 169 tests in 56.036s

OK (skipped=13)

it was crucial it was run from the build folder on windows, unsure how picky linux/mac will be there.

`3.0.9` is ok on windows, no issues. I know we usually don't run tests of deps, but given we're a bit off the beaten path here, may i suggest at least manually running the python ssl tests just to make sure the libs check out? ``` C:\db\build\S\VS1564R\build\python\src\external_python\PCbuild\amd64>python c:\db\build\S\VS1564R\build\python\src\external_python\Lib\test\test_ssl.py test_ssl: testing with 'OpenSSL 3.0.9 30 May 2023' (3, 0, 0, 9, 0) under Windows ('10', '10.0.19044', 'SP0', 'Multiprocessor Free') [lots of noise here] Ran 169 tests in 56.036s OK (skipped=13) ``` it was crucial it was run from the build folder on windows, unsure how picky linux/mac will be there.

Tested the patch with Blender & ensure tests pass.

Attached a patch with some changes.

  • Update linux_rocky8_setup.sh deps.
  • Changes for openssl to be found by Python: --with-openssl=${LIBDIR}/ssl wasn't working (was looking in ${LIBDIR}/ssl/lib instead of the new location: ${LIBDIR}/ssl/lib64). Now PKG_CONFIG_PATH is used to ensure it's detected.
Tested the patch with Blender & ensure tests pass. Attached a patch with some changes. - Update `linux_rocky8_setup.sh` deps. - Changes for openssl to be found by Python: `--with-openssl=${LIBDIR}/ssl` wasn't working (was looking in `${LIBDIR}/ssl/lib` instead of the new location: `${LIBDIR}/ssl/lib64`). Now `PKG_CONFIG_PATH` is used to ensure it's detected.
Campbell Barton approved these changes 2023-06-21 09:34:51 +02:00
Campbell Barton left a comment
Owner

Accepting, attached patch w/ changes for Linux although these should be tested on macOS too.

Accepting, attached patch w/ changes for Linux although these should be tested on macOS too.
Brecht Van Lommel added 1 commit 2023-06-21 15:12:26 +02:00
Brecht Van Lommel merged commit 97ab330a77 into blender-v3.6-release 2023-06-21 15:14:50 +02:00
Brecht Van Lommel deleted branch fix-cve-3.6 2023-06-21 15:14:51 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109133
No description provided.