Fix: geometry nodes modifier property not working after changing it in Python #109203

Merged

Jacques Lucke merged 1 commits from JacquesLucke/blender:set-property-from-python into blender-v3.6-release

2023-06-21 14:00:47 +02:00

Jacques Lucke commented

2023-06-21 13:47:07 +02:00

Member

This affected only vector and color inputs. The issue was that those were expected to be stored as float-array properties. However, when setting them from python using modifier["Input_X"] = [1, 2, 3] the array type becomes either int or double, but not float. A workaround was to use modifier["Input_X"][:] = [1, 2, 3] as this changes the property inplace.

Now int and double arrays are also understood by the modifier.

This affected only vector and color inputs. The issue was that those were expected to be stored as float-array properties. However, when setting them from python using `modifier["Input_X"] = [1, 2, 3]` the array type becomes either `int` or `double`, but not `float`. A workaround was to use `modifier["Input_X"][:] = [1, 2, 3]` as this changes the property inplace. Now `int` and `double` arrays are also understood by the modifier.

Jacques Lucke added 1 commit 2023-06-21 13:47:17 +02:00

2f5fd62a05 fix

Jacques Lucke requested review from Simon Thommes 2023-06-21 13:49:47 +02:00

Jacques Lucke requested review from Hans Goudey 2023-06-21 13:49:47 +02:00

Hans Goudey approved these changes 2023-06-21 13:58:40 +02:00

Hans Goudey left a comment

Member

Seems reasonable to me, though I think the best behavior would be automatic conversions to the correct type when assigning from Python.

Seems reasonable to me, though I think the best behavior would be automatic conversions to the correct type when assigning from Python.

Jacques Lucke commented

2023-06-21 14:00:09 +02:00

Author

Member

Would be nice, but that's probably not something the IDProperty system should do..

Would be nice, but that's probably not something the `IDProperty` system should do..

Jacques Lucke merged commit 9f30555faf into blender-v3.6-release

2023-06-21 14:00:47 +02:00

Jacques Lucke deleted branch set-property-from-python

2023-06-21 14:00:48 +02:00

Jacques Lucke referenced this issue from a commit

2023-06-21 14:00:49 +02:00

Fix: geometry nodes modifier property not working after changing it in Python

Philipp Oeser commented

2023-06-21 15:22:40 +02:00

Member

#87006 is not touched by this, is it?

#87006 is not touched by this, is it?

Iliya Katushenock commented

2023-06-21 15:25:17 +02:00

Member

@lichtwerk No, this not related with updates. Just property type change internally, but result will be the same.

@lichtwerk No, this not related with updates. Just property type change internally, but result will be the same.

Philipp Oeser commented

2023-06-21 15:28:34 +02:00

Member

ah, thx

ah, thx

Iliya Katushenock referenced this pull request

2023-08-22 14:25:47 +02:00

Geometry Nodes Input Attribute Toggle does not work after toggled via Python #110516

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109203

No description provided.