blender/blender

Realtime Compositor: Add node previews for shader operations #109250

Merged

Omar Emara merged 3 commits from OmarEmaraDev/blender:shader-operation-preview into main

2023-06-23 18:46:25 +02:00

Omar Emara commented

2023-06-22 17:53:26 +02:00

Member

This patch adds support for node previews for shader operations, making
node previews fully supported.

The patch was started as an effort to refactor the compositor compiler
to split the shader operators when node previews increase past hardware
limits. However, I realized that the better approach would be to remove
those limits altogether by using texture arrays instead of individual
textures for operation results, then use texture views to slice that
array. This is not implemented in this patch and will require some
prerequisites, namely adding target conversion to GPU texture views as
well as support texture arrays in the DRW texture pool.

Depends on: #109249.

This patch adds support for node previews for shader operations, making node previews fully supported. The patch was started as an effort to refactor the compositor compiler to split the shader operators when node previews increase past hardware limits. However, I realized that the better approach would be to remove those limits altogether by using texture arrays instead of individual textures for operation results, then use texture views to slice that array. This is not implemented in this patch and will require some prerequisites, namely adding target conversion to GPU texture views as well as support texture arrays in the DRW texture pool. Depends on: #109249.

Omar Emara added the

label 2023-06-22 17:53:26 +02:00

Omar Emara added 2 commits 2023-06-22 17:53:34 +02:00

Nodes: Compute logically linked sockets to outputs b39869a7bc

The logically_linked_sockets runtime data of sockets is only initialized
for inputs. This patch also initializes it for output sockets through
the inversion the inputs logically_linked_sockets structure.

Realtime Compositor: Add node previews for shader operations 753747e859

This patch adds support for node previews for shader operations, making
node previews fully supported.

The patch was started as an effort to refactor the compositor compiler
to split the shader operators when node previews increase past hardware
limits. However, I realized that the better approach would be to remove
those limits altogether by using texture arrays instead of individual
textures for operation results, then use texture views to slice that
array. This is not implemented in this patch and will require some
prerequisites, namely adding target conversion to GPU texture views as
well as support texture arrays in the DRW texture pool.

Depends on: #109249.

Omar Emara requested review from Brecht Van Lommel 2023-06-22 17:54:09 +02:00

Brecht Van Lommel approved these changes 2023-06-23 17:00:39 +02:00

Omar Emara added 1 commit 2023-06-23 18:34:38 +02:00

Merge branch 'main' into shader-operation-preview 5245ab71dc

Omar Emara merged commit c2361381cd into main

2023-06-23 18:46:25 +02:00

Omar Emara referenced this issue from a commit

2023-06-23 18:46:25 +02:00

Realtime Compositor: Add node previews for shader operations

Omar Emara deleted branch shader-operation-preview

2023-06-23 18:46:26 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Viewport & EEVEE

Virtual Reality

Asset Browser Project

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Viewport & EEVEE

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109250

No description provided.