Prioritize non-viewports in region drawing #109338

Joseph Eagar · 2023-06-25T10:03:45+02:00

Joseph Eagar commented

2023-06-25 10:03:45 +02:00

This PR prioritizes non-viewport regions.
wm_draw_window_offscreen now iterates over
regions in two passes; first it checks for non-viewports
and draws them. If it finds any it will defer viewport
region draws to the next call to wm_draw_update.

This greatly improves UI responsiveness when working
with EEVEE, with the exception of any UI element that
causes the shadow buffers to be regenerated, that
still causes a lag.

This is kind of a hack, it is submitted to encourage
discussion.

This PR prioritizes non-viewport regions. `wm_draw_window_offscreen` now iterates over regions in two passes; first it checks for non-viewports and draws them. If it finds any it will defer viewport region draws to the next call to `wm_draw_update`. This greatly improves UI responsiveness when working with EEVEE, with the exception of any UI element that causes the shadow buffers to be regenerated, that still causes a lag. This is kind of a hack, it is submitted to encourage discussion.

Joseph Eagar added 2 commits 2023-06-25 10:03:58 +02:00

Core: Prioritize non-viewports in region drawing cd37329794

This PR prioritizes non-viewport regions.
`wm_draw_window_offscreen` now iterates over
regions in two passes; first it checks for non-viewports
and draws them.  If it finds any it will defer viewport
region draws to the next call to `wm_draw_update`.

This greatly improves UI responsiveness when working
with EEVEE, with the exception of any UI element that
causes the shadow buffers to be regenerated, that
still causes a lag.

This is kind of a hack, it is submitted to encourage
discussion.

Merge branch 'main' into temp-window-ui-draw-priority fd8da9e450

Iliya Katushenock added this to the User Interface project 2023-06-25 10:18:56 +02:00

This pull request has changes conflicting with the target branch.

source/blender/windowmanager/intern/wm_draw.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u temp-window-ui-draw-priority:JosephEagar-temp-window-ui-draw-priority

git checkout JosephEagar-temp-window-ui-draw-priority

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Prioritize non-viewports in region drawing #109338

Checkout